From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Nala Ginrut Newsgroups: gmane.lisp.guile.devel Subject: Re: Support Websocket status code Date: Mon, 29 Jul 2019 14:57:13 +0800 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000089deb3058ecc67c0" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="7186"; mail-complaints-to="usenet@blaine.gmane.org" To: guile-devel Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Jul 29 08:57:33 2019 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrzbA-0001kV-Nk for guile-devel@m.gmane.org; Mon, 29 Jul 2019 08:57:32 +0200 Original-Received: from localhost ([::1]:50044 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrzb9-00012K-QT for guile-devel@m.gmane.org; Mon, 29 Jul 2019 02:57:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59681) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrzb6-00012E-CY for guile-devel@gnu.org; Mon, 29 Jul 2019 02:57:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hrzb5-0005uG-8x for guile-devel@gnu.org; Mon, 29 Jul 2019 02:57:28 -0400 Original-Received: from mail-yw1-xc29.google.com ([2607:f8b0:4864:20::c29]:40617) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hrzb5-0005sg-0p for guile-devel@gnu.org; Mon, 29 Jul 2019 02:57:27 -0400 Original-Received: by mail-yw1-xc29.google.com with SMTP id b143so22294051ywb.7 for ; Sun, 28 Jul 2019 23:57:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=u7ngLBbCUZiwONQga6dIj1zVTZGUjX/ruGL02Aoz1JE=; b=BqtmgXHBsj0n+6jtTeitwdzHzmn94JlNuLw/pldWFmmbSDJ/5VyR6wjFJ/VvgNoHd3 HeYo0wbxpUSIIvkVH+C4AsHfL1wJyaDMXaPs2thStamgqwilE8ha6p8OA+GToUWFivTO RRwcd5/M+VQmB+wcaQBso0GFI36KsgZ/r4vwk065+eTfCbPvX9e2atx+CtCbU23qrbKF pVzV4qogkB+Wr4wfOybUOnHYVyy91+jzNXm0gAbLUEMlxZexgyAtCFYrBnZchJP240+n ln6tT2LeZtoYXDGJkVL8//+gnB4JYLiiyjKOMAvimk5dJpburNvhPWNosICREw8LTTN2 F1yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=u7ngLBbCUZiwONQga6dIj1zVTZGUjX/ruGL02Aoz1JE=; b=cFJjd4XsgRdevACw9kPVmOyD0oKc4q0LKVbrUjJKUGbY/KCm4jr04AvEdaY+BP3WAm zAm59PJlfMhefciTLgZGJWhvDU+lMQrx8JC+Hs5jra7fjEodShNklfzJ3m1chDxCAISq jcQEqw89+MLJaI+1vTBf9VhmNgGrKE6C0fv1vEhVyK1v92t9G9Sb7D4pnQoaRLX2LYqS +ig5RMTbYF7lYJaglA+FN12K7lSsN0mX9SfXVpsq7V7f0BQxh1X0wtQq3FKqYdErSglR 9aBhjcwQzqW66eO7o6jr+UVEY4vSvCEud6oNRuPwilWoxm53OrqWlYJm9DcPCZVLrqxQ GDmw== X-Gm-Message-State: APjAAAW+iAI+fUsdQWc4atIONDF3wPSZyHuSKhPsFlg45Z059GBjj3u0 s+Us3nt/JJkxlrVXsFpSU+RxU+hyW9ilA2bwrR9F35TV1EE= X-Google-Smtp-Source: APXvYqxDe2kwz1ZSSg1KjDfUOjo2ovfCjVpim9iY2i6wCvrVcCN1kAlCvpnxk77iVShKcW0QrQRSXGU+PXxjny2LZpM= X-Received: by 2002:a0d:e184:: with SMTP id k126mr62115456ywe.253.1564383445102; Sun, 28 Jul 2019 23:57:25 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::c29 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.org gmane.lisp.guile.devel:20024 Archived-At: --00000000000089deb3058ecc67c0 Content-Type: multipart/alternative; boundary="00000000000089deb0058ecc67be" --00000000000089deb0058ecc67be Content-Type: text/plain; charset="UTF-8" Here is a patch to add necessary status code, and avoid checking failure when building response. Based on branch stable-2.2 Thanks! On Fri, Jul 26, 2019 at 2:06 PM Nala Ginrut wrote: > Hi folks! > The current response builder will reject status code less than 600: > -------------------------------code------------------------- > ((not (and (non-negative-integer? code) (< code 600))) > (bad-response "Bad code: ~a" code)) > --------------------------------------------------------------- > > However, Websocket specific status code is larger than 1000. > This breaks Artanis Websocket handler to return 500, so that the client > has no way to detect the actual problem. > > Is there any plan to support it? > Or maybe someone is just waiting for a patch? ;-) > > Best regards. > > --00000000000089deb0058ecc67be Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Here is a patch to add necessary status code, and avoid ch= ecking failure when building response.
Based on branch stable-2.2
=

Thanks!


On Fri, Jul 26, 2019 at 2:0= 6 PM Nala Ginrut <nalaginrut@gma= il.com> wrote:
Hi folks!
The current response builder will = reject status code less than 600:
-------------------------------= code-------------------------
=C2=A0((not (and (non-negative-inte= ger? code) (< code 600)))
=C2=A0 (bad-response "Bad code: ~a&quo= t; code))
---------------------------------------------------= ------------

However, Websocket specific status co= de is larger than 1000.
This breaks Artanis Websocket handler to = return 500, so that the client has no way to detect the actual problem.

Is there any plan to support it?
Or maybe s= omeone is just waiting for a patch? ;-)

Best regar= ds.

--00000000000089deb0058ecc67be-- --00000000000089deb3058ecc67c0 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-Websocket-status-code.patch" Content-Disposition: attachment; filename="0001-Add-Websocket-status-code.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jyo1h6kh0 RnJvbSA3NTdiZjk1OWUzNjQ0ODVmMTA1YTk3N2MzZjk3MWI5MjUyZGZiNGRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOYWxhIEdpbnJ1dCA8bXVsZWlAZ251Lm9yZz4KRGF0ZTogTW9u LCAyOSBKdWwgMjAxOSAxNDo1NTozNyArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBXZWJzb2Nr ZXQgc3RhdHVzIGNvZGUKCi0tLQogbW9kdWxlL3dlYi9yZXNwb25zZS5zY20gfCAxNyArKysrKysr KysrKysrKystLQogMSBmaWxlIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvbW9kdWxlL3dlYi9yZXNwb25zZS5zY20gYi9tb2R1bGUvd2ViL3Jl c3BvbnNlLnNjbQppbmRleCAwNmUxYzZkYzEuLjc3YTg1NmE0OCAxMDA2NDQKLS0tIGEvbW9kdWxl L3dlYi9yZXNwb25zZS5zY20KKysrIGIvbW9kdWxlL3dlYi9yZXNwb25zZS5zY20KQEAgLTExOCw3 ICsxMTgsNyBAQCB0aGUgaGVhZGVycyBhcmUgZWFjaCBydW4gdGhyb3VnaCB0aGVpciByZXNwZWN0 aXZlIHZhbGlkYXRvcnMuIgogICAgICAgICAgICAgICAobm9uLW5lZ2F0aXZlLWludGVnZXI/IChj YXIgdmVyc2lvbikpCiAgICAgICAgICAgICAgIChub24tbmVnYXRpdmUtaW50ZWdlcj8gKGNkciB2 ZXJzaW9uKSkpKQogICAgIChiYWQtcmVzcG9uc2UgIkJhZCB2ZXJzaW9uOiB+YSIgdmVyc2lvbikp Ci0gICAoKG5vdCAoYW5kIChub24tbmVnYXRpdmUtaW50ZWdlcj8gY29kZSkgKDwgY29kZSA2MDAp KSkKKyAgICgobm90IChhbmQgKG5vbi1uZWdhdGl2ZS1pbnRlZ2VyPyBjb2RlKSAoPD0gY29kZSAx MDE1KSkpCiAgICAgKGJhZC1yZXNwb25zZSAiQmFkIGNvZGU6IH5hIiBjb2RlKSkKICAgICgoYW5k IHJlYXNvbi1waHJhc2UgKG5vdCAoc3RyaW5nPyByZWFzb24tcGhyYXNlKSkpCiAgICAgKGJhZC1y ZXNwb25zZSAiQmFkIHJlYXNvbiBwaHJhc2UiIHJlYXNvbi1waHJhc2UpKQpAQCAtMTY3LDcgKzE2 NywyMCBAQCB0aGUgaGVhZGVycyBhcmUgZWFjaCBydW4gdGhyb3VnaCB0aGVpciByZXNwZWN0aXZl IHZhbGlkYXRvcnMuIgogICAgICg1MDIgLiAiQmFkIEdhdGV3YXkiKQogICAgICg1MDMgLiAiU2Vy dmljZSBVbmF2YWlsYWJsZSIpCiAgICAgKDUwNCAuICJHYXRld2F5IFRpbWVvdXQiKQotICAgICg1 MDUgLiAiSFRUUCBWZXJzaW9uIE5vdCBTdXBwb3J0ZWQiKSkpCisgICAgKDUwNSAuICJIVFRQIFZl cnNpb24gTm90IFN1cHBvcnRlZCIpCisgICAgKDEwMDAgLiAiTm9ybWFsIENsb3N1cmUiKQorICAg ICgxMDAxIC4gIkdvaW5nIEF3YXkiKQorICAgICgxMDAyIC4gIlByb3RvY29sIGVycm9yIikKKyAg ICAoMTAwMyAuICJVbnN1cHBvcnRlZCBEYXRhIikKKyAgICAoMTAwNCAuICJSZXNlcnZlZCIpCisg ICAgKDEwMDUgLiAiTm8gc3RhdHVzIHJlY2VpdmVkIikKKyAgICAoMTAwNiAuICJBYm5vcm1hbCBD bG9zdXJlIikKKyAgICAoMTAwNyAuICJJbnZhbGlkIGZyYW1lIHBheWxvYWQgZGF0YSIpCisgICAg KDEwMDggLiAiUG9saWN5IFZpb2xhdGlvbiIpCisgICAgKDEwMDkgLiAiTWVzc2FnZSBUb28gQmln IikKKyAgICAoMTAxMCAuICJNYW5kYXRvcnkgRXh0LiIpCisgICAgKDEwMTEgLiAiSW50ZXJuZXQg U2VydmVyIEVycm9yIikKKyAgICAoMTAxNSAuICJUTFMgaGFuZHNoYWtlIikpKQogCiAoZGVmaW5l IChjb2RlLT5yZWFzb24tcGhyYXNlIGNvZGUpCiAgIChvciAoYXNzdi1yZWYgKnJlYXNvbi1waHJh c2VzKiBjb2RlKQotLSAKMi4yMC4xCgo= --00000000000089deb3058ecc67c0--