unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Nala Ginrut <nalaginrut@gmail.com>
To: guile-devel <guile-devel@gnu.org>
Subject: [PATCH] waitpid should not crash on error
Date: Sun, 16 Oct 2011 11:57:38 +0800	[thread overview]
Message-ID: <CAPjoZoeBh+XWZ-CZ3B23-SuGihK2bTTpGWGQUzHyfJZwYwVEgg@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 444 bytes --]

hi guys!
I realized that "waitpid" in Guile will cause my program crash while
"waitpid" actually returned -1. I believe it's unnecessary. I think the
better way is we deal with it by ourselves if "waitpid in POSIX" returned
-1. The SCM_SYSERROR bother me a lot. I hope my program get robustness other
than crash.

Yes I can wrap my own "waipid" for my program if no one get interested in
this patch. Just a suggestion. ;-)
What you guys think?

[-- Attachment #1.2: Type: text/html, Size: 541 bytes --]

[-- Attachment #2: 0001-waitpid-should-return-false-on-error.patch --]
[-- Type: text/x-patch, Size: 709 bytes --]

From 0e4b65ee6b8dfc6cfba01a9a91aa49babaa5d7c7 Mon Sep 17 00:00:00 2001
From: NalaGinrut <NalaGinrut@gmail.com>
Date: Sun, 16 Oct 2011 11:30:25 +0800
Subject: [PATCH] waitpid should return false on error

---
 libguile/posix.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libguile/posix.c b/libguile/posix.c
index 2923dc6..5b8f849 100644
--- a/libguile/posix.c
+++ b/libguile/posix.c
@@ -731,7 +731,7 @@ SCM_DEFINE (scm_waitpid, "waitpid", 1, 1, 0,
     }
   SCM_SYSCALL (i = waitpid (scm_to_int (pid), &status, ioptions));
   if (i == -1)
-    SCM_SYSERROR;
+      return SCM_BOOL_F;
   return scm_cons (scm_from_int (i), scm_from_int (status));
 }
 #undef FUNC_NAME
-- 
1.7.0.4


             reply	other threads:[~2011-10-16  3:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-16  3:57 Nala Ginrut [this message]
2011-10-17 17:00 ` [PATCH] waitpid should not crash on error Mark H Weaver
2011-10-18  2:22   ` Nala Ginrut
2011-10-18 14:58     ` Andy Wingo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPjoZoeBh+XWZ-CZ3B23-SuGihK2bTTpGWGQUzHyfJZwYwVEgg@mail.gmail.com \
    --to=nalaginrut@gmail.com \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).