From: Nala Ginrut <nalaginrut@gmail.com>
To: Mark H Weaver <mhw@netris.org>
Cc: "Ludovic Courtès" <ludo@gnu.org>, guile-devel <guile-devel@gnu.org>
Subject: Re: [PATCH] Add-native-hashtable-helper-functions
Date: Wed, 27 Mar 2013 21:55:26 +0800 [thread overview]
Message-ID: <CAPjoZodem5CvXe1-0YF-+UdBqU+0Q4p6i6Sr8jd8cXcyanMfeg@mail.gmail.com> (raw)
In-Reply-To: <871ub16k73.fsf@tines.lan>
[-- Attachment #1: Type: text/plain, Size: 953 bytes --]
On Wed, Mar 27, 2013 at 9:33 PM, Mark H Weaver <mhw@netris.org> wrote:
> ludo@gnu.org (Ludovic Courtès) writes:
>
> > Nala Ginrut <nalaginrut@gmail.com> skribis:
> >
> >> +(define (hash-keys table)
> >> + "Return all the keys from hash table."
> >> + (hash-map->list (lambda (x y) x) table))
> >
> > That doesn’t seem sufficiently common to warrant a new procedure. WDYT?
>
> FWIW, I think it would be reasonable to add 'hash-keys'. Many users
> are accustomed to writing in a style that's made more convenient by
> 'hash-keys', and in cases where efficiency is not crucial, I think
> it's a fine style. Also, sometimes the values aren't needed.
>
> IMO, we can afford to add a few conveniences such as this.
>
>
Thanks for saying that.
And please consider 'hash-items' implemented with hash-count, it's common
as well.
And I'm not sure about hash-size myself, I won't insist on it.
Thanks!
> Mark
>
>
[-- Attachment #2: Type: text/html, Size: 2321 bytes --]
next prev parent reply other threads:[~2013-03-27 13:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 10:40 [PATCH] Add-native-hashtable-helper-functions Nala Ginrut
2013-03-26 12:54 ` Noah Lavine
2013-03-26 21:58 ` Ludovic Courtès
2013-03-27 0:47 ` Nala Ginrut
2013-03-27 5:10 ` Daniel Hartwig
2013-03-27 6:32 ` Nala Ginrut
2013-03-27 8:55 ` Daniel Hartwig
2013-03-27 10:25 ` Nala Ginrut
2013-03-27 10:03 ` Ludovic Courtès
2013-03-27 13:33 ` Mark H Weaver
2013-03-27 13:55 ` Nala Ginrut [this message]
2013-03-27 20:21 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPjoZodem5CvXe1-0YF-+UdBqU+0Q4p6i6Sr8jd8cXcyanMfeg@mail.gmail.com \
--to=nalaginrut@gmail.com \
--cc=guile-devel@gnu.org \
--cc=ludo@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).