unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Nala Ginrut <nalaginrut@gmail.com>
To: Maxime Devos <maximedevos@telenet.be>
Cc: mikael@djurfeldt.com, Adam Faiz <adam.faiz@disroot.org>,
	 guile-devel <guile-devel@gnu.org>,
	Ricardo Wurmus <rekado@elephly.net>, Tomas Volf <~@wolfsden.cz>
Subject: Re: [PATCH] test-suite: Add tests for `for-rdelim-in-port`-related functions.
Date: Fri, 20 Dec 2024 18:57:54 +0900	[thread overview]
Message-ID: <CAPjoZocgX4ks_w0L0CGHEWdjucEsiraLhv7TQ_X4NcE=jQ+98A@mail.gmail.com> (raw)
In-Reply-To: <20241220101533.qxFY2D00e2kJuzj01xFZgG@baptiste.telenet-ops.be>

[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]

> Also, you are assuming “\n” is a line delimiter. This is true under Unix
> according to the documentation. But it doesn’t say anything about non-Unix
> systems.
>

RnRs defined read-line to handle different newline properly. My original
idea is to stick to a pure line string reader iterator helper function. So
we can just use read-line to make things simpler. The more general
implementation has to consider this issue out of the standard API.
The proposed generalisation could introduce extra complexity and seems like
over engineering. But as I said, it's still beautiful way to go and I don't
against such an effort. Only if we can spend extra effort to make it work
properly.

Alright, I just elaborate my opinion before in case any misunderstanding of
my previous words. Let's face the problem.

I remember there's way to detect the current platform on the fly, so that
we can test for each supported OS.
How about Guile wrapped (uname), I used it in GNU Artanis to detect the
kernel version. But there's also brief OS info.

I don't think we need to handle Windows case, since nowadays there's WSL
and people like to run GNU things on WSL.

Best regards.

[-- Attachment #2: Type: text/html, Size: 1990 bytes --]

  reply	other threads:[~2024-12-20  9:57 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-16 15:21 [PATCH 1/2] rdelim: Add new procedure `for-rdelim-in-port` Adam Faiz
2024-12-16 15:24 ` [PATCH 2/2] doc: Add documentation for `for-rdelim-in-port` and, related procedures Adam Faiz
2024-12-17  4:31   ` [PATCH] test-suite: Add tests for `for-rdelim-in-port`-related functions Adam Faiz
2024-12-17  5:11     ` Nala Ginrut
2024-12-17  7:21       ` Mikael Djurfeldt
2024-12-17 16:43         ` Mikael Djurfeldt
2024-12-20  9:15           ` Maxime Devos
2024-12-20  9:57             ` Nala Ginrut [this message]
2024-12-20 11:51               ` Maxime Devos
2024-12-20 12:00                 ` Nala Ginrut
2024-12-20 12:53                   ` Maxime Devos
2024-12-20 13:00                     ` Nala Ginrut
2024-12-20 13:45                       ` Maxime Devos
2024-12-20 13:52                         ` Nala Ginrut
2024-12-20 14:18                           ` Maxime Devos
2024-12-20 14:30                             ` Nala Ginrut
2024-12-20 14:32                               ` Nala Ginrut
2024-12-20 14:47                               ` Maxime Devos
2024-12-20 14:56                                 ` Nala Ginrut
2024-12-20 15:07                                   ` Maxime Devos
2024-12-20 15:13                                     ` Nala Ginrut
2024-12-19 21:50     ` Mikael Djurfeldt
2024-12-20 15:15       ` [PATCH] test-suite: Add tests for `for-rdelim-in-port`-relatedfunctions Maxime Devos
2024-12-20 17:11         ` Mikael Djurfeldt
2024-12-20 17:31           ` Nala Ginrut
2024-12-20 18:40           ` Maxime Devos
2024-12-16 16:46 ` [PATCH 1/2] rdelim: Add new procedure `for-rdelim-in-port` Nala Ginrut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPjoZocgX4ks_w0L0CGHEWdjucEsiraLhv7TQ_X4NcE=jQ+98A@mail.gmail.com' \
    --to=nalaginrut@gmail.com \
    --cc=adam.faiz@disroot.org \
    --cc=guile-devel@gnu.org \
    --cc=maximedevos@telenet.be \
    --cc=mikael@djurfeldt.com \
    --cc=rekado@elephly.net \
    --cc=~@wolfsden.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).