From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Nala Ginrut Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] test-suite: Add tests for `for-rdelim-in-port`-related functions. Date: Fri, 20 Dec 2024 23:32:03 +0900 Message-ID: References: <43ad0b39-03cf-b648-3bc9-8c4a064519a8@disroot.org> <8e113f49-c1dc-313b-e65a-24a73c5b887a@disroot.org> <20241220101533.qxFY2D00e2kJuzj01xFZgG@baptiste.telenet-ops.be> <20241220125141.qzrg2D00G2kJuzj06zrg2X@albert.telenet-ops.be> <20241220135310.r0t92D0082kJuzj010t981@laurent.telenet-ops.be> <20241220144559.r1ly2D00i2kJuzj061lzzE@albert.telenet-ops.be> <20241220151837.r2Jc2D00o2kJuzj012JdDJ@laurent.telenet-ops.be> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000702a0d0629b4837d" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36694"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "mikael@djurfeldt.com" , Adam Faiz , guile-devel , Ricardo Wurmus , Tomas Volf <~@wolfsden.cz> To: Maxime Devos Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Fri Dec 20 15:32:41 2024 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tOe3S-0009MW-Mq for guile-devel@m.gmane-mx.org; Fri, 20 Dec 2024 15:32:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOe3I-0007bJ-AO; Fri, 20 Dec 2024 09:32:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOe3A-0007OL-7H for guile-devel@gnu.org; Fri, 20 Dec 2024 09:32:22 -0500 Original-Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOe38-0006tR-4A for guile-devel@gnu.org; Fri, 20 Dec 2024 09:32:20 -0500 Original-Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-7ea8de14848so1251458a12.2 for ; Fri, 20 Dec 2024 06:32:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734705136; x=1735309936; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OfTzl778x+lZ/lfloKBKtcuU6JKGxlUdwyVzfFbCASQ=; b=lBNmNMOcRHMMXMI+ZjKLWLhzajtKaX7jUVRyfQPKQ6htBGn6LQpXsOYJ8l9qo04YAk PTjyfWBnLrsy90ZgxBvp4nI/k8wc+73wWTaT+dzB5s5Vpt416n2km52QlEP6GFmUd+19 0pJha7kL32S2Y58kHX8p4zRcA+DMy8Y9UXF51CeN/N020fikLjq6ME/Dty0/ZndKzBoQ Ne4KzIpEk0F110Hh8REfjq9NYet4vwjdgItRzEik3V1LSrztaATmejxvFk/GImSuh/nk kxx+VvgVN7265CopLtjhvsHxACcNSWFUTAvlJ0zij6ml6qA+0tQ1oEJ9qB27Cygigp2X Ugfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734705136; x=1735309936; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OfTzl778x+lZ/lfloKBKtcuU6JKGxlUdwyVzfFbCASQ=; b=KnwdLTfzPxuasEpnzQe1rTMS5G7/IfWi22YgRxbBBqn+Q/o0my1lcXdo0706eUjM2e ml/aDaYGzXl01o5jvAQYUONrdvAsS8atbxu1rb4pYDRu/dWAmLZxvVVWr3YzLFuEwAnp ok14Nxy6xM5e8S6zOeJBigdD6k+R6+Xy/Nl2eKorvPUJy+GHHeWfv9+UHk1aoavqU5YE DWDUxcDiZvLczImTcRtxa0men0A2ZCoIZE6ONjDd6NkIf5kyXLVV2baIn51qJaW8HWyg WI2Mzb4mx6GBYm8UhaEXUCw0xDvrjimMiIk6/QHwSLKUytaa7KdBDZHVMDFagXNF0tzf JJ9w== X-Forwarded-Encrypted: i=1; AJvYcCVMSHr7jfAbqxl70rPVRxuI0kszPhcoSDx0rS5dbxsSv8nUv2+naH9xT+UMfu7K4OLHUA5Kl0voX8dvAA==@gnu.org X-Gm-Message-State: AOJu0YyuS22e0Gf+IUxNhV/E2jV3t2jU/cdnNO3WVvqkdxGieyyjtG7D Ataj8FizCcNB86YoP5uzbgU0N28AVsKjEHopkwk2yh3CoI1Ootb/gPjZD2ETLZFuFNbA1OfhKsw 16w16xrqWhf68F1tZ3/irH1XR0lU= X-Gm-Gg: ASbGncvHiB8z2IUHGTmI/yWmeit8ZQxKIuGHjNfXyX7AZNrafwghwLMgk/9c5s59YsZ 122oNPBMblzBlDst5gw7YBKKE8QgvLWcBqbc6rw== X-Google-Smtp-Source: AGHT+IELcER/icu1HivMK/ugKe7IJKPJAY2vz0bpZbMnC5qgOxoU+FOj9roMjbAeI2yrxatVjV2QAeh+XaAxDlhH4DI= X-Received: by 2002:a17:90b:538b:b0:2f2:a796:26b with SMTP id 98e67ed59e1d1-2f452dfaf91mr4620224a91.1.1734705136278; Fri, 20 Dec 2024 06:32:16 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::52c; envelope-from=nalaginrut@gmail.com; helo=mail-pg1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.devel:22850 Archived-At: --000000000000702a0d0629b4837d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable "I also care if the image in your mind is not what showed in your mind" should be "showed in my mind" Best regards. On Fri, Dec 20, 2024, 23:30 Nala Ginrut wrote: > As I said, I didn't against any of your opinions. But I have my freedom t= o > comment on what I think important. > > So I made my proposal accordingly to the specific issue as you pointed > out. This may not be accepted by you, but that's your freedom to share yo= ur > mind further. And I unnecessarily need to respond to it unless I think it= 's > worth. In case you thought people may misunderstand you, I also care if t= he > image in your mind is not what showed in your mind. I keep my comments > before anyone show the related code as you described. > > But let me emphasize it, this doesn't mean anyone is forced to reimplemen= t > the code. At least I accept the current implementation. Don't forget, the= se > patches included your efforts either, and I respect that part too, in the > name of the code. Personally, I would like to comment on the existing cod= e > rather than mind. > > This thread is not only you and me. Many others are reading it. You don't > need to persuade me. You just claim your mind directly, and wait for folk= s > agree it, or at least part of it. > Best regards. > > On Fri, Dec 20, 2024, 23:18 Maxime Devos wrote: > >> >Here are the "back to the track" reply for folks in this thread. >> >> > >> >> >So the situation is more clear now. The newline in various OS need to >> respectively tested. And my idea is to check OS via (uname) in test case= s. >> >> >Now that it's in tests, I think we don't have to talk much about the >> efficiency issue for this specific case. >> >> >> >> No. See what I wrote previously about the subject, and note that most of >> it is independent of whether it=E2=80=99s for testing or not. As you pre= viously >> said you intentionally did not read (parts of) the messages, I=E2=80=99m= not going >> to repeat it for you. >> >> >> >> In addition: why not simply _*read*_ the implementation of (ice-9 >> rdelim) to see what platform-detecting mechanism it uses (if any) and re= use >> that, instead of reinventing the wheel? Sounds like it would save effort >> and time, which you seem particularly interested in, and claimed >> effort/time is one of your own arguments against generalisation. >> >> >> >> Also, it doesn=E2=80=99t need to be tested, since read-line is not what= =E2=80=99s being >> added or modified here. (Tests for that may be good, but that=E2=80=99s = off-topic, >> which you are rather against, and is your most coherent argument against >> generalisation.) Rather, either the used newline in the test needs to be >> adjusted per-platform, or the documentation of read-line needs to be >> adjusted to that \n is always a newline. >> >> >> >> Also, it=E2=80=99s also not a proper =E2=80=9Cback to the track=E2=80=9D= reply, since it ignores >> the =E2=80=98generalisation=E2=80=99 component of the track. >> >> >> >> Regards, >> >> Maxime Devos >> > --000000000000702a0d0629b4837d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

"I also care if the image in your mind is not what show= ed in your mind"

should be "showed in my mind"

Best regards.

On Fri, Dec 20, 2024, 23:30 Nala Ginrut <nalaginrut@gmail.com> wrote:

As I said, I didn't against any of your op= inions. But I have my freedom to comment on what I think important.

So I made my proposal accordingly to the specific issue as y= ou pointed out. This may not be accepted by you, but that's your freedo= m to share your mind further. And I unnecessarily need to respond to it unl= ess I think it's worth. In case you thought people may misunderstand yo= u, I also care if the image in your mind is not what showed in your mind. I= keep my comments before anyone show the related code as you described.

But let me emphasize it, this doesn't mean anyone is for= ced to reimplement the code. At least I accept the current implementation. = Don't forget, these patches included your efforts either, and I respect= that part too, in the name of the code. Personally, I would like to commen= t on the existing code rather than mind.

This thread is not only you and me. Many others are reading = it. You don't need to persuade me. You just claim your mind directly, a= nd wait for folks agree it, or at least part of it.

Best regards.

On Fri, Dec 20, 2024= , 23:18 Maxime Devos <maximedevos@telenet.be> wrote:

>Here are the "back to the track" = reply for folks in this thread.

>=C2=A0

>So the situation is = more clear now. The newline in various OS need to respectively tested. And = my idea is to check OS via (uname) in test cases.

<= /div>

>Now that it's= in tests, I think we don't have to talk much about the efficiency issu= e for this specific case.

=C2=A0

No. See what I wrote previously about the sub= ject, and note that most of it is independent of whether it=E2=80=99s for t= esting or not. As you previously said you intentionally did not read (parts= of) the messages, I=E2=80=99m not going to repeat it for you.

=C2=A0

In addition: why no= t simply _read_ the implementation of (ice-9 rdelim) to see what pla= tform-detecting mechanism it uses (if any) and reuse that, instead of reinv= enting the wheel? Sounds like it would save effort and time, which you seem= particularly interested in, and claimed effort/time is one of your own arg= uments against generalisation.

=C2=A0

Also, it doesn=E2=80=99t need to be tested, since r= ead-line is not what=E2=80=99s being added or modified here. (Tests for tha= t may be good, but that=E2=80=99s off-topic, which you are rather against, = and is your most coherent argument against generalisation.) Rather, either = the used newline in the test needs to be adjusted per-platform, or the docu= mentation of read-line needs to be adjusted to that \n is always a newline.=

=C2=A0

Also, = it=E2=80=99s also not a proper =E2=80=9Cback to the track=E2=80=9D reply, s= ince it ignores the =E2=80=98generalisation=E2=80=99 component of the track= .

=C2=A0

Regar= ds,

Max= ime Devos

--000000000000702a0d0629b4837d--