From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew Whatson Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Improve reporting of exception locations Date: Thu, 22 Sep 2022 14:06:25 +0000 Message-ID: References: <20220920020044.19963-1-whatson@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30198"; mail-complaints-to="usenet@ciao.gmane.io" Cc: guile-devel@gnu.org To: Maxime Devos Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Thu Sep 22 17:46:35 2022 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1obOPL-0007iZ-Fi for guile-devel@m.gmane-mx.org; Thu, 22 Sep 2022 17:46:35 +0200 Original-Received: from localhost ([::1]:46982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1obOPK-0005Hr-FB for guile-devel@m.gmane-mx.org; Thu, 22 Sep 2022 11:46:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obMqd-0003TT-7B for guile-devel@gnu.org; Thu, 22 Sep 2022 10:06:39 -0400 Original-Received: from mail-yw1-x112a.google.com ([2607:f8b0:4864:20::112a]:44647) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1obMqb-00081L-H5 for guile-devel@gnu.org; Thu, 22 Sep 2022 10:06:38 -0400 Original-Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-345528ceb87so99543267b3.11 for ; Thu, 22 Sep 2022 07:06:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=aK/GvQOCJ9pdYQyZNLJ37GrxHUYMAUwCbW7W2tiBwo8=; b=l+6lMnQi8SUEMjqeNFkncHYC7gixUkMU2nSoyfg4TWAD3v7Z0PZzC6cFZQak2tanfM sIP6EptndStxDBLsKZHJEQ4STgCdUULF20C68fFLx23hVd2eX+JJs+RyREEO7468jYPL wGhIoexLA1pPEJ21+XUqTPMFIG3JeoCzUWTWTBUj1xbA/qM39aQ1QjkXkgF8EO/V6ggo 8p1tb2SZ780uJK7+A9rtkg5cPiKrzAxrLeWb07OV5SNEw59dEVOTuplxYb+YLAdbhrmR aKaSS1Ee/NqHoLQyun4SBNu7mYuvUDNXeDqXvQJCjPqItUj9jzL+vDHoSHaZe6cOMQ+7 ivmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=aK/GvQOCJ9pdYQyZNLJ37GrxHUYMAUwCbW7W2tiBwo8=; b=BKRQqJdjT/JJbmleF12+8pJouXWgamGCGwi9E6zji78/BZ0OaPNh6EEDa4I34QrETf 8jU9foSFW19VFOdbTKOiobEXAeavbqZHrO/DpCIF8f2fM2Rfu5j/bbLhS58fqkbDYBtY sepuA3Ca1DcmRMGqyLuk1g6Lh7usOcXwQ19v2DlkIgfyJUIrptRBVYjzrWwnYRTa0i8Y ajEuvRhSTQgOWLiWDxPvKE39b/yP0ubN1DR7ILCW2Jf7CeH86k3VjecV2VUCt8z9V874 n2bjJHpZC4UUASPz8aqMychX/FNnXsZO1G86a8KkvzNcBhvAE6NCXYy4ZSbu/Zqlss81 qWmw== X-Gm-Message-State: ACrzQf0bEgFBcus8kwvQt2QOT4SFF9Mg54Bd3S2B4iBXLI7SWbz00yXP LE6I9tb/K0uMZjWCkFAON8QiOw46Rlfntksuqec= X-Google-Smtp-Source: AMsMyM7QVCLBKhgftg/Ra978S1Q6PLNRc4ayN3rIUpD01UkcSSm4d3XeY2sE7rjeyMi/zwbvRbCObTqeYJVRU2fOhM0= X-Received: by 2002:a81:13d7:0:b0:324:7dcb:8d26 with SMTP id 206-20020a8113d7000000b003247dcb8d26mr3358847ywt.452.1663855596229; Thu, 22 Sep 2022 07:06:36 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::112a; envelope-from=whatson@gmail.com; helo=mail-yw1-x112a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:21366 Archived-At: Maxime Devos wrote: > > Do you have some test cases, to > > (1) avoid breaking things again with future changes > (2) and show that this patch is correct? > > There recent-ish was a bug report about exception handling (on IRC), it > would be a unfortunate if whatever the fix for that turned out to be, > causes the reporting to be wrong again -- a few test cases for this > patch could prevent that. Yes, very good point, I'll put together some test coverage next week. Thanks for the review!