From: Andrew Whatson <whatson@gmail.com>
To: Maxime Devos <maximedevos@telenet.be>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] Improve reporting of exception locations
Date: Thu, 22 Sep 2022 14:06:25 +0000 [thread overview]
Message-ID: <CAPE069f9BgLNAPCHS-xU2rv3JYBrueDEufTU0rOqu-Nnd4VuHQ@mail.gmail.com> (raw)
In-Reply-To: <b2c6c123-d9fb-39d9-7b79-0ebb6770e601@telenet.be>
Maxime Devos <maximedevos@telenet.be> wrote:
>
> Do you have some test cases, to
>
> (1) avoid breaking things again with future changes
> (2) and show that this patch is correct?
>
> There recent-ish was a bug report about exception handling (on IRC), it
> would be a unfortunate if whatever the fix for that turned out to be,
> causes the reporting to be wrong again -- a few test cases for this
> patch could prevent that.
Yes, very good point, I'll put together some test coverage next week.
Thanks for the review!
prev parent reply other threads:[~2022-09-22 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 2:00 [PATCH] Improve reporting of exception locations Andrew Whatson
2022-09-21 10:42 ` Maxime Devos
2022-09-21 10:54 ` Maxime Devos
2022-09-22 14:06 ` Andrew Whatson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPE069f9BgLNAPCHS-xU2rv3JYBrueDEufTU0rOqu-Nnd4VuHQ@mail.gmail.com \
--to=whatson@gmail.com \
--cc=guile-devel@gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).