From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew Whatson Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH v2] Add tests for warning locations. Date: Thu, 13 Oct 2022 13:18:48 +1000 Message-ID: References: <20220924134608.20312-1-whatson@gmail.com> <20220924223426.30825-1-whatson@gmail.com> <875ygovkqt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4910"; mail-complaints-to="usenet@ciao.gmane.io" Cc: guile-devel@gnu.org To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Thu Oct 13 05:19:17 2022 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oiokf-00018S-RG for guile-devel@m.gmane-mx.org; Thu, 13 Oct 2022 05:19:17 +0200 Original-Received: from localhost ([::1]:34468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oioke-0000Xq-5E for guile-devel@m.gmane-mx.org; Wed, 12 Oct 2022 23:19:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiokR-0000XR-Lv for guile-devel@gnu.org; Wed, 12 Oct 2022 23:19:03 -0400 Original-Received: from mail-yw1-x1132.google.com ([2607:f8b0:4864:20::1132]:40518) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oiokP-0001mW-Sk; Wed, 12 Oct 2022 23:19:03 -0400 Original-Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-35ad0584879so6319447b3.7; Wed, 12 Oct 2022 20:19:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xSLj+/h6zko5TZW7OabbETd1RUzkFu1VX+9iNY0Cens=; b=jEfeilec8ZC31Rs677acUVHxOH3Ym27LkNObhbRVRxmZURGuBkTjLnb7cQTEwxzPU6 bc8BOMzvAi30h+RapyUbs5eFJrSzym2mQv8JxapJPZOa4LUD5hnlUGk0B2rPbQwAPb3a MQ3mmJzloj3ddez/R+8bDuoU5OoGxl4ZhokhleecpOu1BPgn+jd/CsVL7qZL7LMHT3gn na7kCGAZI9D18WJfuyemtk44R08iQuYqVJHCjynGWmqfY9K4KY5GJfLs4yIb8OnoDtO+ AG4see3q0suBgBb5JZwIbLgL70EF0ANBSbycgJGuRqGu4wqN4+uEA54ICi1a/WaS7wyS 9V6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xSLj+/h6zko5TZW7OabbETd1RUzkFu1VX+9iNY0Cens=; b=DYH5P38yzrecCf1wZaWpVyipXZFRdzjBflJ8n9KTGOh9wXyG7N+xTlXwfspg5a331r YG3dPgDq8wXEK7nri5uOtHh2xPLPEZC0ipdl4tAcJlZDEnKNLFcP39ELVhiIDLp4cs81 XOsusWcqIogRmrYo+7/mJHaLuKKX+LWAlkswiKPVxungJk7BdqrPF1lV407Cmp1r/TQ8 I5lzF4QZ0F3tDCB98+2T8FsVvATHx7jYZpflMBdennz7/QKc/NxJYWO0DQbfeuo6RMGj G088EgMjCZq7m2HJDl6yBbZ1acx2xOWiZaKgoWBY3NktWzWgCOuCS949NjocdJz4KcQZ KUpA== X-Gm-Message-State: ACrzQf0HdHrspYAEWQq1weKgp2o5xO27PjSPF+RQIF6DCs+3YpHCflOe vD7ZVBdnz2bCnuLTaogT3TqF48DjhviaombhdUaZL+uO X-Google-Smtp-Source: AMsMyM6Pi77gfWKRyWWQb18q0A7NatMLZm/a8W0RUaeQ/X8zl/xxAu2EXzKOgNt129C/Gf/oL2vJ4gziceEFOoa/NnQ= X-Received: by 2002:a81:515:0:b0:360:a26c:dbbf with SMTP id 21-20020a810515000000b00360a26cdbbfmr20043269ywf.335.1665631139115; Wed, 12 Oct 2022 20:18:59 -0700 (PDT) In-Reply-To: <875ygovkqt.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::1132; envelope-from=whatson@gmail.com; helo=mail-yw1-x1132.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:21418 Archived-At: Ludovic Court=C3=A8s wrote: > > One minor nitpick and then we=E2=80=99re ready to go: > > > + (with-test-prefix "location" > > + (define (test-file filename) > > + (string-append > > + (dirname (current-filename)) "/" filename)) > > + > > + (pass-if "unused variable" > > + (let ((w (call-with-warnings > > + (lambda () > > + (compile-file (test-file "tree-il/unused-variable.s= cm") > > + #:opts %opts-w-unused > > + #:to 'cps))))) > > + (and (=3D (length w) 1) > > + (number? (string-contains (car w) "unused variable `y'")= ) > > + (number? (string-contains (car w) "tree-il/unused-variab= le.scm:2:2"))))) > > Can we avoid the separate files and instead do something like: > > (call-with-input-string " (foo)" > (lambda (port) > (set-port-filename! port "test-error-location.scm") > (read-and-compile port #:opts =E2=80=A6 #:to 'cps))) > > ? That cleans things up nicely! I've sent v3 of the patch incorporating this change. Thanks for the review! Cheers, Andrew