From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Han-Wen Nienhuys Newsgroups: gmane.lisp.guile.devel Subject: Re: Guile 1.8.9 release Date: Sun, 14 Feb 2021 11:35:27 +0100 Message-ID: References: <87zh18o4z7.fsf@gnuvola.org> <8735y3tvmw.fsf@gnuvola.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21737"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Guile Devel To: Thien-Thi Nguyen Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Sun Feb 14 11:36:05 2021 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBEl1-0005UO-4k for guile-devel@m.gmane-mx.org; Sun, 14 Feb 2021 11:36:03 +0100 Original-Received: from localhost ([::1]:37448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBEkz-0006vW-Ka for guile-devel@m.gmane-mx.org; Sun, 14 Feb 2021 05:36:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBEkl-0006v7-An for guile-devel@gnu.org; Sun, 14 Feb 2021 05:35:47 -0500 Original-Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:37519) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBEkj-00014f-09 for guile-devel@gnu.org; Sun, 14 Feb 2021 05:35:47 -0500 Original-Received: by mail-ed1-x535.google.com with SMTP id o3so2690001edv.4 for ; Sun, 14 Feb 2021 02:35:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xy9Eb9X5HennoKWh4Behlt0yFLkLyHpM18xCAPoSkBM=; b=Kz9Xt6fm9msxVnaaS9oLWdhV1t4HiBsFZDkIkdfjtMVt6/+UvSVLxOxof/S9dOPqjA 17s7TBQxPr4pSak9yZnrEsq7ckw6hqSVSH/NnSGXJereCg4ODtlie0tPizG7J2QcBQby Y/DA0tC4ZMLP1YXhbogjntKWtkg/NIoGz3UJLI6ngF65zzqED1D96FK2QZR6mnYwsTCm R443TtlGZ/btCi8a65OwTx5uDb3SyL1zW1UokOwDrIe66+iabbMOPPO6nDjCJBLwr76w d2LJK3V9CTIU9Th75yKem0D0sr8b+S1V7kEmsT56um+CITrnFlVzg5VXg7nLG+wH92Q5 e7Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xy9Eb9X5HennoKWh4Behlt0yFLkLyHpM18xCAPoSkBM=; b=oGhJ3SejwaA0oN7V57N3BIKeVpSvCJSDYaZdkD8/fnhryhXLfuv3LIXkN7dX36JvAD BbiBJYe0wzZpCqgUoDK73BbaoXL7ZxTuorj3t2lT5PeYipcPO29hwtYj7O3gp1iMxc5P k60EXBtTc+RkbWFFmzRrJizmjECGGOf6DzoRGHyNge8vYrsXivYv+QpT0m2MBGptz78y ruijqQxKCCxhlgrvF8dFH5E7WRq04Xl3WP1hZ589PLfC9m8exNoMfMxWzxbHLb7m4nQ7 vJ+9RVz7mT+ZnqHckDKZKf5H+V+NRGGgz5zoitn1ux38djLkE44IidR3u899nFJEnhgO 7CLQ== X-Gm-Message-State: AOAM533CnKeUAshgvbfxHXKCu7SF0jPkijmoN3wnzKZGFCKpRh2Lrsjt u0YC1IFTy3DBQKtjKZ1dhVjRfl3ItQX2JSrz4XaU1xt9c2s= X-Google-Smtp-Source: ABdhPJyeU7xFOuWTKPH+e5ykQllq6nSyYSGnQVZuk9gcuvm/k+FbYb2iCnMga/0UyxIT0dq7cRAWAAquwM2sgScBh4E= X-Received: by 2002:a05:6402:1641:: with SMTP id s1mr11336976edx.238.1613298938696; Sun, 14 Feb 2021 02:35:38 -0800 (PST) In-Reply-To: <8735y3tvmw.fsf@gnuvola.org> Received-SPF: pass client-ip=2a00:1450:4864:20::535; envelope-from=hanwenn@gmail.com; helo=mail-ed1-x535.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:20666 Archived-At: On Wed, Feb 10, 2021 at 11:18 PM Thien-Thi Nguyen wrote: > > > () Han-Wen Nienhuys > () Tue, 9 Feb 2021 09:59:07 +0100 > > > Thanks. It turns out my previous fix introduced ABI > > breakage, so I reworked it to not change function > > signatures or struct sizes. It's also split up in more > > parts, so it becomes easier to understand. Please see > > here: [...] > > Any news here? Can I do anything to get this fix in? > > IIUC, the second iteration achieves the same goals as the first > one (i.e., reducing unnecessary allocation by refining the heap > monitoring machinery). Is that correct? (What am i missing?) the first iteration broke ABI compatibility. The second patch doesn't > > I would be happy to commit the second patch, if you could refine > it to add the extensive explanation of the first. (You could > even mention the first approach, as an interesting but misguided > dead end.) That way, we have a full record. Maybe this wasn't clear, but the second patch is actually a sequence of patches, and in aggregate they have more detailed explanation of what is going on. The following are cosmetic changes. While they don't have to be merged, per se, the formatting fixes are the basis of the bugfix changes: 701f6e2cae88883dfc1e280711345fb5a75b0aae gc: cleanup DEBUGINFO printfs. ce503b481e7486a7fb5152d3075c2d475fd33e06 gc: fix formatting inconsistencies 925edffc2d4efd19333582ca588e0aebb1c7adf8 gc-segment: clarify comments on segment initialization these are the real bug fixes: 2511e1fa97558e1d0f0620489cdd7550e7d77195 gc: reinterpret scm_gc_cells_collected as garbage counter 594783b15b00133d73aed00bb7f3304a56725497 gc: use normal sweep for pre-mark sweep the following are minor follow-on cleanups: 923c41cb94462140fa07120632f5736680a0c76e gc: calculate min_yield statelessly e2d04fdd4d8a3d9cebd0d9289c5b8f9528e47d34 gc: simplify statistic keeping > I would be extremely happy to commit a test along w/ the change, > if we can figure that out. But it's not critical (we can do it > later). > > Re testing, i don't know how to go about setting up a test to > avoid regressions. (IIUC, this is a performance-related change > and not a functionality-related one.) Any ideas? I can add a test, but it requires adding several fields to the (gc-stats) output, which might surprise callers not expecting them. Also, as it is a performance test, it is hard to construct a test that always works. -- Han-Wen Nienhuys - hanwenn@gmail.com - http://www.xs4all.nl/~hanwen