From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Freja Nordsiek Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Fix bug #24816: open-string-output-port extraction thunk does not truncate string port as expected by R6RS in Guile 2.1.7 Date: Thu, 2 Mar 2017 21:42:08 +0100 Message-ID: References: <87fuiwdgqx.fsf@pobox.com> <87poi0azuh.fsf@pobox.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1488487343 17521 195.159.176.226 (2 Mar 2017 20:42:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 2 Mar 2017 20:42:23 +0000 (UTC) Cc: guile-devel@gnu.org To: Andy Wingo Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Thu Mar 02 21:42:17 2017 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjXY9-0003E8-Vk for guile-devel@m.gmane.org; Thu, 02 Mar 2017 21:42:10 +0100 Original-Received: from localhost ([::1]:54488 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjXYG-0007BT-5l for guile-devel@m.gmane.org; Thu, 02 Mar 2017 15:42:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjXYB-0007BC-98 for guile-devel@gnu.org; Thu, 02 Mar 2017 15:42:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjXYA-00022L-H0 for guile-devel@gnu.org; Thu, 02 Mar 2017 15:42:11 -0500 Original-Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:36331) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cjXYA-00022F-BO for guile-devel@gnu.org; Thu, 02 Mar 2017 15:42:10 -0500 Original-Received: by mail-wm0-x22c.google.com with SMTP id n11so975797wma.1 for ; Thu, 02 Mar 2017 12:42:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Vt4u8m+mxZaH6PgwMJsrcXiwS2bGCu4RPjAEoGEwbFE=; b=GV6N7+IPzzQQ2c0kiKz7lu9WxKDZtcdWH+L5EkIjPsioXbBDAjyaH75m6OADUIBSiO J83rCkUJGikz0e2Hi8RIyqq9q+bZYD5brxLLpJKa7uQUopxPtcVC8Uux99TJ2/RWWD/Q 4/Jt5DuRqQZ360KVq887U2hDzrXRl31DGQbG7i+w0x+Lzn3BAhlTQNmLgPxMtbhDlMaa Yx0NJZuZxrBPoBU+nzhf1uARmc7ktDAaVhQ4RzwCjDheop4C6nf2S3962Com65s211l1 6hAhMeLQS6c9tw936VrGPIYdw8DFDgqQkioXTU8rUslcM0evbiuLMT8SzwI4zR5xpsdr AbfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Vt4u8m+mxZaH6PgwMJsrcXiwS2bGCu4RPjAEoGEwbFE=; b=Yzjvpe3cw/5eeP4pxr/OtxQFr0soFE238wFT0TJgiCdUCioxuSO6dX/n5tOzCDtptG /O5/GQKFAK9Jm7lbwC0F2CQiMk13TfvkJM+yGpO08MIVuxlFuzX/5nn7TP6CTRF3VGhK 7CQQ/SiDyJQrrZYqh0aK+9GrgU2ruZ7MZIRDfrwQcb9hQCHU7YTA0XEVjL+5X7I70mjZ k7mS6Wq933bARP0UoIbY5lwQiEy12Dwlf70gmrg5bQBCZOuOkJCx/cRB8FGt9F5k3LC/ HKKyk+F6IQEZ4RKGLqMGi8D/x+tIu2kHtBz8+V1SArxaSZURjCfDYykmamkePWqxo6FZ 9ERg== X-Gm-Message-State: AMke39k5e3h1Bw4t5nBQ2xqcXw6b/mG/5gKNBwVLFFYhH+pxJuVtHYBe51AVru99DOzV3/cH+0ZTZGcyvt0+mA== X-Received: by 10.28.208.7 with SMTP id h7mr128398wmg.79.1488487329222; Thu, 02 Mar 2017 12:42:09 -0800 (PST) Original-Received: by 10.28.234.73 with HTTP; Thu, 2 Mar 2017 12:42:08 -0800 (PST) In-Reply-To: <87poi0azuh.fsf@pobox.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::22c X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.org gmane.lisp.guile.devel:18980 Archived-At: The patch for the stable-2.0 branch turns out to trivially be doing a cherry-pick of your patch for the master branch. No further modifications are needed. And the tests work. git cherry-pick -x e13cd5c77c030f22e3f5c27f15bb979bfda7d2ba Freja On Thu, Mar 2, 2017 at 8:43 AM, Andy Wingo wrote: > On Wed 01 Mar 2017 22:15, Freja Nordsiek writes: > >> By the way, I tested the method you used manually on 2.0.x today and >> it fixed the discrepancy with R6RS there too. Might consider patching >> that branch too. Hopefully no one has been depending on the >> non-truncating behavior. > > Would you mind sending a patch? I would be happy to apply it :) > > Cheers, > > Andy