From: Freja Nordsiek <fnordsie@gmail.com>
To: Andy Wingo <wingo@pobox.com>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] Fix bug #24816: open-string-output-port extraction thunk does not truncate string port as expected by R6RS in Guile 2.1.7
Date: Thu, 2 Mar 2017 21:42:08 +0100 [thread overview]
Message-ID: <CAOqf98rOHTx9GC_+-oUPjUdP5h=T2JF+B2+8R80Ji6yEfqX7SA@mail.gmail.com> (raw)
In-Reply-To: <87poi0azuh.fsf@pobox.com>
The patch for the stable-2.0 branch turns out to trivially be doing a
cherry-pick of your patch for the master branch. No further
modifications are needed. And the tests work.
git cherry-pick -x e13cd5c77c030f22e3f5c27f15bb979bfda7d2ba
Freja
On Thu, Mar 2, 2017 at 8:43 AM, Andy Wingo <wingo@pobox.com> wrote:
> On Wed 01 Mar 2017 22:15, Freja Nordsiek <fnordsie@gmail.com> writes:
>
>> By the way, I tested the method you used manually on 2.0.x today and
>> it fixed the discrepancy with R6RS there too. Might consider patching
>> that branch too. Hopefully no one has been depending on the
>> non-truncating behavior.
>
> Would you mind sending a patch? I would be happy to apply it :)
>
> Cheers,
>
> Andy
next prev parent reply other threads:[~2017-03-02 20:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 19:36 [PATCH] Fix bug #24816: open-string-output-port extraction thunk does not truncate string port as expected by R6RS in Guile 2.1.7 Freja Nordsiek
2017-03-01 17:55 ` Andy Wingo
2017-03-01 21:15 ` Freja Nordsiek
2017-03-02 7:43 ` Andy Wingo
2017-03-02 20:42 ` Freja Nordsiek [this message]
2017-03-06 19:49 ` Andy Wingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOqf98rOHTx9GC_+-oUPjUdP5h=T2JF+B2+8R80Ji6yEfqX7SA@mail.gmail.com' \
--to=fnordsie@gmail.com \
--cc=guile-devel@gnu.org \
--cc=wingo@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).