From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Freja Nordsiek Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Fix bug #24816: open-string-output-port extraction thunk does not truncate string port as expected by R6RS in Guile 2.1.7 Date: Wed, 1 Mar 2017 22:15:52 +0100 Message-ID: References: <87fuiwdgqx.fsf@pobox.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a114416c04ef3b50549b1d10b X-Trace: blaine.gmane.org 1488402971 15802 195.159.176.226 (1 Mar 2017 21:16:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 1 Mar 2017 21:16:11 +0000 (UTC) Cc: guile-devel@gnu.org To: Andy Wingo Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Mar 01 22:16:04 2017 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjBbP-0002wh-Lm for guile-devel@m.gmane.org; Wed, 01 Mar 2017 22:16:03 +0100 Original-Received: from localhost ([::1]:48826 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjBbS-0000Nw-Ih for guile-devel@m.gmane.org; Wed, 01 Mar 2017 16:16:06 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjBbK-0000Nr-5p for guile-devel@gnu.org; Wed, 01 Mar 2017 16:15:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjBbI-00063D-C4 for guile-devel@gnu.org; Wed, 01 Mar 2017 16:15:58 -0500 Original-Received: from mail-wm0-x233.google.com ([2a00:1450:400c:c09::233]:36369) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cjBbI-00060C-3Z for guile-devel@gnu.org; Wed, 01 Mar 2017 16:15:56 -0500 Original-Received: by mail-wm0-x233.google.com with SMTP id n11so9580581wma.1 for ; Wed, 01 Mar 2017 13:15:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=H3hjaxcr8GOq4PIubp49PjEin1TrmojD8xRx/V7DYEY=; b=F+u7FAnTFMazLbBH33pD4Bu1Ab26VLvJt9TVf1B9MvcUcUVWi5QJShZG3SVk4SV7wq s30c4tUipu9V1SXTfgYeEfF7PjoUu84PKi3MJ/s7bAA39pM1hWvwF6JfY4hIJFu9lu/A V9nDO9otdOTndvNfRAi4BH46rCFgxWUzRmY6UW/v/97FNmLGeXsBBecid0zf1Fdphzgk X9Wg5HJ/YSZNwu1dfrVshJHvEe0SeNMkRxP+t/oIVr98RJHr7hyOk4qoFEQyqxSPXH5I swC2yw1QuAyHcsP/f4gANqn8Kfd/dt9BeJHIXhCkYmb9Hx6SFsoEjyp7fvV3Z6xI/l/l 3NoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=H3hjaxcr8GOq4PIubp49PjEin1TrmojD8xRx/V7DYEY=; b=RDk+BmGLYy88Rq64oBDFQ6AEKuJ3tixO55CURcJ4ykl7N9laAe46Np9Up+ObUor4mj pc4kOA5mXz4U6vmkKyWtdj6x+IWYAOQUAbfc8Pn8EGGY0PlejxRHvnTJe+3xob3omlT/ V9I5BR2ZFiNp+PYVgm9IY/j244PslC2V7AM/+FNH3Az3oza/2ALu17siSraMlAdBAOrP +WBgZvC7lK0QpdOuKOnK44BtNLy+u4T1r2ZmtxV5kg16fMB8t6Yc12OkIfDd2InbICoX nFAqBp/klsEa2cEonoJorqcbWGCxf358KhvQLQixH6+JVCAtAtuesLH8agb5fP8V07mm /Law== X-Gm-Message-State: AMke39lXzZWHP9bDZPC7iYdhKOr4O9WP3HKgNtIqGsEpkHPkF0m6MqRpZ1xluw6fngn+6iYiQn+s/IbzNu9HpQ== X-Received: by 10.28.91.196 with SMTP id p187mr4879209wmb.132.1488402953202; Wed, 01 Mar 2017 13:15:53 -0800 (PST) Original-Received: by 10.28.153.133 with HTTP; Wed, 1 Mar 2017 13:15:52 -0800 (PST) Original-Received: by 10.28.153.133 with HTTP; Wed, 1 Mar 2017 13:15:52 -0800 (PST) In-Reply-To: <87fuiwdgqx.fsf@pobox.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::233 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.org gmane.lisp.guile.devel:18973 Archived-At: --001a114416c04ef3b50549b1d10b Content-Type: text/plain; charset=UTF-8 Thanks for the tip on how to properly reply to a bugreport. I will make sure I get that right next time. By the way, I tested the method you used manually on 2.0.x today and it fixed the discrepancy with R6RS there too. Might consider patching that branch too. Hopefully no one has been depending on the non-truncating behavior. Freja On Mar 1, 2017 6:55 PM, "Andy Wingo" wrote: > Heya Freja, > > On Tue 21 Feb 2017 20:36, Freja Nordsiek writes: > > > Patch for bug #24816: https://debbugs.gnu.org/cgi/ > bugreport.cgi?bug=24816 > > Apologies for not noticing this patch; I was working from the debbugs > interface and didn't see this. In the future you can update a bug with > a patch by CC'ing NNNNN@debbugs.gnu.org, e.g. 24816@debbugs.gnu.org. > > Your patch is pretty much exactly what I did, too :) One thing I did > was require the port position to be within the bounds of the truncated > size; was a tough call but truncate-file on a file doesn't adjust the > position, so there's that. > > Thank you again for the patch and sorry for missing it. Looking forward > to future patches :-) > > Andy > --001a114416c04ef3b50549b1d10b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks for the tip on how to properly reply to a bugrepor= t. I will make sure I get that right next time.

=
By the way, I tested the method you used manually on 2.0.= x today and it fixed the discrepancy with R6RS there too. Might consider pa= tching that branch too. Hopefully no one has been depending on the non-trun= cating behavior.


Freja

On Mar 1, 2017 6:55 PM, "Andy Wingo" <wingo@pobox.com> wrote:
Heya Freja,

On Tue 21 Feb 2017 20:36, Freja Nordsiek <fnordsie@gmail.com> writes:

> Patch for bug #24816: https://debbugs.gnu.= org/cgi/bugreport.cgi?bug=3D24816

Apologies for not noticing this patch; I was working from the debbugs
interface and didn't see this.=C2=A0 In the future you can update a bug= with
a patch by CC'ing NNNNN@debbug= s.gnu.org, e.g. 24816@debbugs.= gnu.org.

Your patch is pretty much exactly what I did, too :)=C2=A0 One thing I did<= br> was require the port position to be within the bounds of the truncated
size; was a tough call but truncate-file on a file doesn't adjust the position, so there's that.

Thank you again for the patch and sorry for missing it.=C2=A0 Looking forwa= rd
to future patches :-)

Andy
--001a114416c04ef3b50549b1d10b--