From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Freja Nordsiek Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Add to the 2.1.x branch GUILE_SITE_CCACHE_DIR and GUILE_EXTENSION_DIR Autoconf macros along with needed siteccachdir entry in pkgconfig file Date: Tue, 14 Mar 2017 20:41:45 +0100 Message-ID: References: <878to9s5s9.fsf@pobox.com> <87h92v7vw3.fsf@pobox.com> <87y3w76edw.fsf@pobox.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a11441e4aa91e2d054ab604f5 X-Trace: blaine.gmane.org 1489520515 7692 195.159.176.226 (14 Mar 2017 19:41:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 14 Mar 2017 19:41:55 +0000 (UTC) Cc: guile-devel@gnu.org To: Andy Wingo Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Tue Mar 14 20:41:51 2017 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnsKM-0001ei-Pw for guile-devel@m.gmane.org; Tue, 14 Mar 2017 20:41:51 +0100 Original-Received: from localhost ([::1]:33208 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnsKS-0001et-RI for guile-devel@m.gmane.org; Tue, 14 Mar 2017 15:41:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnsKL-0001dH-NR for guile-devel@gnu.org; Tue, 14 Mar 2017 15:41:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnsKK-0003rN-82 for guile-devel@gnu.org; Tue, 14 Mar 2017 15:41:49 -0400 Original-Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]:34070) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cnsKJ-0003pZ-Rh for guile-devel@gnu.org; Tue, 14 Mar 2017 15:41:48 -0400 Original-Received: by mail-wm0-x229.google.com with SMTP id 196so15507141wmm.1 for ; Tue, 14 Mar 2017 12:41:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=E5POfZ3/AsBU9hOtgYgmJwejN7F+42Ln/oXxEsft8hI=; b=jvff2N03lRcQQtnCAK9LjWTEI4a/uuOwWllga7dWHHw36dSY8t2d4TMpaeO0fTOodx tdaWzep2mI7b4oVJwLnJLbpu8Jz97W5v3pTGquMA6T2XXEcY4M/5pu+6HkeGBVr42Nh0 RU4rynU3UQu2bDB1h7IkwVkZB22QxpKEYH2qCL6YQKR7ZPygTL8iNWybsaKjrXKVYpqn yB2fKB31x00VSV16sACJpyNywABnWFiXXMyB7Z6nq00XbYmJkpcP/mnOVnIGZQ9vhgOU n27LqXvExOwBoj6u0Qpw7yy97MEDIBBhRJakz4pN/aLMnt5aHZCIliCWndr8o3dve5T/ iFWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=E5POfZ3/AsBU9hOtgYgmJwejN7F+42Ln/oXxEsft8hI=; b=b8Qglke6E+YJJARpyG0uJPbQHCijlblGaTwuahp6kHdzKdXacJFb9p5e0f1LGXVTA0 TWuF37zD7x9lXA0v7JmDtzlHFYqAYkhgjrSGBXi3oItxJFlxIuU5WFdU+zQp4JbUdw+3 Igt6hWlJ/Lbc/2+3izB8xk557cj2n1T8GxztR1QrkR3o2Skbskts/CpmbNwEuQfRXiIc dYCIkZdjDDC2uoCh5r9hYl8JNIXKNONvW00/StoC2iIEcWOWw4QydZVl5gVONlbx4E2r ZKVmAZam0J5pR6a+uCk8+BOhgonarHjiIOFB/J1yViYv7N8Kolwh4xoLmnRLyNgu6cBf KWJg== X-Gm-Message-State: AFeK/H0KJF2m5suKOcliJSKoYpsjI/w/x9LN4KJWRONUNFQmj74mMCw9OcSY4ndtZ7nEZ5iThKVDXkHDorCmjA== X-Received: by 10.28.139.134 with SMTP id n128mr15719250wmd.132.1489520506231; Tue, 14 Mar 2017 12:41:46 -0700 (PDT) Original-Received: by 10.28.234.73 with HTTP; Tue, 14 Mar 2017 12:41:45 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::229 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.org gmane.lisp.guile.devel:19053 Archived-At: --001a11441e4aa91e2d054ab604f5 Content-Type: text/plain; charset=UTF-8 I missed adding an entry for meta/guile-2.2.pc.in in the commit log. Fixed now. Freja Nordsiek On Tue, Mar 14, 2017 at 5:10 PM, Freja Nordsiek wrote: > OK, got it on the commit log. Took some work to figure out how to do a > multiline one, but got it now. > > Fixed the long lines. > > Removed the --print-errors option. Didn't catch that. > > Thank you for all the help. Yeah, this sort of nitpicking makes it a > lot easier for people in the future to work on things. > > > Freja Nordsiek > > > > > On Tue, Mar 14, 2017 at 4:56 PM, Andy Wingo wrote: >> Heya :) >> >> On Tue 14 Mar 2017 16:31, Freja Nordsiek writes: >> >>> From 41498549ac22ea50e497887b3a1e002985bb6f8f Mon Sep 17 00:00:00 2001 >>> From: Freja Nordsiek >>> Date: Tue, 14 Mar 2017 16:28:45 +0100 >>> Subject: [PATCH] GUILE_SITE_DIR: Find site directories for compiled files. >>> >> >> Here in the commit log you need entries for the files you change and the >> functions you change in them. See >> 036cc149e6e52722f16ef25f4203e82abae9bc79 for an example. I know it's a >> bit of a drag but it's how it is. (In Magit, if you use that, you can >> press C in a diff to make a template in the log.) >> >>> -# GUILE_SITE_DIR -- find path to Guile "site" directory >>> +# GUILE_SITE_DIR -- find path to Guile site directories >>> # >>> # Usage: GUILE_SITE_DIR >>> # >>> -# This looks for Guile's "site" directory, usually something like >>> -# PREFIX/share/guile/site, and sets var @var{GUILE_SITE} to the path. >>> -# Note that the var name is different from the macro name. >>> +# This looks for Guile's "site" directories. The variable @var{GUILE_SITE} will >>> +# be set to Guile's "site" directory for Scheme source files (usually something like >>> +# PREFIX/share/guile/site). @var{GUILE_SITE_CCACHE} will be set to the directory >>> +# for compiled Scheme files also known as @code{.go} files >>> +# (usually something like PREFIX/lib/guile/@var{GUILE_EFFECTIVE_VERSION}/site-ccache). >>> +# @var{GUILE_EXTENSION} will be set to the directory for compiled C extensions >>> +# (usually something like # PREFIX/lib/guile/@var{GUILE_EFFECTIVE_VERSION}/extensions). >>> +# The latter two are set to blank if the particular version of Guile does not support >>> +# them. Note that this macro will run the macros @code{GUILE_PKG} and @code{GUILE_PROGS} >>> +# if they have not already been run. >> >> Please limit lines to < 80 characters. If you use emacs, you can fix >> with M-q, provided your fill-column is set appropriately. >> >>> AC_SUBST(GUILE_SITE) >>> + AC_MSG_CHECKING([for Guile site-ccache directory using pkgconfig]) >>> + GUILE_SITE_CCACHE=`$PKG_CONFIG --print-errors --variable=siteccachedir guile-$GUILE_EFFECTIVE_VERSION` >> >> Is --print-errors the right thing here? I guess this causes some text >> to spew on the console for 2.0. Probably not the right thing if we're >> going to fall back. >> >> Otherwise good. Apologies for the nit-picking; I'm doing it now just so >> that things are fluid in the future :) >> >> Andy --001a11441e4aa91e2d054ab604f5 Content-Type: text/x-patch; charset=US-ASCII; name="0001-GUILE_SITE_DIR-updated-to-find-compiled-site-directo.patch" Content-Disposition: attachment; filename="0001-GUILE_SITE_DIR-updated-to-find-compiled-site-directo.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j09y1ahs1 RnJvbSAwOWUyZDEwNzVhN2M0OGU0MDhhNWRkYWY4YjdiZjQ1NzhiNDU1YWE5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGcmVqYSBOb3Jkc2llayA8Zm5vcmRzaWVAZ21haWwuY29tPgpE YXRlOiBUdWUsIDE0IE1hciAyMDE3IDE3OjA1OjA5ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gR1VJ TEVfU0lURV9ESVI6IHVwZGF0ZWQgdG8gZmluZCBjb21waWxlZCBzaXRlIGRpcmVjdG9yaWVzCgoq IG1ldGEvZ3VpbGUubTQ6IEdVSUxFX1NJVEVfRElSIHVwZGF0ZWQgdG8gZmluZCBjb21waWxlZCBz aXRlIGRpcmVjdG9yaWVzCiogbWV0YS9ndWlsZS0yLjIucGMuaW46IGFkZGVkIGVudHJ5IGZvciBz aXRlLWNjYWNoZSBkaXJlY3RvcnkKLS0tCiBtZXRhL2d1aWxlLTIuMi5wYy5pbiB8ICAxICsKIG1l dGEvZ3VpbGUubTQgICAgICAgIHwgNDQgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKystLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9tZXRhL2d1aWxlLTIuMi5wYy5pbiBiL21ldGEvZ3VpbGUtMi4y LnBjLmluCmluZGV4IGM4ZjQ4NWIuLmM2ZDEyYjUgMTAwNjQ0Ci0tLSBhL21ldGEvZ3VpbGUtMi4y LnBjLmluCisrKyBiL21ldGEvZ3VpbGUtMi4yLnBjLmluCkBAIC0xMCw2ICsxMCw3IEBAIHBrZ2lu Y2x1ZGVkaXI9QGluY2x1ZGVkaXJAL2d1aWxlCiAKIHNpdGVkaXI9QHNpdGVkaXJACiBleHRlbnNp b25kaXI9QGxpYmRpckAvZ3VpbGUvQEdVSUxFX0VGRkVDVElWRV9WRVJTSU9OQC9leHRlbnNpb25z CitzaXRlY2NhY2hlZGlyPUBsaWJkaXJAL2d1aWxlL0BHVUlMRV9FRkZFQ1RJVkVfVkVSU0lPTkAv c2l0ZS1jY2FjaGUKIGxpYmd1aWxlaW50ZXJmYWNlPUBMSUJHVUlMRV9JTlRFUkZBQ0VACiAKICMg QWN0dWFsIG5hbWUgb2YgdGhlICdndWlsZScgYW5kICdndWlsZCcgcHJvZ3JhbXMuICBUaGlzIGlz CmRpZmYgLS1naXQgYS9tZXRhL2d1aWxlLm00IGIvbWV0YS9ndWlsZS5tNAppbmRleCBiMGVmOWJl Li4yM2MyYzYzIDEwMDY0NAotLS0gYS9tZXRhL2d1aWxlLm00CisrKyBiL21ldGEvZ3VpbGUubTQK QEAgLTI1LDcgKzI1LDcgQEAKICMjIEdVSUxFX1BLRyAtLSBmaW5kIEd1aWxlIGRldmVsb3BtZW50 IGZpbGVzCiAjIyBHVUlMRV9QUk9HUyAtLSBzZXQgcGF0aHMgdG8gR3VpbGUgaW50ZXJwcmV0ZXIs IGNvbmZpZyBhbmQgdG9vbCBwcm9ncmFtcwogIyMgR1VJTEVfRkxBR1MgLS0gc2V0IGZsYWdzIGZv ciBjb21waWxpbmcgYW5kIGxpbmtpbmcgd2l0aCBHdWlsZQotIyMgR1VJTEVfU0lURV9ESVIgLS0g ZmluZCBwYXRoIHRvIEd1aWxlICJzaXRlIiBkaXJlY3RvcnkKKyMjIEdVSUxFX1NJVEVfRElSIC0t IGZpbmQgcGF0aCB0byBHdWlsZSAic2l0ZSIgZGlyZWN0b3JpZXMKICMjIEdVSUxFX0NIRUNLIC0t IGV2YWx1YXRlIEd1aWxlIFNjaGVtZSBjb2RlIGFuZCBjYXB0dXJlIHRoZSByZXR1cm4gdmFsdWUK ICMjIEdVSUxFX01PRFVMRV9DSEVDSyAtLSBjaGVjayBmZWF0dXJlIG9mIGEgR3VpbGUgU2NoZW1l IG1vZHVsZQogIyMgR1VJTEVfTU9EVUxFX0FWQUlMQUJMRSAtLSBjaGVjayBhdmFpbGFiaWxpdHkg b2YgYSBHdWlsZSBTY2hlbWUgbW9kdWxlCkBAIC0xNTQsMTggKzE1NCwyOCBAQCBBQ19ERUZVTihb R1VJTEVfRkxBR1NdLAogICBBQ19TVUJTVChbR1VJTEVfTFRMSUJTXSkKICBdKQogCi0jIEdVSUxF X1NJVEVfRElSIC0tIGZpbmQgcGF0aCB0byBHdWlsZSAic2l0ZSIgZGlyZWN0b3J5CisjIEdVSUxF X1NJVEVfRElSIC0tIGZpbmQgcGF0aCB0byBHdWlsZSBzaXRlIGRpcmVjdG9yaWVzCiAjCiAjIFVz YWdlOiBHVUlMRV9TSVRFX0RJUgogIwotIyBUaGlzIGxvb2tzIGZvciBHdWlsZSdzICJzaXRlIiBk aXJlY3RvcnksIHVzdWFsbHkgc29tZXRoaW5nIGxpa2UKLSMgUFJFRklYL3NoYXJlL2d1aWxlL3Np dGUsIGFuZCBzZXRzIHZhciBAdmFye0dVSUxFX1NJVEV9IHRvIHRoZSBwYXRoLgotIyBOb3RlIHRo YXQgdGhlIHZhciBuYW1lIGlzIGRpZmZlcmVudCBmcm9tIHRoZSBtYWNybyBuYW1lLgorIyBUaGlz IGxvb2tzIGZvciBHdWlsZSdzICJzaXRlIiBkaXJlY3Rvcmllcy4gIFRoZSB2YXJpYWJsZSBAdmFy e0dVSUxFX1NJVEV9IHdpbGwKKyMgYmUgc2V0IHRvIEd1aWxlJ3MgInNpdGUiIGRpcmVjdG9yeSBm b3IgU2NoZW1lIHNvdXJjZSBmaWxlcyAodXN1YWxseSBzb21ldGhpbmcKKyMgbGlrZSBQUkVGSVgv c2hhcmUvZ3VpbGUvc2l0ZSkuICBAdmFye0dVSUxFX1NJVEVfQ0NBQ0hFfSB3aWxsIGJlIHNldCB0 byB0aGUKKyMgZGlyZWN0b3J5IGZvciBjb21waWxlZCBTY2hlbWUgZmlsZXMgYWxzbyBrbm93biBh cyBAY29kZXsuZ299IGZpbGVzCisjICh1c3VhbGx5IHNvbWV0aGluZyBsaWtlCisjIFBSRUZJWC9s aWIvZ3VpbGUvQHZhcntHVUlMRV9FRkZFQ1RJVkVfVkVSU0lPTn0vc2l0ZS1jY2FjaGUpLgorIyBA dmFye0dVSUxFX0VYVEVOU0lPTn0gd2lsbCBiZSBzZXQgdG8gdGhlIGRpcmVjdG9yeSBmb3IgY29t cGlsZWQgQyBleHRlbnNpb25zCisjICh1c3VhbGx5IHNvbWV0aGluZyBsaWtlCisjIFBSRUZJWC9s aWIvZ3VpbGUvQHZhcntHVUlMRV9FRkZFQ1RJVkVfVkVSU0lPTn0vZXh0ZW5zaW9ucykuIFRoZSBs YXR0ZXIgdHdvCisjIGFyZSBzZXQgdG8gYmxhbmsgaWYgdGhlIHBhcnRpY3VsYXIgdmVyc2lvbiBv ZiBHdWlsZSBkb2VzIG5vdCBzdXBwb3J0CisjIHRoZW0uICBOb3RlIHRoYXQgdGhpcyBtYWNybyB3 aWxsIHJ1biB0aGUgbWFjcm9zIEBjb2Rle0dVSUxFX1BLR30gYW5kCisjIEBjb2Rle0dVSUxFX1BS T0dTfSBpZiB0aGV5IGhhdmUgbm90IGFscmVhZHkgYmVlbiBydW4uCiAjCi0jIFRoZSB2YXJpYWJs ZSBpcyBtYXJrZWQgZm9yIHN1YnN0aXR1dGlvbiwgYXMgYnkgQGNvZGV7QUNfU1VCU1R9LgorIyBU aGUgdmFyaWFibGVzIGFyZSBtYXJrZWQgZm9yIHN1YnN0aXR1dGlvbiwgYXMgYnkgQGNvZGV7QUNf U1VCU1R9LgogIwogQUNfREVGVU4oW0dVSUxFX1NJVEVfRElSXSwKICBbQUNfUkVRVUlSRShbR1VJ TEVfUEtHXSkKKyAgQUNfUkVRVUlSRShbR1VJTEVfUFJPR1NdKQogICBBQ19NU0dfQ0hFQ0tJTkco Zm9yIEd1aWxlIHNpdGUgZGlyZWN0b3J5KQogICBHVUlMRV9TSVRFPWAkUEtHX0NPTkZJRyAtLXBy aW50LWVycm9ycyAtLXZhcmlhYmxlPXNpdGVkaXIgZ3VpbGUtJEdVSUxFX0VGRkVDVElWRV9WRVJT SU9OYAogICBBQ19NU0dfUkVTVUxUKCRHVUlMRV9TSVRFKQpAQCAtMTczLDYgKzE4MywyOCBAQCBB Q19ERUZVTihbR1VJTEVfU0lURV9ESVJdLAogICAgICBBQ19NU0dfRkFJTFVSRShzaXRlZGlyIG5v dCBmb3VuZCkKICAgZmkKICAgQUNfU1VCU1QoR1VJTEVfU0lURSkKKyAgQUNfTVNHX0NIRUNLSU5H KFtmb3IgR3VpbGUgc2l0ZS1jY2FjaGUgZGlyZWN0b3J5IHVzaW5nIHBrZ2NvbmZpZ10pCisgIEdV SUxFX1NJVEVfQ0NBQ0hFPWAkUEtHX0NPTkZJRyAtLXZhcmlhYmxlPXNpdGVjY2FjaGVkaXIgZ3Vp bGUtJEdVSUxFX0VGRkVDVElWRV9WRVJTSU9OYAorICBpZiB0ZXN0ICIkR1VJTEVfU0lURV9DQ0FD SEUiID0gIiI7IHRoZW4KKyAgICBBQ19NU0dfUkVTVUxUKG5vKQorICAgIEFDX01TR19DSEVDS0lO RyhbZm9yIEd1aWxlIHNpdGUtY2NhY2hlIGRpcmVjdG9yeSB1c2luZyBpbnRlcnByZXRlcl0pCisg ICAgR1VJTEVfU0lURV9DQ0FDSEU9YCRHVUlMRSAtYyAiKGRpc3BsYXkgKGlmIChkZWZpbmVkPyAn JXNpdGUtY2NhY2hlLWRpcikgKCVzaXRlLWNjYWNoZS1kaXIpIFwiXCIpKSJgCisgICAgaWYgdGVz dCAkPyAhPSAiMCIgLW8gIiRHVUlMRV9TSVRFX0NDQUNIRSIgPSAiIjsgdGhlbgorICAgICAgQUNf TVNHX1JFU1VMVChubykKKyAgICAgIEdVSUxFX1NJVEVfQ0NBQ0hFPSIiCisgICAgICBBQ19NU0df V0FSTihbc2l0ZWNjYWNoZWRpciBub3QgZm91bmRdKQorICAgIGZpCisgIGZpCisgIEFDX01TR19S RVNVTFQoJEdVSUxFX1NJVEVfQ0NBQ0hFKQorICBBQ19TVUJTVChbR1VJTEVfU0lURV9DQ0FDSEVd KQorICBBQ19NU0dfQ0hFQ0tJTkcoZm9yIEd1aWxlIGV4dGVuc2lvbnMgZGlyZWN0b3J5KQorICBH VUlMRV9FWFRFTlNJT049YCRQS0dfQ09ORklHIC0tcHJpbnQtZXJyb3JzIC0tdmFyaWFibGU9ZXh0 ZW5zaW9uZGlyIGd1aWxlLSRHVUlMRV9FRkZFQ1RJVkVfVkVSU0lPTmAKKyAgQUNfTVNHX1JFU1VM VCgkR1VJTEVfRVhURU5TSU9OKQorICBpZiB0ZXN0ICIkR1VJTEVfRVhURU5TSU9OIiA9ICIiOyB0 aGVuCisgICAgR1VJTEVfRVhURU5TSU9OPSIiCisgICAgQUNfTVNHX1dBUk4oZXh0ZW5zaW9uZGly IG5vdCBmb3VuZCkKKyAgZmkKKyAgQUNfU1VCU1QoR1VJTEVfRVhURU5TSU9OKQogIF0pCiAKICMg R1VJTEVfUFJPR1MgLS0gc2V0IHBhdGhzIHRvIEd1aWxlIGludGVycHJldGVyLCBjb25maWcgYW5k IHRvb2wgcHJvZ3JhbXMKLS0gCjIuOS4zCgo= --001a11441e4aa91e2d054ab604f5--