From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Freja Nordsiek Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Add to the 2.1.x branch GUILE_SITE_CCACHE_DIR and GUILE_EXTENSION_DIR Autoconf macros along with needed siteccachdir entry in pkgconfig file Date: Wed, 15 Mar 2017 08:49:39 +0100 Message-ID: References: <878to9s5s9.fsf@pobox.com> <87h92v7vw3.fsf@pobox.com> <87y3w76edw.fsf@pobox.com> <87tw6v56eq.fsf@pobox.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a114a444edd01da054ac02f8c X-Trace: blaine.gmane.org 1489564193 10706 195.159.176.226 (15 Mar 2017 07:49:53 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 15 Mar 2017 07:49:53 +0000 (UTC) Cc: guile-devel@gnu.org To: Andy Wingo Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Mar 15 08:49:48 2017 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1co3gj-0001Yk-4y for guile-devel@m.gmane.org; Wed, 15 Mar 2017 08:49:41 +0100 Original-Received: from localhost ([::1]:35110 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1co3gp-0004Df-Al for guile-devel@m.gmane.org; Wed, 15 Mar 2017 03:49:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1co3gl-0004DZ-Dd for guile-devel@gnu.org; Wed, 15 Mar 2017 03:49:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1co3gk-0001SI-Bk for guile-devel@gnu.org; Wed, 15 Mar 2017 03:49:43 -0400 Original-Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:35803) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1co3gk-0001Rj-37 for guile-devel@gnu.org; Wed, 15 Mar 2017 03:49:42 -0400 Original-Received: by mail-wm0-x244.google.com with SMTP id z63so3249121wmg.2 for ; Wed, 15 Mar 2017 00:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MKscKVGF22/kxtRBbes1MnmX5eMrbxiVc3NixlIQf8o=; b=BpAOibh6TDFIofMPj7ujf1kDI5HpH14eaB0mBxMI+BJ33wChxss49mC7V7KnOfoHZn fCRUbSEYDxUXwqbm2tZme5vj3mxGaIld8FRPd0yvV7/RnG3R48qjjq+EJp/pC00ZhO5Y qG5GmCDFK5AfR4eQKuRkC+5QgIgYNsnl9u2H4gISo6hMIm50yEf9XEcUrsWNSNwbaJ5u Ji5AGs8TWEgjqEILRx756jVsKe6qpWLtTzCqxioFlvjGEL8p/pwQvLRoyuOjMKzXS0Dc RaM1NG30xHirtLoH9kxdKXVSoVB6C4ewtDorblhTBYA8Lu5IEtGUTmluBl2Jv+fELOu9 J7pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MKscKVGF22/kxtRBbes1MnmX5eMrbxiVc3NixlIQf8o=; b=T/21EaKd1AA/v+RzOOacso1bMBXRxKgDZEDu21tpdHd+XeF+E2GFeB0P/mv4/lGA5S Q4neiok9ECjQbKZ7Rr2FVmjJ+kq3caQNDjIvDDdQz47KhX0ByScRHmCsf6cERPFrbJ34 5UIsQw0B33UjZT2rOm/LncjG6ZxUN02UCtPg1CfX3hL3UTnEgsGY3qOqNwcsr7cxrrAr B2sI7GxsFc4MDUZ+KZu2YkJHhYfMp/QNBdU+AlQNFaUc4hP/9cJVLC2QOzXfVnN7wpx6 OEecA8oSfX5ckHs26WOVl6rgzdgk0rVlhyGZg0CZ91lhfaJaM/h34vmHHgBw5J7Ar4K4 p+Ww== X-Gm-Message-State: AFeK/H0j27l4NVjvpftl4Bhed70DG/ip4Lgasv6AsR4ZPsQ5t8e+HDsraFoZ+tdLET9L2mV5V/JGVz0tere6NA== X-Received: by 10.28.65.65 with SMTP id o62mr2923146wma.14.1489564180740; Wed, 15 Mar 2017 00:49:40 -0700 (PDT) Original-Received: by 10.28.234.73 with HTTP; Wed, 15 Mar 2017 00:49:39 -0700 (PDT) Original-Received: by 10.28.234.73 with HTTP; Wed, 15 Mar 2017 00:49:39 -0700 (PDT) In-Reply-To: <87tw6v56eq.fsf@pobox.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::244 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.org gmane.lisp.guile.devel:19057 Archived-At: --001a114a444edd01da054ac02f8c Content-Type: text/plain; charset=UTF-8 Those changes look fine. More clear now. Freja Nordsiek On Mar 15, 2017 8:46 AM, "Andy Wingo" wrote: > On Tue 14 Mar 2017 20:41, Freja Nordsiek writes: > > > I missed adding an entry for meta/guile-2.2.pc.in in the commit log. > Fixed now. > > Applied, thanks! > > Note that I made a small change to the commit log: > > > Subject: [PATCH] GUILE_SITE_DIR: updated to find compiled site > directories > > > > * meta/guile.m4: GUILE_SITE_DIR updated to find compiled site directories > > * meta/guile-2.2.pc.in: added entry for site-ccache directory > > GUILE_SITE_DIR: Update to find compiled site directories > > * meta/guile.m4 (GUILE_SITE_DIR): Update to find compiled site > directories. > * meta/guile-2.2.pc.in: Add entry for site-ccache directory. > > Here we usually avoid going over 72 columns (because these logs are > often indented, e.g. via "git log") and the general tone is a bit more > declarative, in the present tense, and with full stops. > > Andy > --001a114a444edd01da054ac02f8c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Those changes look fine. More clear now.


= Freja Nordsiek

On Mar 15, 2017 8:46 AM, "Andy Wingo" <wingo@pobox.com> wrote:
On Tue 14 Mar 2017 20:41, Freja Nor= dsiek <fnordsie@gmail.com> = writes:

> I missed adding an entry for meta/guile-2.2.pc.in in the commit log. = Fixed now.

Applied, thanks!

Note that I made a small change to the commit log:

> Subject: [PATCH] GUILE_SITE_DIR: updated to find compiled site directo= ries
>
> * meta/guile.m4: GUILE_SITE_DIR updated to find compiled site director= ies
> * meta/guile-2.2.pc.in: added entry for site-ccache directory

GUILE_SITE_DIR: Update to find compiled site directories

* meta/guile.m4 (GUILE_SITE_DIR): Update to find compiled site
=C2=A0 directories.
* meta/guile-2.2.pc.in: Add entry for site-ccache directory.

Here we usually avoid going over 72 columns (because these logs are
often indented, e.g. via "git log") and the general tone is a bit= more
declarative, in the present tense, and with full stops.

Andy
--001a114a444edd01da054ac02f8c--