From: Freja Nordsiek <fnordsie@gmail.com>
To: Andy Wingo <wingo@pobox.com>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] Add to the 2.1.x branch GUILE_SITE_CCACHE_DIR and GUILE_EXTENSION_DIR Autoconf macros along with needed siteccachdir entry in pkgconfig file
Date: Wed, 15 Mar 2017 08:49:39 +0100 [thread overview]
Message-ID: <CAOqf98oAZjSJiowxwdyFqD3bXC4O-Nj316m=8V8iSuM97ukifQ@mail.gmail.com> (raw)
In-Reply-To: <87tw6v56eq.fsf@pobox.com>
[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]
Those changes look fine. More clear now.
Freja Nordsiek
On Mar 15, 2017 8:46 AM, "Andy Wingo" <wingo@pobox.com> wrote:
> On Tue 14 Mar 2017 20:41, Freja Nordsiek <fnordsie@gmail.com> writes:
>
> > I missed adding an entry for meta/guile-2.2.pc.in in the commit log.
> Fixed now.
>
> Applied, thanks!
>
> Note that I made a small change to the commit log:
>
> > Subject: [PATCH] GUILE_SITE_DIR: updated to find compiled site
> directories
> >
> > * meta/guile.m4: GUILE_SITE_DIR updated to find compiled site directories
> > * meta/guile-2.2.pc.in: added entry for site-ccache directory
>
> GUILE_SITE_DIR: Update to find compiled site directories
>
> * meta/guile.m4 (GUILE_SITE_DIR): Update to find compiled site
> directories.
> * meta/guile-2.2.pc.in: Add entry for site-ccache directory.
>
> Here we usually avoid going over 72 columns (because these logs are
> often indented, e.g. via "git log") and the general tone is a bit more
> declarative, in the present tense, and with full stops.
>
> Andy
>
[-- Attachment #2: Type: text/html, Size: 1738 bytes --]
prev parent reply other threads:[~2017-03-15 7:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-12 9:38 [PATCH] Add to the 2.1.x branch GUILE_SITE_CCACHE_DIR and GUILE_EXTENSION_DIR Autoconf macros along with needed siteccachdir entry in pkgconfig file Freja Nordsiek
2017-03-13 12:46 ` Andy Wingo
2017-03-14 14:08 ` Freja Nordsiek
2017-03-14 14:53 ` Andy Wingo
2017-03-14 15:31 ` Freja Nordsiek
2017-03-14 15:56 ` Andy Wingo
2017-03-14 16:10 ` Freja Nordsiek
2017-03-14 19:41 ` Freja Nordsiek
2017-03-15 7:46 ` Andy Wingo
2017-03-15 7:49 ` Freja Nordsiek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOqf98oAZjSJiowxwdyFqD3bXC4O-Nj316m=8V8iSuM97ukifQ@mail.gmail.com' \
--to=fnordsie@gmail.com \
--cc=guile-devel@gnu.org \
--cc=wingo@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).