* [PATCH] Fix tree-il code generation for ECMAscript `new' expression.
@ 2016-09-13 12:42 Julian Graham
2016-09-20 4:32 ` Wilfred Hughes
2016-10-25 21:41 ` Ludovic Courtès
0 siblings, 2 replies; 6+ messages in thread
From: Julian Graham @ 2016-09-13 12:42 UTC (permalink / raw)
To: guile-devel
[-- Attachment #1: Type: text/plain, Size: 248 bytes --]
Hi Guilers,
Noticed that ECMAscript "new" syntax seemed to be broken. Here's a
patch that fixes it. I'd like to make some incremental improvements in
Guile's ECMAscript support, so if this one's welcome, expect others to
follow!
Regards,
Julian
[-- Attachment #2: 0001-Fix-tree-il-code-generation-for-ECMAscript-new-expre.patch --]
[-- Type: text/x-patch, Size: 2789 bytes --]
From 16ef2df6cc206f829c3aff96b1b315ed6fb50c05 Mon Sep 17 00:00:00 2001
From: Julian Graham <joolean@undecidable.net>
Date: Tue, 13 Sep 2016 08:39:43 -0400
Subject: [PATCH] Fix tree-il code generation for ECMAscript `new' expression.
The compiler was producing `((toplevel foo))' instead of `(toplevel foo)'.
Changed to use `call' form with target type and spliced constructor
arguments.
* module/language/ecmascript/compile-tree-il.scm (comp): Replace `@impl'
shorthand with `call' + `@implv' for better control over resulting
tree-il.
* test-suite/tests/ecmascript.test (compiler): Add test for "new Object();"
---
module/language/ecmascript/compile-tree-il.scm | 8 ++++----
test-suite/tests/ecmascript.test | 8 +++++++-
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/module/language/ecmascript/compile-tree-il.scm b/module/language/ecmascript/compile-tree-il.scm
index a9ac3e0..d61f712 100644
--- a/module/language/ecmascript/compile-tree-il.scm
+++ b/module/language/ecmascript/compile-tree-il.scm
@@ -1,6 +1,6 @@
;;; ECMAScript for Guile
-;; Copyright (C) 2009, 2011 Free Software Foundation, Inc.
+;; Copyright (C) 2009, 2011, 2016 Free Software Foundation, Inc.
;;;; This library is free software; you can redistribute it and/or
;;;; modify it under the terms of the GNU Lesser General Public
@@ -437,9 +437,9 @@
((^= ,what ,val)
(comp `(= ,what (^ ,what ,val)) e))
((new ,what ,args)
- (@impl new
- (map (lambda (x) (comp x e))
- (cons what args))))
+ `(call ,(@implv new)
+ ,(comp what e)
+ ,@(map (lambda (x) (comp x e)) args)))
((delete (pref ,obj ,prop))
(@impl pdel
(comp obj e)
diff --git a/test-suite/tests/ecmascript.test b/test-suite/tests/ecmascript.test
index 96b1d66..9f2731e 100644
--- a/test-suite/tests/ecmascript.test
+++ b/test-suite/tests/ecmascript.test
@@ -1,6 +1,6 @@
;;;; ecmascript.test --- ECMAScript. -*- mode: scheme; coding: utf-8; -*-
;;;;
-;;;; Copyright (C) 2010, 2011, 2013 Free Software Foundation, Inc.
+;;;; Copyright (C) 2010, 2011, 2013, 2016 Free Software Foundation, Inc.
;;;;
;;;; This library is free software; you can redistribute it and/or
;;;; modify it under the terms of the GNU Lesser General Public
@@ -83,6 +83,12 @@
(ecompile "\"hello\";" "hello")
(ecompile "var test = { bar: 1 };")
+ (pass-if "new Object;"
+ (not (not
+ (compile (call-with-input-string "new Object;" read-ecmascript)
+ #:from 'ecmascript
+ #:to 'tree-il)))) ; Can't reference `Object' as value here
+
;; FIXME: Broken!
;; (ecompile "[1,2,3,4].map(function(x) { return x * x; });"
;; '(1 4 9 16))
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Fix tree-il code generation for ECMAscript `new' expression.
2016-09-13 12:42 [PATCH] Fix tree-il code generation for ECMAscript `new' expression Julian Graham
@ 2016-09-20 4:32 ` Wilfred Hughes
2016-09-20 14:26 ` Julian Graham
2016-10-25 21:41 ` Ludovic Courtès
1 sibling, 1 reply; 6+ messages in thread
From: Wilfred Hughes @ 2016-09-20 4:32 UTC (permalink / raw)
To: Julian Graham; +Cc: guile-devel
Looks good to me (even tests)! Have you assigned copyright papers for Guile?
On 13 September 2016 at 08:42, Julian Graham <joolean@gmail.com> wrote:
> Hi Guilers,
>
> Noticed that ECMAscript "new" syntax seemed to be broken. Here's a
> patch that fixes it. I'd like to make some incremental improvements in
> Guile's ECMAscript support, so if this one's welcome, expect others to
> follow!
>
>
> Regards,
> Julian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix tree-il code generation for ECMAscript `new' expression.
2016-09-20 4:32 ` Wilfred Hughes
@ 2016-09-20 14:26 ` Julian Graham
2016-09-21 1:55 ` Wilfred Hughes
0 siblings, 1 reply; 6+ messages in thread
From: Julian Graham @ 2016-09-20 14:26 UTC (permalink / raw)
To: Wilfred Hughes; +Cc: guile-devel
Hi Wilfred,
Yep! The FSF should have my assignment on file.
On Tue, Sep 20, 2016 at 12:32 AM, Wilfred Hughes <me@wilfred.me.uk> wrote:
> Looks good to me (even tests)! Have you assigned copyright papers for Guile?
>
> On 13 September 2016 at 08:42, Julian Graham <joolean@gmail.com> wrote:
>> Hi Guilers,
>>
>> Noticed that ECMAscript "new" syntax seemed to be broken. Here's a
>> patch that fixes it. I'd like to make some incremental improvements in
>> Guile's ECMAscript support, so if this one's welcome, expect others to
>> follow!
>>
>>
>> Regards,
>> Julian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix tree-il code generation for ECMAscript `new' expression.
2016-09-20 14:26 ` Julian Graham
@ 2016-09-21 1:55 ` Wilfred Hughes
2016-09-25 2:38 ` Julian Graham
0 siblings, 1 reply; 6+ messages in thread
From: Wilfred Hughes @ 2016-09-21 1:55 UTC (permalink / raw)
To: Julian Graham; +Cc: guile-devel
Excellent :)
I'm afraid I can't help you further, but it's great to see the
ecmascript frontend get some attention. The lack of ASI is the bug
that I notice the most, but there's definitely low hanging fruit.
Wilfred
On 20 September 2016 at 10:26, Julian Graham <joolean@gmail.com> wrote:
> Hi Wilfred,
>
> Yep! The FSF should have my assignment on file.
>
>
>
> On Tue, Sep 20, 2016 at 12:32 AM, Wilfred Hughes <me@wilfred.me.uk> wrote:
>> Looks good to me (even tests)! Have you assigned copyright papers for Guile?
>>
>> On 13 September 2016 at 08:42, Julian Graham <joolean@gmail.com> wrote:
>>> Hi Guilers,
>>>
>>> Noticed that ECMAscript "new" syntax seemed to be broken. Here's a
>>> patch that fixes it. I'd like to make some incremental improvements in
>>> Guile's ECMAscript support, so if this one's welcome, expect others to
>>> follow!
>>>
>>>
>>> Regards,
>>> Julian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix tree-il code generation for ECMAscript `new' expression.
2016-09-21 1:55 ` Wilfred Hughes
@ 2016-09-25 2:38 ` Julian Graham
0 siblings, 0 replies; 6+ messages in thread
From: Julian Graham @ 2016-09-25 2:38 UTC (permalink / raw)
To: Wilfred Hughes; +Cc: guile-devel
So, uh... can one of the maintainers apply my patch? (Andy / Ludo / Mark?)
On Tue, Sep 20, 2016 at 9:55 PM, Wilfred Hughes <me@wilfred.me.uk> wrote:
> Excellent :)
>
> I'm afraid I can't help you further, but it's great to see the
> ecmascript frontend get some attention. The lack of ASI is the bug
> that I notice the most, but there's definitely low hanging fruit.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix tree-il code generation for ECMAscript `new' expression.
2016-09-13 12:42 [PATCH] Fix tree-il code generation for ECMAscript `new' expression Julian Graham
2016-09-20 4:32 ` Wilfred Hughes
@ 2016-10-25 21:41 ` Ludovic Courtès
1 sibling, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2016-10-25 21:41 UTC (permalink / raw)
To: guile-devel
Julian Graham <joolean@gmail.com> skribis:
> From 16ef2df6cc206f829c3aff96b1b315ed6fb50c05 Mon Sep 17 00:00:00 2001
> From: Julian Graham <joolean@undecidable.net>
> Date: Tue, 13 Sep 2016 08:39:43 -0400
> Subject: [PATCH] Fix tree-il code generation for ECMAscript `new' expression.
>
> The compiler was producing `((toplevel foo))' instead of `(toplevel foo)'.
> Changed to use `call' form with target type and spliced constructor
> arguments.
>
> * module/language/ecmascript/compile-tree-il.scm (comp): Replace `@impl'
> shorthand with `call' + `@implv' for better control over resulting
> tree-il.
> * test-suite/tests/ecmascript.test (compiler): Add test for "new Object();"
Finally pushed to master, thanks! :-)
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-25 21:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-13 12:42 [PATCH] Fix tree-il code generation for ECMAscript `new' expression Julian Graham
2016-09-20 4:32 ` Wilfred Hughes
2016-09-20 14:26 ` Julian Graham
2016-09-21 1:55 ` Wilfred Hughes
2016-09-25 2:38 ` Julian Graham
2016-10-25 21:41 ` Ludovic Courtès
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).