From: Daniel Hartwig <mandyke@gmail.com>
To: Mark H Weaver <mhw@netris.org>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] In string-split, add support for character sets and predicates.
Date: Wed, 10 Oct 2012 11:28:54 +0800 [thread overview]
Message-ID: <CAN3veRdrDuo+QXT7LMrb26mPg8EY5J+1BMfj4fgbdOxKQ2UWvA@mail.gmail.com> (raw)
In-Reply-To: <87ehl7knym.fsf@tines.lan>
On 10 October 2012 11:25, Mark H Weaver <mhw@netris.org> wrote:
> Daniel Hartwig <mandyke@gmail.com> writes:
>
>> On 10 October 2012 10:14, Mark H Weaver <mhw@netris.org> wrote:
>>> Your latest patch looks good, but I just remembered one more thing:
>>> doc/ref/api-data.texi needs to be updated.
>>
>> I had assumed that was updated automatically from the doc strings,
>> which are in the right format.
>
> No, only doc/ref/standard-library.texi is automatically generated.
>
> I vaguely recall hearing somewhere that this autogeneration of docs was
> considered a failed experiment, but we'd have to ask Andy or Ludovic
> about that.
Ah, ok.
One final thing before I resubmit. I just notice that most of this
file has uses hard tabs, though there are places with soft. Is it
preferable to change the patch to also use hard tabs?
next prev parent reply other threads:[~2012-10-10 3:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 11:23 [PATCH] In string-split, add support for character sets and predicates Daniel Hartwig
2012-10-08 15:40 ` Mark H Weaver
2012-10-09 3:34 ` Daniel Hartwig
2012-10-09 17:48 ` Mark H Weaver
2012-10-10 1:37 ` Daniel Hartwig
2012-10-10 2:14 ` Mark H Weaver
2012-10-10 3:15 ` Daniel Hartwig
2012-10-10 3:25 ` Mark H Weaver
2012-10-10 3:28 ` Daniel Hartwig [this message]
2012-10-10 7:59 ` Mark H Weaver
2012-10-10 20:44 ` Ludovic Courtès
2012-10-12 6:38 ` Daniel Hartwig
2012-10-12 12:23 ` Mark H Weaver
2012-10-10 20:42 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN3veRdrDuo+QXT7LMrb26mPg8EY5J+1BMfj4fgbdOxKQ2UWvA@mail.gmail.com \
--to=mandyke@gmail.com \
--cc=guile-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).