From: Daniel Hartwig <mandyke@gmail.com>
To: Ian Price <ianprice90@googlemail.com>
Cc: guile-devel <guile-devel@gnu.org>
Subject: Re: [PATCH] read-response-body should return received data when any break happens
Date: Fri, 16 Mar 2012 02:48:11 +0800 [thread overview]
Message-ID: <CAN3veRcJLeye3KTVGakqLmvuF9fs02ZOTSQY11DpjhC+0uC9gw@mail.gmail.com> (raw)
In-Reply-To: <877gylu2wf.fsf@Kagami.home>
On 16 March 2012 02:37, Ian Price <ianprice90@googlemail.com> wrote:
> Daniel Hartwig <mandyke@gmail.com> writes:
>> For example, reusing the same bytevector and looping over
>> read-response-body! saving the results to disk each time. This limits
>> the memory use to the size of the bytevector *and* removes the copy
>> operation from your implementation (bonus!).
> If you wanted to do it that way, it'd be better to pass in the port
> directly and cut out the middle man.
>
Indeed. The procedure shown is similar to one from one of my own
projects which features the write-to-disk internally.
I guess it pays to keep in mind that it is trivial to rearrange
procedures such as this to suit any particular situation. The OP
appeared--to me--to be very over worked for the task.
Perhaps such error-tolerance/streaming capabilities can be tied in at
a level closer to get-bytevector-n...
Regards
next prev parent reply other threads:[~2012-03-15 18:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-11 15:35 [PATCH] read-response-body should return received data when any break happens Nala Ginrut
2012-03-15 16:09 ` Daniel Hartwig
2012-03-15 18:37 ` Ian Price
2012-03-15 18:48 ` Daniel Hartwig [this message]
2012-03-16 2:23 ` Nala Ginrut
2012-03-16 3:24 ` Daniel Hartwig
2012-03-16 3:31 ` Nala Ginrut
2012-03-15 18:31 ` Ian Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN3veRcJLeye3KTVGakqLmvuF9fs02ZOTSQY11DpjhC+0uC9gw@mail.gmail.com \
--to=mandyke@gmail.com \
--cc=guile-devel@gnu.org \
--cc=ianprice90@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).