From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Christopher Lam Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Add string-replace-substring to (ice-9 string-fun) Date: Sun, 5 Jan 2020 13:51:29 +0000 Message-ID: References: <27656CBA-297B-4EE3-93D6-FD56BFBDDC44@sarc.name> <87imlqyw5x.fsf@pobox.com> <87k166ump3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000009d01a4059b64d871" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="200204"; mail-complaints-to="usenet@blaine.gmane.org" Cc: guile-devel Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sun Jan 05 14:52:18 2020 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1io6KG-000prM-3K for guile-devel@m.gmane.org; Sun, 05 Jan 2020 14:52:16 +0100 Original-Received: from localhost ([::1]:42424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1io6KE-0001KA-Bm for guile-devel@m.gmane.org; Sun, 05 Jan 2020 08:52:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36293) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1io6K0-0001K0-GP for guile-devel@gnu.org; Sun, 05 Jan 2020 08:52:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1io6Jz-0001Vp-0X for guile-devel@gnu.org; Sun, 05 Jan 2020 08:52:00 -0500 Original-Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]:39259) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1io6Jy-0001V7-QR for guile-devel@gnu.org; Sun, 05 Jan 2020 08:51:58 -0500 Original-Received: by mail-ed1-x544.google.com with SMTP id t17so45346395eds.6 for ; Sun, 05 Jan 2020 05:51:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:cc; bh=cmPT5+uBYlnUkKlXw2HUv3YsdRUZT8/kCoJdvusXu2E=; b=uT8hvOf4byluvWqN8TqHqGUqP03qnI5Xaz1SvWdBia0ER65gpiq4Lj/3csh60PLpIf chrIBsbO4B5bpucuxL2OI6nriOp0afjLGUeQYlCD5UJfRZizAezkYLqtEFinKgjmTjWq XU2IQFk0xxjknoRrCgi4YCM6iFDE2mIFDA4HePsDqvEw4UGdipKY2OUlDpZFApPsVIKS 8DkwlzkBMydWWZQNKOt4m1CfXdYyQlwG62iXsEVshZOYj4eWEZfqd5oMa012TJZ3WWgl b9vv+AwOTkFfF7QxFQP8FcvKXwjSTMP0FWvBW3Dd/uvCvTN66RfxYtm/VTE4Ohd90FCH aWdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:cc; bh=cmPT5+uBYlnUkKlXw2HUv3YsdRUZT8/kCoJdvusXu2E=; b=YFTTmtbuKoKTmYwjAtNvtDlHpEivjYpcBwK6tL7OTKPXwm8SKY4n6cJZGzMiJDlYx2 hFdneavlIm1jAq6dxnFBjZ6EKOq8RvmkI3kCP2Iu+5EeFfSrE6l43dvpY5HqZ2zaYrAn uuXRKwaI32H2xBrSlHVwiVlT0PxfYOt4bGCfuJjOQFLMuNnYCbk4QiGo4qb3f5H161gw gViYb9cano69ZxMVk4F2plsrwAN8jYUJnLEkQpf3Y1yEyghBhSicy5BQwH0uRvD7gpXk A0GlJLcGBQpviwtXvDl2wlkOuiEtjfF/BnmSTMT21RvCCS0qCr5tolGInOhhSzNEDXRy jCPQ== X-Gm-Message-State: APjAAAU0IOjNjS0LK6AbeY0WvhXqcLCv8V7s4ZXOXcQJXhP5X5Txj0Pz liPd2W9nqJM82/P7Yuv0mXbXTaHT1Tsxajo20e5ndl2EEC0= X-Google-Smtp-Source: APXvYqxZwa05g0NMcPknHyh+GOz7CAumppQO4A61Awbjt4T7/wsV+TX4eUXTI+18iPnQvuFT/jDNTrOwFgNQS7Da1U4= X-Received: by 2002:a17:906:cb8d:: with SMTP id mf13mr100794814ejb.147.1578232316754; Sun, 05 Jan 2020 05:51:56 -0800 (PST) In-Reply-To: <87k166ump3.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::544 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.org gmane.lisp.guile.devel:20222 Archived-At: --0000000000009d01a4059b64d871 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable This function has an interesting history. Someone or something in #guile had clued me there was a magic string-replace-substring somewhere in guile-user archives. With some luck I found it, and had bookmarked it, and kept it at the back of my mind for a good number of months. Meanwhile I was steadily learning guile, and cleaning up GnuCash. Noting GnuCash still supports use of guile-2.0, I was finally able to use Mark's implementation to fix a bad one[1]. After discussing this change with GnuCash's lead developer, we realised that upgrading the embedded guile in GnuCash in Windows to 2.2 would solve a whole lot of i18n issues, which it did. Hence in a roundabout way, we are thankful for the original post and the discussion[2] around it. [1] https://github.com/Gnucash/gnucash/commit/7d15e6e4 [2] https://lists.gnu.org/archive/html/guile-devel/2014-03/msg00058.html On Sun, 5 Jan 2020 at 12:12, Jan Nieuwenhuizen wrote: > Andy Wingo writes: > > > On Fri 20 Dec 2019 18:32, lloda writes: > > > >> This patch adds string-replace-substring that wingo posted to the > >> mailing list to (ice-9 strings). This is a commonly used function and = a > >> good implementation isn't trivial, so I think it deserves inclusion. > > > > I didn't know that this module existed :) Sure, why not. Please fix > > the commit message when you push. > > That's great! This is one of the things that has always amazed and > annoyed me to be missing and I have written several half-baken > implementations of it when I needed something like it. > > Would it be too much to ask for some documentation to go with it, so > that we will be able to find it? > > Greetings, > janneke > > -- > Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org > Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.c= om > > --0000000000009d01a4059b64d871 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This function has an interesting history.
<= br>
Someone or something in #guile had clued me there was a magic= string-replace-substring somewhere in guile-user archives. With some luck = I found it, and had bookmarked it, and kept it at the back of my mind for a= good number of months.

Meanwhile I was steadi= ly learning guile, and cleaning up GnuCash. Noting GnuCash still supports u= se of guile-2.0, I was finally able to use Mark's implementation to fix= a bad one[1].=C2=A0=C2=A0 After discussing this change with GnuCash's = lead developer, we realised that upgrading the embedded guile in GnuCash in= Windows to 2.2 would solve a whole lot of i18n issues, which it did.
=

Hence in a roundabout way, we are thankful for the orig= inal post and the discussion[2] around it.

On Sun, = 5 Jan 2020 at 12:12, Jan Nieuwenhuizen <janneke@gnu.org> wrote:
Andy Wingo writes:

> On Fri 20 Dec 2019 18:32, lloda <lloda@sarc.name> writes:
>
>> This patch adds string-replace-substring that wingo posted to the<= br> >> mailing list to (ice-9 strings). This is a commonly used function = and a
>> good implementation isn't trivial, so I think it deserves incl= usion.
>
> I didn't know that this module existed :)=C2=A0 Sure, why not.=C2= =A0 Please fix
> the commit message when you push.

That's great!=C2=A0 This is one of the things that has always amazed an= d
annoyed me to be missing and I have written several half-baken
implementations of it when I needed something like it.

Would it be too much to ask for some documentation to go with it, so
that we will be able to find it?

Greetings,
janneke

--
Jan Nieuwenhuizen <= janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.c= om

--0000000000009d01a4059b64d871--