Status of elisp support in Guile

Status of elisp support in Guile

[Wilfred Hughes]

I've noticed that NEWS in Guile trunk says:

** Complete Emacs-compatible Elisp implementation

However, I can see that there are 36 commits on the wip-elisp branch
that aren't in master. For example, defsubst support[1] seems only to
be on wip-elisp branch. It's still the case the guile-emacs docs[2]
recommend using the wip-elisp branch.

I can merge master into wip-elisp only one trivial conflict[3]. Can
anyone shed any light on the work outstanding here, and the process to
land these patches? Relatedly, what's the process for getting commit
access to Guile?

Wilfred

1: defsubst declaration:
http://git.savannah.gnu.org/cgit/guile.git/commit/?h=wip-elisp&id=69b80315b53d237c048afaa9692fa96f1c0a3536
and use: http://git.savannah.gnu.org/cgit/guile.git/commit/?h=wip-elisp&id=9f316dd7533d2532aabbce8ee2a2c9c326e7fb91

2: guile-emacs docs: https://www.emacswiki.org/emacs/GuileEmacs
particularly the build instructions (which I've recently refactored):
https://www.emacswiki.org/emacs/GuileEmacsBuild

3: conflict: 'check symbols constants uninterned'
http://git.savannah.gnu.org/cgit/guile.git/commit/?h=wip-elisp&id=175b64aed21df66061e00d2a7063fc6533f08d66
seems to have been independently fixed in master 'Don't serialize
uninterned symbols'
http://git.savannah.gnu.org/cgit/guile.git/commit/?id=1d72d469517ca858736bfc227d8382bfb1d84b21

Re: Status of elisp support in Guile

[Christopher Allan Webber]

Wilfred Hughes writes:

> I've noticed that NEWS in Guile trunk says:
>
> ** Complete Emacs-compatible Elisp implementation
>
> However, I can see that there are 36 commits on the wip-elisp branch
> that aren't in master. For example, defsubst support[1] seems only to
> be on wip-elisp branch. It's still the case the guile-emacs docs[2]
> recommend using the wip-elisp branch.
>
> I can merge master into wip-elisp only one trivial conflict[3]. Can
> anyone shed any light on the work outstanding here, and the process to
> land these patches?

Hi!  So, I'm the one who did the most recent rebase of wip-elisp.

Last I heard, Wingo was interested in merging, but looked over the
branch and saw that it wasn't a trivial merge... the branch added some
non-trivial changes to the compiler, and I think Wingo wanted to review
those before merging.  (I'm not really qualified to help, there.)

> Relatedly, what's the process for getting commit access to Guile?

I leave this one to someone else to reply to, but you'd definitely need
to do copyright assignment for Guile.  I think other "establishing
yourself in the community" things apply, informally(??)

Re: Status of elisp support in Guile

[Wilfred Hughes]

[-- Attachment #1: Type: text/plain, Size: 2018 bytes --]

> the branch added some non-trivial changes to the compiler, and I think
Wingo wanted to review
those before merging.

That makes sense, thanks. I was hoping we could land the uncontroversial
patches, to make the diff easier to review and simplify any future rebases.
I mentioned the defsubst commits as they seemed reasonable at first glance.

Is this feasible?

> you'd definitely need to do copyright assignment for Guile.  I think
other "establishing
yourself in the community" things apply, informally(??)

I have copyright assignment all in order now :). I don't have any wild
ambitions for sweeping changes, I just thought it might be easier to land
simple docs patches without making work for the core Guile folks.

On 10 October 2016 at 19:35, Christopher Allan Webber <
cwebber@dustycloud.org> wrote:

> Wilfred Hughes writes:
>
> > I've noticed that NEWS in Guile trunk says:
> >
> > ** Complete Emacs-compatible Elisp implementation
> >
> > However, I can see that there are 36 commits on the wip-elisp branch
> > that aren't in master. For example, defsubst support[1] seems only to
> > be on wip-elisp branch. It's still the case the guile-emacs docs[2]
> > recommend using the wip-elisp branch.
> >
> > I can merge master into wip-elisp only one trivial conflict[3]. Can
> > anyone shed any light on the work outstanding here, and the process to
> > land these patches?
>
> Hi!  So, I'm the one who did the most recent rebase of wip-elisp.
>
> Last I heard, Wingo was interested in merging, but looked over the
> branch and saw that it wasn't a trivial merge... the branch added some
> non-trivial changes to the compiler, and I think Wingo wanted to review
> those before merging.  (I'm not really qualified to help, there.)
>
> > Relatedly, what's the process for getting commit access to Guile?
>
> I leave this one to someone else to reply to, but you'd definitely need
> to do copyright assignment for Guile.  I think other "establishing
> yourself in the community" things apply, informally(??)
>

[-- Attachment #2: Type: text/html, Size: 2631 bytes --]

Re: Status of elisp support in Guile

[Christopher Allan Webber]

Wilfred Hughes writes:

>> you'd definitely need to do copyright assignment for Guile.  I think
>> other "establishing yourself in the community" things apply,
>> informally(??)
>
> I have copyright assignment all in order now :). I don't have any wild
> ambitions for sweeping changes, I just thought it might be easier to land
> simple docs patches without making work for the core Guile folks.

Again, can't speak to giving out commit access... that's not my area.

But if you have documentation patches, and since you've done copyright
assignment, those would be most welcome.  If you could post them to the
list, I could help get them into the wip-elisp branch!