From: David Michael <fedora.dm0@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] guile-readline: Use an empty string if HOME is unset
Date: Wed, 10 Sep 2014 14:06:15 -0400 [thread overview]
Message-ID: <CAEvUa7mHejzTjc-3VZYvw+o9UoXP5+jHJShjEK+8A5r56gKiWA@mail.gmail.com> (raw)
In-Reply-To: <83k35b9zs0.fsf@gnu.org>
On Wed, Sep 10, 2014 at 1:00 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: David Michael <fedora.dm0@gmail.com>
>> Date: Tue, 09 Sep 2014 17:28:42 -0400
>>
>> -(define-once history-file (string-append (getenv "HOME") "/.guile_history"))
>> +(define-once history-file
>> + (string-append (or (getenv "HOME") "") "/.guile_history"))
>
> Is there any guarantee that the root directory will be writable?
>
> How about "./.guile_history" instead?
That is okay with me. Do you want a new patch with s/""/"."/ and
s/empty string/current directory/?
Thanks.
David
P.S. I resent the patch to bug-guile earlier so it got a bug number.
It's #18439. Sorry for double-posting.
next prev parent reply other threads:[~2014-09-10 18:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 21:28 [PATCH] guile-readline: Use an empty string if HOME is unset David Michael
2014-09-10 17:00 ` Eli Zaretskii
2014-09-10 18:06 ` David Michael [this message]
2014-09-10 18:23 ` Eli Zaretskii
2014-09-22 3:38 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEvUa7mHejzTjc-3VZYvw+o9UoXP5+jHJShjEK+8A5r56gKiWA@mail.gmail.com \
--to=fedora.dm0@gmail.com \
--cc=eliz@gnu.org \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).