From: Damien Mattei <damien.mattei@gmail.com>
To: Olivier Dion <olivier.dion@polymtl.ca>
Cc: guile-user <guile-user@gnu.org>, guile-devel <guile-devel@gnu.org>
Subject: Re: map-par slower than map
Date: Thu, 13 Oct 2022 15:43:46 +0200 [thread overview]
Message-ID: <CADEOadf-3D4nEzpO2Ds_Zr6i04CJYLEwegReuEEJxf+sm-q=Lg@mail.gmail.com> (raw)
In-Reply-To: <87zgdz6glm.fsf@laura>
i do not see what has changed in your code ?
really strange,even with bad code the moment it crash should be the same,
sometimes works,crash or freeze....
On Thu, Oct 13, 2022 at 2:41 PM Olivier Dion <olivier.dion@polymtl.ca>
wrote:
> On Thu, 13 Oct 2022, Damien Mattei <damien.mattei@gmail.com> wrote:
> > the code did not worked when data length were more little than number of
> > cpus (6 on my host) (iota 5) returns #unsepcified:
>
> Yeah sorry I miss indended the output and the rest. Here's a version
> that should work:
> --8<---------------cut here---------------start------------->8---
> (use-modules
> (srfi srfi-1)
> (ice-9 threads))
>
> (define* (par-map-vector proc input
> #:optional
> (max-thread (current-processor-count)))
>
> (let* ((block-size (quotient (vector-length input) max-thread))
> (rest (remainder (vector-length input) max-thread))
> (output (make-vector (vector-length input) #f)))
> (when (not (zero? block-size))
> (let ((mtx (make-mutex))
> (cnd (make-condition-variable))
> (n 0))
> (fold
> (lambda (scale output)
> (begin-thread
> (let lp ((i 0))
> (when (< i block-size)
> (let ((i (+ i (* scale block-size))))
> (vector-set! output i (proc (vector-ref input i))))
> (lp (1+ i))))
> (with-mutex mtx
> (set! n (1+ n))
> (signal-condition-variable cnd)))
> output)
> output
> (iota max-thread))
> (with-mutex mtx
> (while (not (< n max-thread))
> (wait-condition-variable cnd mtx)))))
> (let ((base (- (vector-length input) rest)))
> (let lp ((i 0))
> (when (< i rest)
> (let ((i (+ i base)))
> (vector-set! output i (proc (vector-ref input i))))
> (lp (1+ i)))))
> output))
> --8<---------------cut here---------------end--------------->8---
>
> --
> Olivier Dion
> oldiob.dev
>
next prev parent reply other threads:[~2022-10-13 13:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 17:19 map-par slower than map Damien Mattei
2022-10-12 18:45 ` Maxime Devos
2022-10-12 20:20 ` Damien Mattei
2022-10-12 20:27 ` Damien Mattei
2022-10-12 21:29 ` Zelphir Kaltstahl
2022-10-14 8:21 ` Damien Mattei
2022-10-14 8:38 ` Zelphir Kaltstahl
2022-10-17 13:17 ` Damien Mattei
2022-10-22 16:01 ` Damien Mattei
2022-10-23 1:06 ` Damien Mattei
2022-10-25 9:07 ` Mikael Djurfeldt
2022-10-25 9:11 ` Mikael Djurfeldt
2022-10-25 14:09 ` Damien Mattei
2022-10-12 21:44 ` Maxime Devos
2022-10-12 21:55 ` Olivier Dion via Developers list for Guile, the GNU extensibility library
2022-10-13 7:40 ` Damien Mattei
2022-10-13 8:20 ` Damien Mattei
2022-10-13 9:10 ` Olivier Dion via Developers list for Guile, the GNU extensibility library
2022-10-13 10:44 ` Damien Mattei
2022-10-13 11:00 ` Olivier Dion via Developers list for Guile, the GNU extensibility library
[not found] ` <CADEOadfovi8s3OxRcssWOuOW8jjHoL9Z7pD_5FstSm=ZkBHP8g@mail.gmail.com>
2022-10-13 11:57 ` Fwd: " Damien Mattei
2022-10-13 12:36 ` Damien Mattei
2022-10-13 12:41 ` Olivier Dion via Developers list for Guile, the GNU extensibility library
2022-10-13 13:43 ` Damien Mattei [this message]
2022-10-13 14:06 ` Olivier Dion via Developers list for Guile, the GNU extensibility library
2022-10-13 14:10 ` Damien Mattei
2022-10-13 14:21 ` Damien Mattei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADEOadf-3D4nEzpO2Ds_Zr6i04CJYLEwegReuEEJxf+sm-q=Lg@mail.gmail.com' \
--to=damien.mattei@gmail.com \
--cc=guile-devel@gnu.org \
--cc=guile-user@gnu.org \
--cc=olivier.dion@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).