* Patches for module/ice-9/occam-channel.scm
@ 2012-04-30 12:42 Daniel Krueger
2012-05-04 2:58 ` Noah Lavine
0 siblings, 1 reply; 8+ messages in thread
From: Daniel Krueger @ 2012-04-30 12:42 UTC (permalink / raw)
To: guile-devel
[-- Attachment #1: Type: text/plain, Size: 214 bytes --]
Hi,
I've done some work on (ice-9 occam-channel) and fixed the module
exports, the alt macro and extended it a little bit. Here are the
patches, but they are all just micro-commits, I hope that is okay.
- Daniel
[-- Attachment #2: 0001-fixed-exports-of-module-ice-9-occam-channel.scm.patch --]
[-- Type: application/octet-stream, Size: 5835 bytes --]
From 5a685e4cdeb8a994d175f7d015dfa805cbda4d6e Mon Sep 17 00:00:00 2001
From: Daniel Krueger <keenbug@gmail.com>
Date: Mon, 30 Apr 2012 13:42:43 +0200
Subject: [PATCH 1/4] fixed exports of module/ice-9/occam-channel.scm
---
module/ice-9/occam-channel.scm | 110 +++++++++++++++++++---------------------
1 file changed, 51 insertions(+), 59 deletions(-)
diff --git a/module/ice-9/occam-channel.scm b/module/ice-9/occam-channel.scm
index ea1154b..c009478 100644
--- a/module/ice-9/occam-channel.scm
+++ b/module/ice-9/occam-channel.scm
@@ -19,20 +19,12 @@
(define-module (ice-9 occam-channel)
#:use-module (oop goops)
#:use-module (ice-9 threads)
- #:export-syntax (alt
- ;; macro use:
- oc:lock oc:unlock oc:consequence
- oc:immediate-dispatch oc:late-dispatch oc:first-channel
- oc:set-handshake-channel oc:unset-handshake-channel)
#:export (make-channel
- ?
- !
- make-timer
- ;; macro use:
- handshake-channel mutex
- sender-waiting?
- immediate-receive late-receive
- )
+ ?
+ !
+ make-timer
+ alt
+ )
)
(define no-data '(no-data))
@@ -73,16 +65,16 @@
(define-method (? (ch <data-channel>))
(lock-mutex (mutex ch))
(let ((res (cond ((receiver-waiting? ch)
- (unlock-mutex (mutex ch))
- (scm-error 'misc-error '?
- "another process is already receiving on ~A"
- (list ch) #f))
- ((sender-waiting? ch)
- (immediate-receive ch))
- (else
- (set! (data ch) receiver-waiting)
- (wait-condition-variable (cv ch) (mutex ch))
- (late-receive ch)))))
+ (unlock-mutex (mutex ch))
+ (scm-error 'misc-error '?
+ "another process is already receiving on ~A"
+ (list ch) #f))
+ ((sender-waiting? ch)
+ (immediate-receive ch))
+ (else
+ (set! (data ch) receiver-waiting)
+ (wait-condition-variable (cv ch) (mutex ch))
+ (late-receive ch)))))
(unlock-mutex (mutex ch))
res))
@@ -92,15 +84,15 @@
(define-method (! (ch <data-channel>) (x <top>))
(lock-mutex (mutex (handshake-channel ch)))
(cond ((receiver-waiting? ch)
- (set! (data ch) x)
- (signal-condition-variable (cv (handshake-channel ch))))
- ((sender-waiting? ch)
- (unlock-mutex (mutex (handshake-channel ch)))
- (scm-error 'misc-error '! "another process is already sending on ~A"
- (list ch) #f))
- (else
- (set! (data ch) x)
- (wait-condition-variable (cv ch) (mutex ch))))
+ (set! (data ch) x)
+ (signal-condition-variable (cv (handshake-channel ch))))
+ ((sender-waiting? ch)
+ (unlock-mutex (mutex (handshake-channel ch)))
+ (scm-error 'misc-error '! "another process is already sending on ~A"
+ (list ch) #f))
+ (else
+ (set! (data ch) x)
+ (wait-condition-variable (cv ch) (mutex ch))))
(unlock-mutex (mutex (handshake-channel ch))))
;;; Add protocols?
@@ -132,7 +124,7 @@
(define (us->timeofday n)
(cons (quotient n 1000000)
- (remainder n 1000000)))
+ (remainder n 1000000)))
(define-method (? (ch <timer-channel>))
(timeofday->us (gettimeofday)))
@@ -226,36 +218,36 @@
(lambda (x)
(define (else-clause? x)
(syntax-case x (else)
- ((_) #f)
- ((_ (else e1 e2 ...)) #t)
- ((_ c1 c2 ...) (else-clause? (syntax (_ c2 ...))))))
+ ((_) #f)
+ ((_ (else e1 e2 ...)) #t)
+ ((_ c1 c2 ...) (else-clause? (syntax (_ c2 ...))))))
(syntax-case x (else)
((_ c1 c2 ...)
(else-clause? x)
(syntax (begin
- (oc:lock c1)
- (oc:lock c2) ...
- (let ((res (cond (oc:immediate-dispatch c1)
- (oc:immediate-dispatch c2) ...)))
- (oc:unlock c1)
- (oc:unlock c2) ...
- res))))
+ (oc:lock c1)
+ (oc:lock c2) ...
+ (let ((res (cond (oc:immediate-dispatch c1)
+ (oc:immediate-dispatch c2) ...)))
+ (oc:unlock c1)
+ (oc:unlock c2) ...
+ res))))
((_ c1 c2 ...)
(syntax (begin
- (oc:lock c1)
- (oc:lock c2) ...
- (let ((res (cond (oc:immediate-dispatch c1)
- (oc:immediate-dispatch c2) ...
- (else (let ((ch (oc:first-channel c1 c2 ...)))
- (oc:set-handshake-channel c1 ch)
- (oc:set-handshake-channel c2 ch) ...
- (wait-condition-variable (cv ch)
- (mutex ch))
- (oc:unset-handshake-channel c1)
- (oc:unset-handshake-channel c2) ...
- (cond (oc:late-dispatch c1)
- (oc:late-dispatch c2) ...))))))
- (oc:unlock c1)
- (oc:unlock c2) ...
- res)))))))
+ (oc:lock c1)
+ (oc:lock c2) ...
+ (let ((res (cond (oc:immediate-dispatch c1)
+ (oc:immediate-dispatch c2) ...
+ (else (let ((ch (oc:first-channel c1 c2 ...)))
+ (oc:set-handshake-channel c1 ch)
+ (oc:set-handshake-channel c2 ch) ...
+ (wait-condition-variable (cv ch)
+ (mutex ch))
+ (oc:unset-handshake-channel c1)
+ (oc:unset-handshake-channel c2) ...
+ (cond (oc:late-dispatch c1)
+ (oc:late-dispatch c2) ...))))))
+ (oc:unlock c1)
+ (oc:unlock c2) ...
+ res)))))))
--
1.7.10
[-- Attachment #3: 0002-added-some-commentary-to-module-ice-9-occam-channel..patch --]
[-- Type: application/octet-stream, Size: 1152 bytes --]
From d5e3ecbb57b5c0ac40699b31c9fe5aa3eba03d5b Mon Sep 17 00:00:00 2001
From: Daniel Krueger <keenbug@gmail.com>
Date: Mon, 30 Apr 2012 13:47:19 +0200
Subject: [PATCH 2/4] added some commentary to module/ice-9/occam-channel.scm
---
module/ice-9/occam-channel.scm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/module/ice-9/occam-channel.scm b/module/ice-9/occam-channel.scm
index c009478..cee04ce 100644
--- a/module/ice-9/occam-channel.scm
+++ b/module/ice-9/occam-channel.scm
@@ -51,12 +51,16 @@
(define-method (receiver-waiting? (ch <data-channel>))
(eq? (data ch) receiver-waiting))
+;;; receive data if the sender already put something
+;;; on the channel
(define-method (immediate-receive (ch <data-channel>))
- (signal-condition-variable (cv ch))
+ (signal-condition-variable (cv ch)) ; we read the data now, so the sender can go on
(let ((res (data ch)))
(set! (data ch) no-data)
res))
+;;; receive data after we waited fo the sender to
+;;; put something on the channel
(define-method (late-receive (ch <data-channel>))
(let ((res (data ch)))
(set! (data ch) no-data)
--
1.7.10
[-- Attachment #4: 0003-module-ice-9-occam-channel.scm-now-channels-can-also.patch --]
[-- Type: application/octet-stream, Size: 5423 bytes --]
From 9b0e0dcbd5668b19c758dc80f08e6b18abcb89e3 Mon Sep 17 00:00:00 2001
From: Daniel Krueger <keenbug@gmail.com>
Date: Mon, 30 Apr 2012 14:26:49 +0200
Subject: [PATCH 3/4] module/ice-9/occam-channel.scm: now channels can also be
accessed in alt clauses
---
module/ice-9/occam-channel.scm | 106 ++++++++++++++++++++--------------------
1 file changed, 54 insertions(+), 52 deletions(-)
diff --git a/module/ice-9/occam-channel.scm b/module/ice-9/occam-channel.scm
index cee04ce..ae47d86 100644
--- a/module/ice-9/occam-channel.scm
+++ b/module/ice-9/occam-channel.scm
@@ -163,33 +163,11 @@
(define-syntax oc:consequence
(syntax-rules (=>)
- ((_ data) data)
- ((_ data => (lambda (x) e1 e2 ...))
- (let ((x data)) e1 e2 ...))
- ((_ data e1 e2 ...)
- (begin data e1 e2 ...))))
-
-(define-syntax oc:immediate-dispatch
- (syntax-rules (?)
- ((_ ((? ch) e1 ...))
- ((sender-waiting? ch)
- (oc:consequence (immediate-receive ch) e1 ...)))
- ((_ (exp (? ch) e1 ...))
- ((and exp (sender-waiting? ch))
- (oc:consequence (immediate-receive ch) e1 ...)))
- ((_ (exp e1 ...))
- (exp e1 ...))))
-
-(define-syntax oc:late-dispatch
- (syntax-rules (?)
- ((_ ((? ch) e1 ...))
- ((sender-waiting? ch)
- (oc:consequence (late-receive ch) e1 ...)))
- ((_ (exp (? ch) e1 ...))
- ((and exp (sender-waiting? ch))
- (oc:consequence (late-receive ch) e1 ...)))
- ((_ (exp e1 ...))
- (#f))))
+ ((_ unlock data) data)
+ ((_ unlock data => (lambda (x) e1 e2 ...))
+ (let ((x data)) (unlock) e1 e2 ...))
+ ((_ unlock data e1 e2 ...)
+ (begin data (unlock) e1 e2 ...))))
(define-syntax oc:first-channel
(syntax-rules (?)
@@ -218,8 +196,33 @@
((_ (exp e1 ...))
#f)))
+
(define-syntax alt
(lambda (x)
+ (define (oc:immediate-dispatcher unlock)
+ (lambda (clause)
+ (syntax-case clause (?)
+ (((? ch) e1 ...)
+ #`((sender-waiting? ch)
+ (oc:consequence #,unlock (immediate-receive ch) e1 ...)))
+ ((exp (? ch) e1 ...)
+ #`((and exp (sender-waiting? ch))
+ (oc:consequence #,unlock (immediate-receive ch) e1 ...)))
+ ((exp e1 ...)
+ #`(exp (#,unlock) e1 ...)))))
+
+ (define (oc:late-dispatcher unlock)
+ (lambda (clause)
+ (syntax-case clause (?)
+ (((? ch) e1 ...)
+ #`((sender-waiting? ch)
+ (oc:consequence #,unlock (late-receive ch) e1 ...)))
+ ((exp (? ch) e1 ...)
+ #`((and exp (sender-waiting? ch))
+ (oc:consequence #,unlock (late-receive ch) e1 ...)))
+ ((exp e1 ...)
+ #`(#f)))))
+
(define (else-clause? x)
(syntax-case x (else)
((_) #f)
@@ -229,29 +232,28 @@
(syntax-case x (else)
((_ c1 c2 ...)
(else-clause? x)
- (syntax (begin
- (oc:lock c1)
- (oc:lock c2) ...
- (let ((res (cond (oc:immediate-dispatch c1)
- (oc:immediate-dispatch c2) ...)))
- (oc:unlock c1)
- (oc:unlock c2) ...
- res))))
+ #`(let ((unlock (lambda ()
+ (oc:unlock c1)
+ (oc:unlock c2) ...)))
+ (oc:lock c1)
+ (oc:lock c2) ...
+ (cond #,@(map (oc:immediate-dispatcher #'unlock)
+ #'(c1 c2 ...)))))
((_ c1 c2 ...)
- (syntax (begin
- (oc:lock c1)
- (oc:lock c2) ...
- (let ((res (cond (oc:immediate-dispatch c1)
- (oc:immediate-dispatch c2) ...
- (else (let ((ch (oc:first-channel c1 c2 ...)))
- (oc:set-handshake-channel c1 ch)
- (oc:set-handshake-channel c2 ch) ...
- (wait-condition-variable (cv ch)
- (mutex ch))
- (oc:unset-handshake-channel c1)
- (oc:unset-handshake-channel c2) ...
- (cond (oc:late-dispatch c1)
- (oc:late-dispatch c2) ...))))))
- (oc:unlock c1)
- (oc:unlock c2) ...
- res)))))))
+ #`(let ((unlock (lambda ()
+ (oc:unlock c1)
+ (oc:unlock c2) ...)))
+ (oc:lock c1)
+ (oc:lock c2) ...
+ (cond #,@(map (oc:immediate-dispatcher #'unlock)
+ #'(c1 c2 ...))
+ (else (let ((ch (oc:first-channel c1 c2 ...)))
+ (oc:set-handshake-channel c1 ch)
+ (oc:set-handshake-channel c2 ch) ...
+ (wait-condition-variable (cv ch)
+ (mutex ch))
+ (oc:unset-handshake-channel c1)
+ (oc:unset-handshake-channel c2) ...
+ (cond #,@(map (oc:late-dispatcher #'unlock)
+ #'(c1 c2 ...))
+ (else (unlock) (if #f #f)))))))))))
--
1.7.10
[-- Attachment #5: 0004-module-ice-9-occam-channel.scm-alt-now-also-a-proc-i.patch --]
[-- Type: application/octet-stream, Size: 812 bytes --]
From d9d2199c90f6f4adffb645d4c4a6161b8c91d8ad Mon Sep 17 00:00:00 2001
From: Daniel Krueger <keenbug@gmail.com>
Date: Mon, 30 Apr 2012 14:28:27 +0200
Subject: [PATCH 4/4] module/ice-9/occam-channel.scm: alt: now also a =>
proc-identifier clause works
---
module/ice-9/occam-channel.scm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/module/ice-9/occam-channel.scm b/module/ice-9/occam-channel.scm
index ae47d86..2ecf2fa 100644
--- a/module/ice-9/occam-channel.scm
+++ b/module/ice-9/occam-channel.scm
@@ -166,6 +166,8 @@
((_ unlock data) data)
((_ unlock data => (lambda (x) e1 e2 ...))
(let ((x data)) (unlock) e1 e2 ...))
+ ((_ unlock data => proc)
+ (let ((x data)) (unlock) (proc x)))
((_ unlock data e1 e2 ...)
(begin data (unlock) e1 e2 ...))))
--
1.7.10
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: Patches for module/ice-9/occam-channel.scm
2012-04-30 12:42 Patches for module/ice-9/occam-channel.scm Daniel Krueger
@ 2012-05-04 2:58 ` Noah Lavine
2012-05-04 3:18 ` Nala Ginrut
0 siblings, 1 reply; 8+ messages in thread
From: Noah Lavine @ 2012-05-04 2:58 UTC (permalink / raw)
To: Daniel Krueger; +Cc: guile-devel
Hello,
Thanks a lot for submitting them! Micro-commits are exactly what we want.
These patches raise an interesting issue. I do not use occam-channel,
and in fact I have no idea what it does since it has no documentation
and no tests. Normally I only reply to emails if I think I know
enough to give an intelligent response, but in this case no one else
is replying either. This might be wrong, but it's entirely possible
that no one except you on this list has any way to check that these
are correct. (Or if they do, the people who know are not replying.)
So I propose this: if no one replies to this email in two days, I will
merge the patches.
And I hate to ask you for more after you've already contributed, but
if you are able, could you write some documentation or tests for this
module? It could badly use both of those things.
Thanks a lot,
Noah
On Mon, Apr 30, 2012 at 8:42 AM, Daniel Krueger <keenbug@googlemail.com> wrote:
> Hi,
>
> I've done some work on (ice-9 occam-channel) and fixed the module
> exports, the alt macro and extended it a little bit. Here are the
> patches, but they are all just micro-commits, I hope that is okay.
>
> - Daniel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Patches for module/ice-9/occam-channel.scm
2012-05-04 2:58 ` Noah Lavine
@ 2012-05-04 3:18 ` Nala Ginrut
2012-05-04 13:17 ` Andrew Gwozdziewycz
0 siblings, 1 reply; 8+ messages in thread
From: Nala Ginrut @ 2012-05-04 3:18 UTC (permalink / raw)
To: Noah Lavine; +Cc: Daniel Krueger, guile-devel
Well, I think it's something like Actors but little different.
And I think it would be nice if there's a document for it.
On Fri, May 4, 2012 at 10:58 AM, Noah Lavine <noah.b.lavine@gmail.com> wrote:
> Hello,
>
> Thanks a lot for submitting them! Micro-commits are exactly what we want.
>
> These patches raise an interesting issue. I do not use occam-channel,
> and in fact I have no idea what it does since it has no documentation
> and no tests. Normally I only reply to emails if I think I know
> enough to give an intelligent response, but in this case no one else
> is replying either. This might be wrong, but it's entirely possible
> that no one except you on this list has any way to check that these
> are correct. (Or if they do, the people who know are not replying.)
>
> So I propose this: if no one replies to this email in two days, I will
> merge the patches.
>
> And I hate to ask you for more after you've already contributed, but
> if you are able, could you write some documentation or tests for this
> module? It could badly use both of those things.
>
> Thanks a lot,
> Noah
>
> On Mon, Apr 30, 2012 at 8:42 AM, Daniel Krueger <keenbug@googlemail.com> wrote:
>> Hi,
>>
>> I've done some work on (ice-9 occam-channel) and fixed the module
>> exports, the alt macro and extended it a little bit. Here are the
>> patches, but they are all just micro-commits, I hope that is okay.
>>
>> - Daniel
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Patches for module/ice-9/occam-channel.scm
2012-05-04 3:18 ` Nala Ginrut
@ 2012-05-04 13:17 ` Andrew Gwozdziewycz
2012-05-06 9:33 ` Daniel Krueger
0 siblings, 1 reply; 8+ messages in thread
From: Andrew Gwozdziewycz @ 2012-05-04 13:17 UTC (permalink / raw)
To: Nala Ginrut; +Cc: Daniel Krueger, guile-devel
On Thu, May 3, 2012 at 11:18 PM, Nala Ginrut <nalaginrut@gmail.com> wrote:
> Well, I think it's something like Actors but little different.
> And I think it would be nice if there's a document for it.
It's a foundational part of actors, more than actors themselves.
Actors need some sort of "mailbox" to communicate with the outside
world[0]. Channels provide a type of mailbox. I assume by the name,
the semantics of the channels provided in occam-channel, closely
resemble those in the Occam programming language. I believe the
semantics of Occam channels are based on C.A.R. Hoare's CSP[1].
[0]: https://en.wikipedia.org/wiki/Actor_model
[1]: https://en.wikipedia.org/wiki/Communicating_sequential_processes
> On Fri, May 4, 2012 at 10:58 AM, Noah Lavine <noah.b.lavine@gmail.com> wrote:
>> Hello,
>>
>> Thanks a lot for submitting them! Micro-commits are exactly what we want.
>>
>> These patches raise an interesting issue. I do not use occam-channel,
>> and in fact I have no idea what it does since it has no documentation
>> and no tests. Normally I only reply to emails if I think I know
>> enough to give an intelligent response, but in this case no one else
>> is replying either. This might be wrong, but it's entirely possible
>> that no one except you on this list has any way to check that these
>> are correct. (Or if they do, the people who know are not replying.)
>>
>> So I propose this: if no one replies to this email in two days, I will
>> merge the patches.
>>
>> And I hate to ask you for more after you've already contributed, but
>> if you are able, could you write some documentation or tests for this
>> module? It could badly use both of those things.
>>
>> Thanks a lot,
>> Noah
>>
>> On Mon, Apr 30, 2012 at 8:42 AM, Daniel Krueger <keenbug@googlemail.com> wrote:
>>> Hi,
>>>
>>> I've done some work on (ice-9 occam-channel) and fixed the module
>>> exports, the alt macro and extended it a little bit. Here are the
>>> patches, but they are all just micro-commits, I hope that is okay.
>>>
>>> - Daniel
>>
>
--
http://www.apgwoz.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Patches for module/ice-9/occam-channel.scm
2012-05-04 13:17 ` Andrew Gwozdziewycz
@ 2012-05-06 9:33 ` Daniel Krueger
2012-05-09 12:06 ` Noah Lavine
0 siblings, 1 reply; 8+ messages in thread
From: Daniel Krueger @ 2012-05-06 9:33 UTC (permalink / raw)
To: Andrew Gwozdziewycz; +Cc: guile-devel
Hey,
I myself don't know much about the foundations of the module itself, I
only know it should be really the same as occam's channels, but I
don't know much about them. I just found the package and thought it
would seems to be useful. And as I tried to use it I found the
incompatibilities and fixed them. So I just know how this
implementation works, but not very much about the background.
I could do some documentation, it's just that I never documented
something in this info(?) format. I'll try it and send some patches,
you can then look if it's okay ^^
- Daniel
On Fri, May 4, 2012 at 3:17 PM, Andrew Gwozdziewycz <apgwoz@gmail.com> wrote:
> On Thu, May 3, 2012 at 11:18 PM, Nala Ginrut <nalaginrut@gmail.com> wrote:
>> Well, I think it's something like Actors but little different.
>> And I think it would be nice if there's a document for it.
>
> It's a foundational part of actors, more than actors themselves.
> Actors need some sort of "mailbox" to communicate with the outside
> world[0]. Channels provide a type of mailbox. I assume by the name,
> the semantics of the channels provided in occam-channel, closely
> resemble those in the Occam programming language. I believe the
> semantics of Occam channels are based on C.A.R. Hoare's CSP[1].
>
> [0]: https://en.wikipedia.org/wiki/Actor_model
> [1]: https://en.wikipedia.org/wiki/Communicating_sequential_processes
>
>> On Fri, May 4, 2012 at 10:58 AM, Noah Lavine <noah.b.lavine@gmail.com> wrote:
>>> Hello,
>>>
>>> Thanks a lot for submitting them! Micro-commits are exactly what we want.
>>>
>>> These patches raise an interesting issue. I do not use occam-channel,
>>> and in fact I have no idea what it does since it has no documentation
>>> and no tests. Normally I only reply to emails if I think I know
>>> enough to give an intelligent response, but in this case no one else
>>> is replying either. This might be wrong, but it's entirely possible
>>> that no one except you on this list has any way to check that these
>>> are correct. (Or if they do, the people who know are not replying.)
>>>
>>> So I propose this: if no one replies to this email in two days, I will
>>> merge the patches.
>>>
>>> And I hate to ask you for more after you've already contributed, but
>>> if you are able, could you write some documentation or tests for this
>>> module? It could badly use both of those things.
>>>
>>> Thanks a lot,
>>> Noah
>>>
>>> On Mon, Apr 30, 2012 at 8:42 AM, Daniel Krueger <keenbug@googlemail.com> wrote:
>>>> Hi,
>>>>
>>>> I've done some work on (ice-9 occam-channel) and fixed the module
>>>> exports, the alt macro and extended it a little bit. Here are the
>>>> patches, but they are all just micro-commits, I hope that is okay.
>>>>
>>>> - Daniel
>>>
>>
>
>
>
> --
> http://www.apgwoz.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Patches for module/ice-9/occam-channel.scm
2012-05-06 9:33 ` Daniel Krueger
@ 2012-05-09 12:06 ` Noah Lavine
2012-05-15 22:37 ` Mark H Weaver
0 siblings, 1 reply; 8+ messages in thread
From: Noah Lavine @ 2012-05-09 12:06 UTC (permalink / raw)
To: Daniel Krueger; +Cc: guile-devel
Hello,
I talked some more with the maintainers. In general, everything that
goes in should have tests and documentation. This module isn't
documented to begin with, so you shouldn't have to fix that to
contribute (although of course we'd love that :-) ). However, we would
like tests for your changes, so we can catch regressions in the
future. Take a look in test-suite/tests for examples of how those
work.
Since these are relatively large changes, you'll also need to do a
copyright assignment. We assign the copyright on Guile to the Free
Software Foundation because under US law, the owner of a copyrighted
work is sometimes the only person with the power to sue over
violations of copyright. The FSF wants to be able to sue if people
violate the GPL, so we assign copyright. Please see
http://www.gnu.org/licenses/why-assign.html for more information, or
email assign@gnu.org to fill out a form.
Thanks a lot for contributing,
Noah
On Sun, May 6, 2012 at 5:33 AM, Daniel Krueger <keenbug@googlemail.com> wrote:
> Hey,
>
> I myself don't know much about the foundations of the module itself, I
> only know it should be really the same as occam's channels, but I
> don't know much about them. I just found the package and thought it
> would seems to be useful. And as I tried to use it I found the
> incompatibilities and fixed them. So I just know how this
> implementation works, but not very much about the background.
>
> I could do some documentation, it's just that I never documented
> something in this info(?) format. I'll try it and send some patches,
> you can then look if it's okay ^^
>
> - Daniel
>
> On Fri, May 4, 2012 at 3:17 PM, Andrew Gwozdziewycz <apgwoz@gmail.com> wrote:
>> On Thu, May 3, 2012 at 11:18 PM, Nala Ginrut <nalaginrut@gmail.com> wrote:
>>> Well, I think it's something like Actors but little different.
>>> And I think it would be nice if there's a document for it.
>>
>> It's a foundational part of actors, more than actors themselves.
>> Actors need some sort of "mailbox" to communicate with the outside
>> world[0]. Channels provide a type of mailbox. I assume by the name,
>> the semantics of the channels provided in occam-channel, closely
>> resemble those in the Occam programming language. I believe the
>> semantics of Occam channels are based on C.A.R. Hoare's CSP[1].
>>
>> [0]: https://en.wikipedia.org/wiki/Actor_model
>> [1]: https://en.wikipedia.org/wiki/Communicating_sequential_processes
>>
>>> On Fri, May 4, 2012 at 10:58 AM, Noah Lavine <noah.b.lavine@gmail.com> wrote:
>>>> Hello,
>>>>
>>>> Thanks a lot for submitting them! Micro-commits are exactly what we want.
>>>>
>>>> These patches raise an interesting issue. I do not use occam-channel,
>>>> and in fact I have no idea what it does since it has no documentation
>>>> and no tests. Normally I only reply to emails if I think I know
>>>> enough to give an intelligent response, but in this case no one else
>>>> is replying either. This might be wrong, but it's entirely possible
>>>> that no one except you on this list has any way to check that these
>>>> are correct. (Or if they do, the people who know are not replying.)
>>>>
>>>> So I propose this: if no one replies to this email in two days, I will
>>>> merge the patches.
>>>>
>>>> And I hate to ask you for more after you've already contributed, but
>>>> if you are able, could you write some documentation or tests for this
>>>> module? It could badly use both of those things.
>>>>
>>>> Thanks a lot,
>>>> Noah
>>>>
>>>> On Mon, Apr 30, 2012 at 8:42 AM, Daniel Krueger <keenbug@googlemail.com> wrote:
>>>>> Hi,
>>>>>
>>>>> I've done some work on (ice-9 occam-channel) and fixed the module
>>>>> exports, the alt macro and extended it a little bit. Here are the
>>>>> patches, but they are all just micro-commits, I hope that is okay.
>>>>>
>>>>> - Daniel
>>>>
>>>
>>
>>
>>
>> --
>> http://www.apgwoz.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Patches for module/ice-9/occam-channel.scm
2012-05-09 12:06 ` Noah Lavine
@ 2012-05-15 22:37 ` Mark H Weaver
2012-05-18 20:14 ` Daniel Krueger
0 siblings, 1 reply; 8+ messages in thread
From: Mark H Weaver @ 2012-05-15 22:37 UTC (permalink / raw)
To: Noah Lavine; +Cc: Daniel Krueger, guile-devel
Noah Lavine <noah.b.lavine@gmail.com> writes:
> Since these are relatively large changes, you'll also need to do a
> copyright assignment. We assign the copyright on Guile to the Free
> Software Foundation because under US law, the owner of a copyrighted
> work is sometimes the only person with the power to sue over
> violations of copyright. The FSF wants to be able to sue if people
> violate the GPL, so we assign copyright.
I'd just like to add that suing is a last resort and extremely rare,
only done when companies use our software and blatantly refuse to give
their users the rights that are guaranteed to _all_ users by the GPL.
The policy of the FSF regarding GPL violations was explained well by
Eben Moglen: <http://www.geof.net/research/2006/moglen-notes>
When I went to work for Richard Stallman in 1993, he said to me at
the first instruction over enforcing the GPL, "I have a rule. You
must never let a request for damages interfere with a settlement for
compliance." I thought about that for a moment and I decided that
that instruction meant that I could begin every telephone
conversation with a violator of the GPL with magic words: We don't
want money. When I spoke those words, life got simpler. The next
thing I said was, We don't want publicity. The third thing I said
was, We want compliance. We won't settle for anything less than
compliance, and that's all we want. Now I will show you how to make
that ice in the wintertime. And so they gave me compliance. Which
had been defined mutually as ice in the wintertime.
Unfortunately, there are many corporations that will violate the GPL
without remorse unless we have the _ability_ to sue them.
> Please see http://www.gnu.org/licenses/why-assign.html for more
> information, or email assign@gnu.org to fill out a form.
I should also mention that I'm _extremely_ allergic to legalese, and can
literally count on one hand the number of agreements I have signed in
the last decade, but the FSF legalese I was asked to sign was
refreshingly fair and reasonable.
Mark
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: Patches for module/ice-9/occam-channel.scm
2012-05-15 22:37 ` Mark H Weaver
@ 2012-05-18 20:14 ` Daniel Krueger
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Krueger @ 2012-05-18 20:14 UTC (permalink / raw)
To: Mark H Weaver; +Cc: guile-devel
Hey,
sorry for being so inactive in the last days (weeks?), I'm just having
some free time after my final exams here.
Yeah, I would assign the copyright to the FSF, I already read this but
thought I'll cope with that later^^
- Daniel
On Wed, May 16, 2012 at 12:37 AM, Mark H Weaver <mhw@netris.org> wrote:
> Noah Lavine <noah.b.lavine@gmail.com> writes:
>> Since these are relatively large changes, you'll also need to do a
>> copyright assignment. We assign the copyright on Guile to the Free
>> Software Foundation because under US law, the owner of a copyrighted
>> work is sometimes the only person with the power to sue over
>> violations of copyright. The FSF wants to be able to sue if people
>> violate the GPL, so we assign copyright.
>
> I'd just like to add that suing is a last resort and extremely rare,
> only done when companies use our software and blatantly refuse to give
> their users the rights that are guaranteed to _all_ users by the GPL.
>
> The policy of the FSF regarding GPL violations was explained well by
> Eben Moglen: <http://www.geof.net/research/2006/moglen-notes>
>
> When I went to work for Richard Stallman in 1993, he said to me at
> the first instruction over enforcing the GPL, "I have a rule. You
> must never let a request for damages interfere with a settlement for
> compliance." I thought about that for a moment and I decided that
> that instruction meant that I could begin every telephone
> conversation with a violator of the GPL with magic words: We don't
> want money. When I spoke those words, life got simpler. The next
> thing I said was, We don't want publicity. The third thing I said
> was, We want compliance. We won't settle for anything less than
> compliance, and that's all we want. Now I will show you how to make
> that ice in the wintertime. And so they gave me compliance. Which
> had been defined mutually as ice in the wintertime.
>
> Unfortunately, there are many corporations that will violate the GPL
> without remorse unless we have the _ability_ to sue them.
>
>> Please see http://www.gnu.org/licenses/why-assign.html for more
>> information, or email assign@gnu.org to fill out a form.
>
> I should also mention that I'm _extremely_ allergic to legalese, and can
> literally count on one hand the number of agreements I have signed in
> the last decade, but the FSF legalese I was asked to sign was
> refreshingly fair and reasonable.
>
> Mark
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-05-18 20:14 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-30 12:42 Patches for module/ice-9/occam-channel.scm Daniel Krueger
2012-05-04 2:58 ` Noah Lavine
2012-05-04 3:18 ` Nala Ginrut
2012-05-04 13:17 ` Andrew Gwozdziewycz
2012-05-06 9:33 ` Daniel Krueger
2012-05-09 12:06 ` Noah Lavine
2012-05-15 22:37 ` Mark H Weaver
2012-05-18 20:14 ` Daniel Krueger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).