From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?Aleix_Conchillo_Flaqu=C3=A9?= Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] allow specifying a required version in GUILE_PROGS Date: Mon, 14 Oct 2013 14:35:43 -0700 Message-ID: References: <87vc0zh8az.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=089e013d14b218ca0c04e8ba400b X-Trace: ger.gmane.org 1381786547 16285 80.91.229.3 (14 Oct 2013 21:35:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 14 Oct 2013 21:35:47 +0000 (UTC) Cc: guile-devel To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Oct 14 23:35:53 2013 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VVpns-0004Ec-Uu for guile-devel@m.gmane.org; Mon, 14 Oct 2013 23:35:53 +0200 Original-Received: from localhost ([::1]:38855 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVpns-0007bk-Ic for guile-devel@m.gmane.org; Mon, 14 Oct 2013 17:35:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVpno-0007bf-3M for guile-devel@gnu.org; Mon, 14 Oct 2013 17:35:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VVpnm-0005lq-Kq for guile-devel@gnu.org; Mon, 14 Oct 2013 17:35:48 -0400 Original-Received: from mail-lb0-x22f.google.com ([2a00:1450:4010:c04::22f]:60211) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVpnm-0005hP-71; Mon, 14 Oct 2013 17:35:46 -0400 Original-Received: by mail-lb0-f175.google.com with SMTP id y6so6153851lbh.34 for ; Mon, 14 Oct 2013 14:35:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=x0bmwOobXfeTNZIEkfwYuYvsQThkdtmzZ94CNo5Eh70=; b=t76kZFe/J3i8Ku02ZTYQyEm/n++3Yx4Roe9c6Mvf9T4r9UAwam+s+8Txpb+2r64c8c uJm9PeUQq58+XPm5Qk+npIKK4DV96gHTsaA4ms/fCU4j/kGN8WrNfl6aU0QNxEx9KOVI ZfAanaM/vC252NGSBZeqC3trNEOgI4YLMtS3fTuBwfhtDD8WbOdIGOCtl4KE+Bf0ZmrQ fnG/TNENalMqxgait+nHVwRlLydxSsRPvQWOXFFbL5DS3arLG+uhd9R59VjcIkhWstk7 W8r/VscqIkjpGlX4SgKOUD46/ZOHz5VmVdAi0/sEuGfiSMQan/OgFbwVbpdPXw87P+nz OicA== X-Received: by 10.152.3.42 with SMTP id 10mr33058770laz.22.1381786543762; Mon, 14 Oct 2013 14:35:43 -0700 (PDT) Original-Received: by 10.114.21.228 with HTTP; Mon, 14 Oct 2013 14:35:43 -0700 (PDT) In-Reply-To: <87vc0zh8az.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::22f X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:16678 Archived-At: --089e013d14b218ca0c04e8ba400b Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi! On Mon, Oct 14, 2013 at 2:05 PM, Ludovic Court=C3=A8s wrote: > Hi Aleix, > > (Second try.) > > The patch looks good to me. > > Perhaps error messages should show > $_guile_major_version.$_guile_minor_version.$_guile_micro_version since > that could differ from $_guile_prog_version (for instance in Debian > $_guile_prog_version is something like 2.0.9-deb42.) > Yes, I saw that and thought it was OK as the check was successfully anyway. But probably it looks better as you suggested. In the attached patch I don't get the version from (version) and I build _guile_prog_version with macro.minor.micro. > For code contributed to Guile, we ask for a copyright assignment to the > FSF. Would that be OK with you? If yes, I can send you the form > off-list, and then we can proceed (you might even be able to avoid snail > mail entirely.) > Yes, sure. Aleix --089e013d14b218ca0c04e8ba400b Content-Type: application/octet-stream; name="guile-progs.patch" Content-Disposition: attachment; filename="guile-progs.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hms7yp330 RnJvbSAwNWE2MjFlODgwMTU1ODQ5ZDI5M2NlMWRiNDE1NWZiOWE5N2MzYzY2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGVpeCBDb25jaGlsbG8gRmxhcXVlIDxhY29uY2hpbGxvQGdt YWlsLmNvbT4KRGF0ZTogVGh1LCAzIE9jdCAyMDEzIDE1OjQ5OjA3IC0wNzAwClN1YmplY3Q6IFtQ QVRDSF0gYWxsb3cgc3BlY2lmeWluZyBhIHJlcXVpcmVkIHZlcnNpb24gaW4gR1VJTEVfUFJPR1MK CiogbWV0YS9ndWlsZS5tNDogR1VJTEVfUFJPR1Mgbm93IHRha2VzIGFuIG9wdGlvbmFsIGFyZ3Vt ZW50IHRvIHNwZWNpZnkgYQogIHJlcXVpcmVkIEd1aWxlIHZlcnNpb24uIEJ5IGRlZmF1bHQsIGl0 IHJlcXVpcmVzIEd1aWxlID49IDIuMC4gQSBtaWNybwogIHZlcnNpb24gY2FuIGFsc28gYmUgc3Bl Y2lmaWVkIChlLmcuIEdVSUxFX1BST0dTKFsyLjAuMTBdKSkuCi0tLQogbWV0YS9ndWlsZS5tNCB8 IDQ0ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tCiAxIGZpbGUg Y2hhbmdlZCwgMzYgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9t ZXRhL2d1aWxlLm00IGIvbWV0YS9ndWlsZS5tNAppbmRleCBhM2UxZWYxLi4zMDRkZWE5IDEwMDY0 NAotLS0gYS9tZXRhL2d1aWxlLm00CisrKyBiL21ldGEvZ3VpbGUubTQKQEAgLTEsMTcgKzEsMTcg QEAKICMjIEF1dG9jb25mIG1hY3JvcyBmb3Igd29ya2luZyB3aXRoIEd1aWxlLgogIyMKLSMjICAg Q29weXJpZ2h0IChDKSAxOTk4LDIwMDEsIDIwMDYsIDIwMTAsIDIwMTIgRnJlZSBTb2Z0d2FyZSBG b3VuZGF0aW9uLCBJbmMuCisjIyAgIENvcHlyaWdodCAoQykgMTk5OCwyMDAxLCAyMDA2LCAyMDEw LCAyMDEyLCAyMDEzIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLgogIyMKICMjIFRoaXMg bGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IK ICMjIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQ dWJsaWMgTGljZW5zZQogIyMgYXMgcHVibGlzaGVkIGJ5IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5k YXRpb247IGVpdGhlciB2ZXJzaW9uIDMgb2YKICMjIHRoZSBMaWNlbnNlLCBvciAoYXQgeW91ciBv cHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgotIyMgCisjIwogIyMgVGhpcyBsaWJyYXJ5IGlzIGRp c3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCiAjIyBidXQgV0lU SE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgog IyMgTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAg U2VlIHRoZSBHTlUKICMjIExlc3NlciBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRl dGFpbHMuCi0jIyAKKyMjCiAjIyBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRo ZSBHTlUgTGVzc2VyIEdlbmVyYWwgUHVibGljCiAjIyBMaWNlbnNlIGFsb25nIHdpdGggdGhpcyBs aWJyYXJ5OyBpZiBub3QsIHdyaXRlIHRvIHRoZSBGcmVlIFNvZnR3YXJlCiAjIyBGb3VuZGF0aW9u LCBJbmMuLCA1MSBGcmFua2xpbiBTdHJlZXQsIEZpZnRoIEZsb29yLCBCb3N0b24sIE1BCkBAIC0x NzcsMTIgKzE3NywxNSBAQCBBQ19ERUZVTihbR1VJTEVfU0lURV9ESVJdLAogCiAjIEdVSUxFX1BS T0dTIC0tIHNldCBwYXRocyB0byBHdWlsZSBpbnRlcnByZXRlciwgY29uZmlnIGFuZCB0b29sIHBy b2dyYW1zCiAjCi0jIFVzYWdlOiBHVUlMRV9QUk9HUworIyBVc2FnZTogR1VJTEVfUFJPR1MoW1ZF UlNJT05dKQogIwogIyBUaGlzIG1hY3JvIGxvb2tzIGZvciBwcm9ncmFtcyBAY29kZXtndWlsZX0g YW5kIEBjb2Rle2d1aWxkfSwgc2V0dGluZwogIyB2YXJpYWJsZXMgQHZhcntHVUlMRX0gYW5kIEB2 YXJ7R1VJTER9IHRvIHRoZWlyIHBhdGhzLCByZXNwZWN0aXZlbHkuCiAjIElmIEBjb2Rle2d1aWxl fSBpcyBub3QgZm91bmQsIHNpZ25hbCBhbiBlcnJvci4KICMKKyMgQnkgZGVmYXVsdCwgdGhpcyBt YWNybyB3aWxsIHNlYXJjaCBmb3IgdGhlIGxhdGVzdCBzdGFibGUgdmVyc2lvbiBvZgorIyBHdWls ZSAoZS5nLiAyLjApLgorIwogIyBUaGUgZWZmZWN0aXZlIHZlcnNpb24gb2YgdGhlIGZvdW5kIEBj b2Rle2d1aWxlfSBpcyBzZXQgdG8KICMgQHZhcntHVUlMRV9FRkZFQ1RJVkVfVkVSU0lPTn0uICBU aGlzIG1hY3JvIGVuc3VyZXMgdGhhdCB0aGUgZWZmZWN0aXZlCiAjIHZlcnNpb24gaXMgY29tcGF0 aWJsZSB3aXRoIHRoZSByZXN1bHQgb2YgYSBwcmV2aW91cyBpbnZvY2F0aW9uIG9mCkBAIC0xOTUs MTcgKzE5OCw0MiBAQCBBQ19ERUZVTihbR1VJTEVfU0lURV9ESVJdLAogIwogQUNfREVGVU4oW0dV SUxFX1BST0dTXSwKICBbQUNfUEFUSF9QUk9HKEdVSUxFLGd1aWxlKQorICBfZ3VpbGVfcmVxdWly ZWRfdmVyc2lvbj0ibTRfZGVmYXVsdChbJDFdLCBbMi4wXSkiCiAgIGlmIHRlc3QgIiRHVUlMRSIg PSAiIiA7IHRoZW4KICAgICAgIEFDX01TR19FUlJPUihbZ3VpbGUgcmVxdWlyZWQgYnV0IG5vdCBm b3VuZF0pCiAgIGZpCiAgIEFDX1NVQlNUKEdVSUxFKQogCi0gIF9ndWlsZV9wcm9nX3ZlcnNpb249 YCRHVUlMRSAtYyAiKGRpc3BsYXkgKGVmZmVjdGl2ZS12ZXJzaW9uKSkiYAorICBfZ3VpbGVfZWZm ZWN0aXZlX3ZlcnNpb249YCRHVUlMRSAtYyAiKGRpc3BsYXkgKGVmZmVjdGl2ZS12ZXJzaW9uKSki YAogICBpZiB0ZXN0IC16ICIkR1VJTEVfRUZGRUNUSVZFX1ZFUlNJT04iOyB0aGVuCi0gICAgR1VJ TEVfRUZGRUNUSVZFX1ZFUlNJT049JF9ndWlsZV9wcm9nX3ZlcnNpb24KLSAgZWxpZiB0ZXN0ICIk R1VJTEVfRUZGRUNUSVZFX1ZFUlNJT04iICE9ICIkX2d1aWxlX3Byb2dfdmVyc2lvbiI7IHRoZW4K LSAgICBBQ19NU0dfRVJST1IoW2ZvdW5kIGRldmVsb3BtZW50IGZpbGVzIGZvciBHdWlsZSAkR1VJ TEVfRUZGRUNUSVZFX1ZFUlNJT04sIGJ1dCAkR1VJTEUgaGFzIGVmZmVjdGl2ZSB2ZXJzaW9uICRf Z3VpbGVfcHJvZ192ZXJzaW9uXSkKKyAgICBHVUlMRV9FRkZFQ1RJVkVfVkVSU0lPTj0kX2d1aWxl X2VmZmVjdGl2ZV92ZXJzaW9uCisgIGVsaWYgdGVzdCAiJEdVSUxFX0VGRkVDVElWRV9WRVJTSU9O IiAhPSAiJF9ndWlsZV9lZmZlY3RpdmVfdmVyc2lvbiI7IHRoZW4KKyAgICBBQ19NU0dfRVJST1Io W2ZvdW5kIGRldmVsb3BtZW50IGZpbGVzIGZvciBHdWlsZSAkR1VJTEVfRUZGRUNUSVZFX1ZFUlNJ T04sIGJ1dCAkR1VJTEUgaGFzIGVmZmVjdGl2ZSB2ZXJzaW9uICRfZ3VpbGVfZWZmZWN0aXZlX3Zl cnNpb25dKQorICBmaQorCisgIF9ndWlsZV9tYWpvcl92ZXJzaW9uPWAkR1VJTEUgLWMgIihkaXNw bGF5IChtYWpvci12ZXJzaW9uKSkiYAorICBfZ3VpbGVfbWlub3JfdmVyc2lvbj1gJEdVSUxFIC1j ICIoZGlzcGxheSAobWlub3ItdmVyc2lvbikpImAKKyAgX2d1aWxlX21pY3JvX3ZlcnNpb249YCRH VUlMRSAtYyAiKGRpc3BsYXkgKG1pY3JvLXZlcnNpb24pKSJgCisgIF9ndWlsZV9wcm9nX3ZlcnNp b249IiRfZ3VpbGVfbWFqb3JfdmVyc2lvbi4kX2d1aWxlX21pbm9yX3ZlcnNpb24uJF9ndWlsZV9t aWNyb192ZXJzaW9uIgorCisgIEFDX01TR19DSEVDS0lORyhbZm9yIEd1aWxlIHZlcnNpb24gPj0g JF9ndWlsZV9yZXF1aXJlZF92ZXJzaW9uXSkKKyAgX21ham9yX3ZlcnNpb249YGVjaG8gJF9ndWls ZV9yZXF1aXJlZF92ZXJzaW9uIHwgY3V0IC1kIC4gLWYgMWAKKyAgX21pbm9yX3ZlcnNpb249YGVj aG8gJF9ndWlsZV9yZXF1aXJlZF92ZXJzaW9uIHwgY3V0IC1kIC4gLWYgMmAKKyAgX21pY3JvX3Zl cnNpb249YGVjaG8gJF9ndWlsZV9yZXF1aXJlZF92ZXJzaW9uIHwgY3V0IC1kIC4gLWYgM2AKKyAg aWYgdGVzdCAiJF9ndWlsZV9tYWpvcl92ZXJzaW9uIiAtZ2UgIiRfbWFqb3JfdmVyc2lvbiI7IHRo ZW4KKyAgICBpZiB0ZXN0ICIkX2d1aWxlX21pbm9yX3ZlcnNpb24iIC1nZSAiJF9taW5vcl92ZXJz aW9uIjsgdGhlbgorICAgICAgaWYgdGVzdCAtbiAiJF9taWNyb192ZXJzaW9uIjsgdGhlbgorICAg ICAgICBpZiB0ZXN0ICIkX2d1aWxlX21pY3JvX3ZlcnNpb24iIC1sdCAiJF9taWNyb192ZXJzaW9u IjsgdGhlbgorICAgICAgICAgIEFDX01TR19FUlJPUihbR3VpbGUgJF9ndWlsZV9yZXF1aXJlZF92 ZXJzaW9uIHJlcXVpcmVkLCBidXQgJF9ndWlsZV9wcm9nX3ZlcnNpb24gZm91bmRdKQorICAgICAg ICBmaQorICAgICAgZmkKKyAgICBlbHNlCisgICAgICBBQ19NU0dfRVJST1IoW0d1aWxlICRfZ3Vp bGVfcmVxdWlyZWRfdmVyc2lvbiByZXF1aXJlZCwgYnV0ICRfZ3VpbGVfcHJvZ192ZXJzaW9uIGZv dW5kXSkKKyAgICBmaQorICBlbHNlCisgICAgQUNfTVNHX0VSUk9SKFtHdWlsZSAkX2d1aWxlX3Jl cXVpcmVkX3ZlcnNpb24gcmVxdWlyZWQsIGJ1dCAkX2d1aWxlX3Byb2dfdmVyc2lvbiBmb3VuZF0p CiAgIGZpCisgIEFDX01TR19SRVNVTFQoWyRfZ3VpbGVfcHJvZ192ZXJzaW9uXSkKIAogICBBQ19Q QVRIX1BST0coR1VJTEQsZ3VpbGQpCiAgIEFDX1NVQlNUKEdVSUxEKQotLSAKMS44LjQucmMzCgo= --089e013d14b218ca0c04e8ba400b--