From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Aleix_Conchillo_Flaqu=C3=A9?= Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] foreign-library: fix RTLD_LAZY | RTLD_LOCAL crash on macOS Date: Sun, 26 Sep 2021 21:45:08 -0700 Message-ID: References: <20210912051024.40841-1-aconchillo@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31758"; mail-complaints-to="usenet@ciao.gmane.io" To: guile-devel Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Mon Sep 27 06:45:44 2021 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mUiWO-00085V-MW for guile-devel@m.gmane-mx.org; Mon, 27 Sep 2021 06:45:44 +0200 Original-Received: from localhost ([::1]:50812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUiWM-0007Ug-PU for guile-devel@m.gmane-mx.org; Mon, 27 Sep 2021 00:45:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUiW4-0007SQ-Ei for guile-devel@gnu.org; Mon, 27 Sep 2021 00:45:24 -0400 Original-Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:43871) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUiW2-0006Ao-Ok for guile-devel@gnu.org; Mon, 27 Sep 2021 00:45:24 -0400 Original-Received: by mail-pf1-x42b.google.com with SMTP id c1so14615055pfp.10 for ; Sun, 26 Sep 2021 21:45:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=XAjb0XaxGccEOhL9PDwrHAaamAByWPNUHpjO7ISz7jA=; b=Z8DmCq26A9uiBQPHhoyUoNAt4ykYxVcXxgzbuAKATorZMY5TJe95L0yPNO43APtzH8 eYlJUUpIMM5Y88DCvFECWGOBXsPry/5O+2OmdZwh6S23DiAXglufMAVlfihikpcAFh5d sXvQurlD+H95UIy+K+cvtcGLE8CVVa4RwT76Uip6ZYcYNuftpyfMO0HlQ70dYhuGWZDS 7bCQ4fsHWKRgR1ujjyKxSIgo5mo7yMMx1DTNGgSWEo09wYHEjftBoBBuqCtNgF6wueBM gy1VmXmObsYs7H0Kz+3bCX/OiqWRZr22//T+/VQnNepGp8ix09lyBZ4r3uWwWGHqh7KF HwyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=XAjb0XaxGccEOhL9PDwrHAaamAByWPNUHpjO7ISz7jA=; b=yiife04PjMZ0trmJ9qEIqpQz4cbzQoN3uuHLr3NRuxgSDQxygTHCwKypthXl5Uttv1 a1AGLUBdHWRJf8A7tCTabKcPNDpsXOD8DovIGCVOFb0pmtbnso3bNUySCyOcFvqQPq9o EmmAE6j85PwoJZN+7v6hyHKq7ebSTrFPDylCrLREsl9SLUGJejA2a+JUPj44Ct+XNTN4 9udrlybQgFJ0W/IjrXqTotg1HlFrbKxkSjIeWeH7GBtYG/+1m2isJSCB/XimcAq6IhGO g/X1t/NyIEVRBgUYCmULAsYPwlBQ7gbMDHecCWcgfeqHxNR0rWbGzOrAsK6fk6xUELGf lo6Q== X-Gm-Message-State: AOAM532qoHiIGPFuFCoLKVRdEGFJgXlxUQwncaS8Nm62p1a/uOaE0uEV NwIpzSGzBXMrbGSDq+Dc8weL2hWXKK1QWIrSawyPbZ93PyI= X-Google-Smtp-Source: ABdhPJye2t2ozvSI3gCU+tLlEOIu1s2Naq4ZjMYnXE3DIKvKg/sg0x6hjX+/+sBLpOWOhlypc+eHlvgGyJFWgQXC4wc= X-Received: by 2002:a63:191a:: with SMTP id z26mr4196098pgl.373.1632717919322; Sun, 26 Sep 2021 21:45:19 -0700 (PDT) In-Reply-To: <20210912051024.40841-1-aconchillo@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=aconchillo@gmail.com; helo=mail-pf1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:20887 Archived-At: Ignore. The issue was the way libgcrypt was linked in macOS. See: https://dev.gnupg.org/T5610 A libgcrypt's libtool.m4 patch has been applied upstream. On Sat, Sep 11, 2021 at 10:10 PM Aleix Conchillo Flaqu=C3=A9 wrote: > > * module/system/foreign-library.scm (load-foreign-library): On macOS > calling `dlopen` with RTLD_LAZY | RTLD_LOCAL causes a crash when calling > `dlsym`. There are a three working combinations: > > - Using RTLD_NOW | RTLD_LOCAL > - Using RTLD_NOW | RTLD_GLOBAL > - Using RTLD_LAZY | RTLD_GLOBAL > > For efficiency purposes we choose RTLD_LAZY | RTLD_GLOBAL. > > See https://lists.gnu.org/archive/html/guile-devel/2021-09/msg00008.html > --- > module/system/foreign-library.scm | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/module/system/foreign-library.scm b/module/system/foreign-li= brary.scm > index dc426385f..63889277c 100644 > --- a/module/system/foreign-library.scm > +++ b/module/system/foreign-library.scm > @@ -172,6 +172,11 @@ name." > (else > name))))) > > +;; In macOS using dlopen with RTLD_LAZY | RTLD_LOCAL produces a crash. > +;; https://lists.gnu.org/archive/html/guile-devel/2021-09/msg00008.html > +(define system-needs-global? > + (string-contains %host-type "-darwin")) > + > (define* (load-foreign-library #:optional filename #:key > (extensions system-library-extensions) > (search-ltdl-library-path? #t) > @@ -186,7 +191,7 @@ name." > #f)) > (define flags > (logior (if lazy? RTLD_LAZY RTLD_NOW) > - (if global? RTLD_GLOBAL RTLD_LOCAL))) > + (if (or global? system-needs-global?) RTLD_GLOBAL RTLD_LOCAL= ))) > (define (dlopen* name) (dlopen name flags)) > (if (and rename-on-cygwin? (string-contains %host-type "cygwin")) > (set! filename (lib->cyg filename))) > -- > 2.33.0 >