From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Noah Lavine Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Add-native-hashtable-helper-functions Date: Tue, 26 Mar 2013 08:54:47 -0400 Message-ID: References: <1364294433.2730.2.camel@Renee-desktop.suse> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=e89a8ff1c77c560d4f04d8d36eb4 X-Trace: ger.gmane.org 1364302512 21224 80.91.229.3 (26 Mar 2013 12:55:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Mar 2013 12:55:12 +0000 (UTC) Cc: guile-devel To: Nala Ginrut Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Tue Mar 26 13:55:38 2013 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UKTPe-0006lU-9r for guile-devel@m.gmane.org; Tue, 26 Mar 2013 13:55:38 +0100 Original-Received: from localhost ([::1]:43485 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKTPG-0003Ii-FZ for guile-devel@m.gmane.org; Tue, 26 Mar 2013 08:55:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKTPC-0003HF-6S for guile-devel@gnu.org; Tue, 26 Mar 2013 08:55:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKTPA-0008S5-U7 for guile-devel@gnu.org; Tue, 26 Mar 2013 08:55:10 -0400 Original-Received: from mail-da0-x233.google.com ([2607:f8b0:400e:c00::233]:61907) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKTPA-0008Rn-OV for guile-devel@gnu.org; Tue, 26 Mar 2013 08:55:08 -0400 Original-Received: by mail-da0-f51.google.com with SMTP id g27so3542213dan.24 for ; Tue, 26 Mar 2013 05:55:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=KxUZavjPqSEsebfX1r0FrVQVZGdajgV7C1YMSumRY9U=; b=uAkT34hd5DXrJeaAPA7TydrbkY5DtEo4m1jkWcLgObS+erMCp3aJiEj3jeX/LiaIFg jY/O5N30NafqSM3PZgoqd04mpZNQadoS7VjhphqeO6L+A5HfjHmuy2ArYZXBK+tkKtTA S0AK2MoH9D5WRJ+rq44Qsg5w98BUv9HnvtGskdADQH3iFhOMU6MDLgvpoPRxSRjUVHcg J8Ct+omSTb/MWxS+6jIPJiEYGfa9I/WVUZUL7+vp1WG9hnLs3W9+BrmHWmrZmHXj40RS gy5aW4u18oaOEjbK4EwYBfCh7Te/6PbWQaY/QjoHw/Bfq8vmWEey8PmfbEPHMLkhwbZ7 PIIQ== X-Received: by 10.68.116.169 with SMTP id jx9mr22920874pbb.94.1364302507673; Tue, 26 Mar 2013 05:55:07 -0700 (PDT) Original-Received: by 10.68.157.42 with HTTP; Tue, 26 Mar 2013 05:54:47 -0700 (PDT) In-Reply-To: <1364294433.2730.2.camel@Renee-desktop.suse> X-Google-Sender-Auth: CWKmXfa7cmoUZYpSUKyOSdlD8kg X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c00::233 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:15999 Archived-At: --e89a8ff1c77c560d4f04d8d36eb4 Content-Type: text/plain; charset=ISO-8859-1 I would be afraid that without an entry in the manual, people won't know the functions exist, even if the docstrings are enough to explain what they do. Noah On Tue, Mar 26, 2013 at 6:40 AM, Nala Ginrut wrote: > Added three helper functions, they're so explicit that don't need any > docs in the manual I think. Docstring is enough. > > * hash-items: get the amount of items in the hash table > * hash-size: return the size of hash table > * hash-keys: return all the keys of hash table as a list > > Thanks! > --e89a8ff1c77c560d4f04d8d36eb4 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
I would be afraid that without an entry in the manual= , people won't know the functions exist, even if the docstrings are eno= ugh to explain what they do.

Noah


On Tue, Mar 26, 2013 at 6:40 AM, Nala Gi= nrut <nalaginrut@gmail.com> wrote:
Added three helper functions, they're so explicit that don't need a= ny
docs in the manual I think. Docstring is enough.

* hash-items: get the amount of items in the hash table
* hash-size: return the size of hash table
* hash-keys: return all the keys of hash table as a list

Thanks!

--e89a8ff1c77c560d4f04d8d36eb4--