[PATCH] Fix Ecmascript's tree-il compiling

[PATCH] Fix Ecmascript's tree-il compiling

[Nala Ginrut]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

Our inner Ecmascript(also named Javascript for a historical reason)
has broken for a long time since tree-il has been updated.
When I try to implement a small language with Guile, I found that
current parse-tree-il doesn't need a list as its arg anymore.
And I changed the same line in
language/ecmascript/compile-tree-il.scm, then it works again!
No matter how many people interested in the inner ecmascript there be,
I like it and I wish it enhance more.
Anyway, multi-language is an interesting feature for Guile.

Here's the patch.

[-- Attachment #2: 0001-Fix-ecmascript-compile-tree-il.patch --]
[-- Type: application/octet-stream, Size: 958 bytes --]

From 00b8f88444a62d040fc361922d0909b5d39780bc Mon Sep 17 00:00:00 2001
From: NalaGinrut <NalaGinrut@gmail.com>
Date: Sun, 29 Apr 2012 15:23:42 +0800
Subject: [PATCH] * Get rid of '->' because current parse-tree-il don't need a list as arg.
 modified:   module/language/ecmascript/compile-tree-il.scm

---
 module/language/ecmascript/compile-tree-il.scm |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/module/language/ecmascript/compile-tree-il.scm b/module/language/ecmascript/compile-tree-il.scm
index a2401f4..2532ad7 100644
--- a/module/language/ecmascript/compile-tree-il.scm
+++ b/module/language/ecmascript/compile-tree-il.scm
@@ -47,8 +47,8 @@
 (define (compile-tree-il exp env opts)
   (values
    (parse-tree-il
-    (-> (begin (@impl js-init)
-               (comp exp (empty-lexical-environment)))))
+     (begin (@impl js-init)
+               (comp exp (empty-lexical-environment))))
    env
    env))
 
-- 
1.7.0.4

Re: [PATCH] Fix Ecmascript's tree-il compiling

[Noah Lavine]

I checked that this is correct and committed it to stable-2.0.

You can make small bugfixes now, but if you want to make larger
contributions to Guile, you'll need to sign a copyright assignment
form. This is because in U.S. copyright law, the author of a
copyrighted work (like software) has the most ability to sue other
people to protect their copyright. The Free Software Foundation makes
sure it owns the copyright to all GNU software so that it will be able
to defend them in court. (See
http://www.gnu.org/licenses/why-assign.html for more information.) If
you want assign your copyright, please email assign@gnu.org.

Andy and Ludovic, I hope this is the right thing to do. If not, please
let me know.

Thanks,
Noah

On Sun, Apr 29, 2012 at 3:40 AM, Nala Ginrut <nalaginrut@gmail.com> wrote:
> Our inner Ecmascript(also named Javascript for a historical reason)
> has broken for a long time since tree-il has been updated.
> When I try to implement a small language with Guile, I found that
> current parse-tree-il doesn't need a list as its arg anymore.
> And I changed the same line in
> language/ecmascript/compile-tree-il.scm, then it works again!
> No matter how many people interested in the inner ecmascript there be,
> I like it and I wish it enhance more.
> Anyway, multi-language is an interesting feature for Guile.
>
> Here's the patch.

Re: [PATCH] Fix Ecmascript's tree-il compiling

[Nala Ginrut]

Hi Noah! Thanks for reply!
And I've sent a mail to assign@gnu.org for more information.
I'll let you know if I done that.

Regards


On Tue, May 1, 2012 at 12:17 AM, Noah Lavine <noah.b.lavine@gmail.com> wrote:
> I checked that this is correct and committed it to stable-2.0.
>
> You can make small bugfixes now, but if you want to make larger
> contributions to Guile, you'll need to sign a copyright assignment
> form. This is because in U.S. copyright law, the author of a
> copyrighted work (like software) has the most ability to sue other
> people to protect their copyright. The Free Software Foundation makes
> sure it owns the copyright to all GNU software so that it will be able
> to defend them in court. (See
> http://www.gnu.org/licenses/why-assign.html for more information.) If
> you want assign your copyright, please email assign@gnu.org.
>
> Andy and Ludovic, I hope this is the right thing to do. If not, please
> let me know.
>
> Thanks,
> Noah
>
> On Sun, Apr 29, 2012 at 3:40 AM, Nala Ginrut <nalaginrut@gmail.com> wrote:
>> Our inner Ecmascript(also named Javascript for a historical reason)
>> has broken for a long time since tree-il has been updated.
>> When I try to implement a small language with Guile, I found that
>> current parse-tree-il doesn't need a list as its arg anymore.
>> And I changed the same line in
>> language/ecmascript/compile-tree-il.scm, then it works again!
>> No matter how many people interested in the inner ecmascript there be,
>> I like it and I wish it enhance more.
>> Anyway, multi-language is an interesting feature for Guile.
>>
>> Here's the patch.

Re: [PATCH] Fix Ecmascript's tree-il compiling

[Ludovic Courtès]

Hi Noah,

Noah Lavine <noah.b.lavine@gmail.com> skribis:

> Andy and Ludovic, I hope this is the right thing to do. If not, please
> let me know.

It is, thanks for helping!

Ludo’.

Re: [PATCH] Fix Ecmascript's tree-il compiling

[Nala Ginrut]

I've already delivered it with post. Maybe takes 1-2 weeks.


On Thu, May 3, 2012 at 5:54 AM, Ludovic Courtès <ludo@gnu.org> wrote:
> Hi Noah,
>
> Noah Lavine <noah.b.lavine@gmail.com> skribis:
>
>> Andy and Ludovic, I hope this is the right thing to do. If not, please
>> let me know.
>
> It is, thanks for helping!
>
> Ludo’.
>
>

Re: [PATCH] Fix Ecmascript's tree-il compiling

[Nala Ginrut]

OK, I received a mail just now that they have acknowledged my assignment.

On Fri, May 4, 2012 at 5:15 PM, Nala Ginrut <nalaginrut@gmail.com> wrote:
> I've already delivered it with post. Maybe takes 1-2 weeks.
>
>
> On Thu, May 3, 2012 at 5:54 AM, Ludovic Courtès <ludo@gnu.org> wrote:
>> Hi Noah,
>>
>> Noah Lavine <noah.b.lavine@gmail.com> skribis:
>>
>>> Andy and Ludovic, I hope this is the right thing to do. If not, please
>>> let me know.
>>
>> It is, thanks for helping!
>>
>> Ludo’.
>>
>>