From: Noah Lavine <noah.b.lavine@gmail.com>
To: Andy Wingo <wingo@pobox.com>
Cc: guile-devel <guile-devel@gnu.org>
Subject: Re: Broken Backtraces, and Part of a Solution
Date: Wed, 18 Apr 2012 21:08:05 -0400 [thread overview]
Message-ID: <CA+U71=Mdm9Sc3R_+hB3kL-BRFHqmi3SX40uYOipg6gWBUuQfoQ@mail.gmail.com> (raw)
In-Reply-To: <87zka8y1y7.fsf@pobox.com>
On Wed, Apr 18, 2012 at 8:56 PM, Andy Wingo <wingo@pobox.com> wrote:
> On Wed 18 Apr 2012 17:02, Noah Lavine <noah.b.lavine@gmail.com> writes:
>
>> The problem is that narrow-stack->vector returns #(). It does this
>> because the stack is narrowed to nothing. The narrowing really happens
>> in the functions scm_make_stack and narrow_stack, in stacks.c.
>>
>> The reason it narrows to nothing is the third argument to
>> narrow-stack->vector, tag. On my Guile build, tag evaluates to
>> '("start-stack").
>
> Aaaaah. I was seeing something like this as well but I didn't figure
> out why. Thanks for tracking this down! The reason is that the type of
> make-prompt-tag changed, and the stack narrowing code didn't adapt
> accordingly. We need to change to default to consider generic objects
> as eq?-compared prompt tags.
I agree, but you still couldn't use procedures or integers as prompt
tags if you wanted make-stack to work, because those are special
cases. That's why I thought of just changing the interface to
make-stack to specify what you want - it's such a weird restriction
that someone could be bitten by it and have a lot of trouble tracking
it down. And because an argument can mean three different things, code
that uses make-stack is hard to understand (or at least it was for
me).
What do you think?
Noah
next prev parent reply other threads:[~2012-04-19 1:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 0:02 Broken Backtraces, and Part of a Solution Noah Lavine
2012-04-19 0:13 ` Noah Lavine
2012-04-19 0:56 ` Andy Wingo
2012-04-19 1:08 ` Noah Lavine [this message]
2012-04-19 1:36 ` Andy Wingo
2012-04-19 2:13 ` Noah Lavine
2012-04-20 2:47 ` Noah Lavine
2012-04-20 14:13 ` Andy Wingo
2012-04-22 10:53 ` Ludovic Courtès
2012-04-24 1:42 ` Noah Lavine
2012-04-24 16:58 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+U71=Mdm9Sc3R_+hB3kL-BRFHqmi3SX40uYOipg6gWBUuQfoQ@mail.gmail.com' \
--to=noah.b.lavine@gmail.com \
--cc=guile-devel@gnu.org \
--cc=wingo@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).