From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Noah Lavine Newsgroups: gmane.lisp.guile.devel Subject: Re: Two build problems Date: Wed, 19 Sep 2012 22:39:45 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: ger.gmane.org 1348110112 27714 80.91.229.3 (20 Sep 2012 03:01:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Sep 2012 03:01:52 +0000 (UTC) To: guile-devel Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Thu Sep 20 05:01:57 2012 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TEX1X-0000pI-0t for guile-devel@m.gmane.org; Thu, 20 Sep 2012 05:01:55 +0200 Original-Received: from localhost ([::1]:39507 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEX1S-0002YP-9O for guile-devel@m.gmane.org; Wed, 19 Sep 2012 23:01:50 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEX1N-0002V2-78 for guile-devel@gnu.org; Wed, 19 Sep 2012 23:01:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TEWy6-0007Yq-JZ for guile-devel@gnu.org; Wed, 19 Sep 2012 22:58:36 -0400 Original-Received: from mail-ob0-f169.google.com ([209.85.214.169]:42960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEWg8-0001rr-A3 for guile-devel@gnu.org; Wed, 19 Sep 2012 22:39:53 -0400 Original-Received: by obhx4 with SMTP id x4so1863442obh.0 for ; Wed, 19 Sep 2012 19:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=8H7mP5Ga/p2PT+FBXSGI3yRG7yKpspo0/qNxMyFyb/4=; b=Jhfa9UejmgkfjgSYG4qvapps9RJDhH7ghP1GWGaRl1o7/fQp6OArbl6uyADtCoa9cm Gn9q2X/8Wp6vSGq/bM3s8T4f32u32gR4dLqlRGF6F0d33PjSlFjT2S1exVyYAM2gO3lt qsgCBTGtT4tM/47jxU/ZPjBVL5jhcslIwcJzcoN2DPzqSs7wukcdjZIS/HxFxvG1H+EQ GZrEbm53Zjl545bjtzieTnSSRTLGfzAFxAv/yCDyYS6yajwrS5wPS3Oo6dMSaZ+E7Pvz hx2QMu+tVqFmCGrMyVqfkS40TC1tBE8sJ1f6vtk+1cdba7V5N7ZyrIx/CqTrpbkQF2qo DgMw== Original-Received: by 10.182.131.98 with SMTP id ol2mr248951obb.69.1348108785849; Wed, 19 Sep 2012 19:39:45 -0700 (PDT) Original-Received: by 10.76.167.197 with HTTP; Wed, 19 Sep 2012 19:39:45 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: 8Ff_M6HS0qcgSHgnApPLu84v9Jg X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.214.169 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:14904 Archived-At: I have found the cause of the second problem, but I'm not sure what to do about it. Here's what's happening: libguile/bytevectors.c includes . uniconv.h lives in my system include directory (~/.nix-profile/include, actually). It includes a file called "unitypes.h". That refers to ~/.nix-profile/include/unitypes.h, which does the usual #ifdef UNITYPES_H ... #endif trick to avoid being included more than once. But then on the next line, libguile/bytevectors.c includes . That refers to lib/unistr.h, not the system unistr.h. lib/unistr.h also includes "unitypes.h", but the version of unitypes.h in lib/ is different than my system version. However, the version of unitypes.h in lib/ is never used, because it also has a #ifdef UNITYPES_H ... #endif wrapper. So lib/unistr.h doesn't get some #defines it needs, which causes a build failure. So that's the issue. What is the correct solution? Thanks a lot, Noah On Sat, Sep 15, 2012 at 2:40 PM, Noah Lavine wrote: > Hello, > > I hit two errors while building recent Guile, one of which I have diagnosed. > > First problem: > > At first, I couldn't build lib/striconveh.c. Here's what I think was > wrong: Make doesn't know that lib/striconveh.c depends on > lib/unitypes.h. This is a problem because lib/unitypes.h is generated > from lib/unitypes.in.h, but because Make doesn't know about the > dependency, it doesn't bother to generate lib/unitypes.h before > building striconveh.c, thus generating an error. > > Here's some evidence that this is true: when I manually make > lib/unitypes.h and then make Guile the regular way, the build > succeeds. (I actually decided this by manually following the includes > and noticing that lib/unitypes.h doesn't exist, then looking in the > Makefile to find out why.) > > I'm not quite sure what the right fix is, for two reasons. First of > all, the dependency isn't direct - lib/striconveh.c includes > lib/unistr.h, which then includes lib/unitypes.h. So maybe > lib/unistr.h should depend on lib/unitypes.h, and striconveh.c > shouldn't be directly involved. Second, I believe lib/ actually comes > from gnulib, and I don't know how that's organized. So I don't know if > this is a Guile bug or a gnulib bug. > > Second problem: > > Since I could fix the first one by hand, I decided to go ahead and > build Guile. That's when I discovered that even though lib/unitypes.h > exists, it's not being included by lib/unistr.h when building files in > the libguile/ directory (even though it works fine when building > things in the lib/ directory). Therefore, an include path is messed up > somewhere. > > lib/unistr.h says this: #include "unitypes.h". > > But when I try to build bytevectors.c, I get lots of errors from > lib/unistr.h that seem to be based on a lack of macros from > lib/unitypes.h. As an experiment, I added the line "#error" to > lib/unitypes.h. As expected, the preprocessor and compiler didn't > compain about it, which I think means that they're never looking in > lib/unitypes.h when building libguile/bytevectors.c. This is a > problem. > > Unfortunately, I don't know how to fix this one. Defining the macro > INCLUDES in libguile/Makefile to -I../lib:./lib doesn't seem to help. > > Thanks, > Noah