From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Matt Wette Newsgroups: gmane.lisp.guile.devel Subject: Re: GNU Guile 2.1.6 released (beta) [numbers.c] Date: Sat, 28 Jan 2017 11:29:19 -0800 Message-ID: References: <87tw8v7pjz.fsf@pobox.com> <49954F94-8294-4339-9276-10793DEBAC6D@gmail.com> <6DD4E83E-6A96-4CBE-8FCE-8D74DFBD3E85@gmail.com> <12669E32-5B1B-4FF7-9951-A15A8416013B@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_202D136E-C429-4C9F-9B5A-E22843E46A8A" X-Trace: blaine.gmane.org 1485631793 29105 195.159.176.226 (28 Jan 2017 19:29:53 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 28 Jan 2017 19:29:53 +0000 (UTC) Cc: Andy Wingo To: guile-devel Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sat Jan 28 20:29:46 2017 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXYgt-0006Vz-E6 for guile-devel@m.gmane.org; Sat, 28 Jan 2017 20:29:39 +0100 Original-Received: from localhost ([::1]:52910 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXYgy-0006x1-K1 for guile-devel@m.gmane.org; Sat, 28 Jan 2017 14:29:44 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXYgr-0006v7-El for guile-devel@gnu.org; Sat, 28 Jan 2017 14:29:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXYgn-0003jc-H6 for guile-devel@gnu.org; Sat, 28 Jan 2017 14:29:37 -0500 Original-Received: from mail-pg0-x229.google.com ([2607:f8b0:400e:c05::229]:33669) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXYgn-0003f7-8J for guile-devel@gnu.org; Sat, 28 Jan 2017 14:29:33 -0500 Original-Received: by mail-pg0-x229.google.com with SMTP id 204so90247382pge.0 for ; Sat, 28 Jan 2017 11:29:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=hQxfI56inYQ9PHyaVA2BwQUnpQtQGvoo1ZaKjYGr2C4=; b=iCbJ/i/K6CQc8RNMCbzmxDqbnHl0iTbBhlaOfdEF6coLOxhC/GOP0Zw8pDr79kVAzp lPIUVKKhZJlADlhjKy+c+MA/XOyW4i7ETVGvc5P3AhVGoAi2drafWh1o18ltgyZHaSPs DEivvTuWIxtGL3Bb2ECkJznWM7+y4h3XqIIS5VOrmNAPu9izqPAJB4C9d/BY/ONpnOt0 RF8clugxPbIGfVnIQEMCRtPiAxB0TDZOoQcJoFJbaLHsCEJltvW9w5aI0pIPBUgWIQvs zpxz92H1Enby/TwXxWfgdCLF8rYmR6Wbp2KdMMXML59YoCgZJUNwRgm/8AXHi+5Dk2MH cjzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=hQxfI56inYQ9PHyaVA2BwQUnpQtQGvoo1ZaKjYGr2C4=; b=YKLW3fkMrPjtUk0Y0wUsanRPvoLHB3aqaCq9eAaVRiU61q4lmE0+A2iCGp6xwB9b2N vkc/u4SZorxgfd8QsRRdp3ZKylRrBbQoaWOAGD/umEJtfQ/XVZZlrnvBrM/3vjEVmSs7 WR3v2mqTIzq4W/TDXAZDzXbmc5e1LDvIvh2vgppl0PqaHf9Y+aEzSBd074LsQ5Sh6woQ g42Thi6QET3IXv0HlginRUbwApJTzRS3WPTqwXlNWtPpqyK0mASTxYcprHNxM/+uN4RN hYiVog4DInvKcRgVBP74/O2bRTRRGKJg8RVSAeqRvEI1M+1sAmUV+AfhCZ82LEViMWhA uE+g== X-Gm-Message-State: AIkVDXK/LBYAaQRNshpLqivplNocT9Srsno3Vj+5KCVmnfcGaroCTN3Utx+aQm5DyUAc6w== X-Received: by 10.99.114.91 with SMTP id c27mr16024368pgn.163.1485631768582; Sat, 28 Jan 2017 11:29:28 -0800 (PST) Original-Received: from nautilus.championbroadband.com (216-165-246-244.championbroadband.com. [216.165.246.244]) by smtp.gmail.com with ESMTPSA id n73sm20715858pfa.9.2017.01.28.11.29.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Jan 2017 11:29:22 -0800 (PST) In-Reply-To: <12669E32-5B1B-4FF7-9951-A15A8416013B@gmail.com> X-Mailer: Apple Mail (2.3259) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c05::229 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.org gmane.lisp.guile.devel:18872 Archived-At: --Apple-Mail=_202D136E-C429-4C9F-9B5A-E22843E46A8A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jan 20, 2017, at 12:23 PM, Matt Wette wrote: >=20 >>=20 >> On Jan 20, 2017, at 11:01 AM, Matt Wette > wrote: >>=20 >>>=20 >>> On Jan 19, 2017, at 7:01 PM, Matt Wette > wrote: >>>=20 >>>=20 >>>> On Jan 18, 2017, at 6:26 PM, Andy Wingo > wrote: >>>>=20 >>>> We are pleased to announce GNU Guile release 2.1.6. >>>>=20 >>>> Guile 2.1.6 is the sixth pre-release in what will eventually become = the >>>> 2.2 release series. We encourage you to test this release and = provide >>>> feedback to guile-devel@gnu.org . >>>=20 >>> Saw this one last round. Mac OS, now gcc-6.3.0: >>>=20 >>> ;;; ("#i1@-0" 1.0 -0.0) >>> FAIL: numbers.test: string->number: valid complex number strings >>>=20 >>> I am going to see if I can generate the assembly. >>=20 >> Short story: scm_c_make_polar is broken for the Mac. Guile needs to = decide if it want to use __sincos() on Mac, or suppress optimization, or = ... >>=20 >=20 Attached is another patch. This one adds check for __sincos() to = configure.am, configure and #ifdef to numbers.c to use __sincos() on the = Mac. I don=E2=80=99t know if __APPLE__ is required anymore or not. Matt --Apple-Mail=_202D136E-C429-4C9F-9B5A-E22843E46A8A Content-Type: multipart/mixed; boundary="Apple-Mail=_227923A7-10A0-4B78-BE61-0E052EEEAE02" --Apple-Mail=_227923A7-10A0-4B78-BE61-0E052EEEAE02 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
On Jan 20, 2017, at 12:23 PM, Matt Wette <matt.wette@gmail.com> wrote:


On = Jan 20, 2017, at 11:01 AM, Matt Wette <matt.wette@gmail.com> wrote:


On Jan 19, 2017, at = 7:01 PM, Matt Wette <matt.wette@gmail.com> wrote:


On Jan = 18, 2017, at 6:26 PM, Andy Wingo <wingo@pobox.com> wrote:

We = are pleased to announce GNU Guile release 2.1.6.

Guile 2.1.6 is the sixth pre-release in what will eventually = become the
2.2 release series.  We encourage you to = test this release and provide
feedback to guile-devel@gnu.org.

Saw this one last round.  Mac OS, now = gcc-6.3.0:

;;; = ("#i1@-0" 1.0 -0.0)
FAIL: = numbers.test: string->number: valid complex number = strings

I am going to see = if I can generate the = assembly.

Short story: scm_c_make_polar is broken for the Mac. =  Guile needs to decide if it want to use __sincos() on Mac, or = suppress optimization, or ...



Attached = is another patch.  This one adds check for __sincos() to = configure.am, configure and #ifdef to numbers.c to use __sincos() on the = Mac.  I don=E2=80=99t know if __APPLE__ is required anymore or = not.

Matt
= --Apple-Mail=_227923A7-10A0-4B78-BE61-0E052EEEAE02 Content-Disposition: attachment; filename=patch.__sincos Content-Type: application/octet-stream; x-unix-mode=0644; name="patch.__sincos" Content-Transfer-Encoding: 7bit --- libguile/numbers.c-orig 2017-01-27 16:44:27.000000000 -0800 +++ libguile/numbers.c 2017-01-27 16:47:49.000000000 -0800 @@ -9109,6 +9109,8 @@ details. */ #if (defined HAVE_SINCOS) && (defined __GLIBC__) && (defined _GNU_SOURCE) sincos (ang, &s, &c); +#elif (defined HAVE___SINCOS) && (defined __APPLE__) + __sincos (ang, &s, &c); #else s = sin (ang); c = cos (ang); @@ -9951,7 +9953,7 @@ long n_size = scm_to_long (scm_integer_length (n)); long d_size = scm_to_long (scm_integer_length (d)); - if (abs (n_size - d_size) > 1) + if (labs (n_size - d_size) > 1) return (scm_difference (log_of_exact_integer (n), log_of_exact_integer (d))); else if (scm_is_false (scm_negative_p (n))) --- configure.ac-orig 2017-01-27 16:42:08.000000000 -0800 +++ configure.ac 2017-01-27 16:42:45.000000000 -0800 @@ -1152,8 +1152,9 @@ # asinh, acosh, atanh, trunc - C99 standard, generally not available on # older systems # sincos - GLIBC extension +# __sincos - APPLE extension # -AC_CHECK_FUNCS(asinh acosh atanh copysign finite sincos trunc) +AC_CHECK_FUNCS(asinh acosh atanh copysign finite sincos __sincos trunc) # C99 specifies isinf and isnan as macros. # HP-UX provides only macros, no functions. --- configure-orig 2017-01-27 16:42:14.000000000 -0800 +++ configure 2017-01-27 16:56:43.000000000 -0800 @@ -52786,8 +52786,9 @@ # asinh, acosh, atanh, trunc - C99 standard, generally not available on # older systems # sincos - GLIBC extension +# __sincos - APPLE extension # -for ac_func in asinh acosh atanh copysign finite sincos trunc +for ac_func in asinh acosh atanh copysign finite sincos __sincos trunc do : as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh` ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var" --Apple-Mail=_227923A7-10A0-4B78-BE61-0E052EEEAE02 Content-Transfer-Encoding: 7bit Content-Type: text/html; charset=us-ascii

--Apple-Mail=_227923A7-10A0-4B78-BE61-0E052EEEAE02-- --Apple-Mail=_202D136E-C429-4C9F-9B5A-E22843E46A8A--