unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
* [PATCH] Documentation typo fix
@ 2022-02-15 22:40 Vijay Marupudi
  2022-02-24  7:26 ` Arun Isaac
  2022-02-24 17:56 ` lloda
  0 siblings, 2 replies; 6+ messages in thread
From: Vijay Marupudi @ 2022-02-15 22:40 UTC (permalink / raw)
  To: guile-devel

[-- Attachment #1: Type: text/plain, Size: 111 bytes --]

Hello!

I have attached a patch that fixes the simple example of defining (unless
...) with a macro.

~ Vijay


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Typo-fix-Use-correct-variable-name-in-example.patch --]
[-- Type: text/x-patch, Size: 792 bytes --]

From 42c830b3d14106d18df154d9a34fff2a9ffa532e Mon Sep 17 00:00:00 2001
From: Vijay Marupudi <vijay@vijaymarupudi.com>
Date: Tue, 15 Feb 2022 17:36:08 -0500
Subject: [PATCH] Typo fix: Use correct variable name in example

* doc/ref/api-control.texi
---
 doc/ref/api-control.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/ref/api-control.texi b/doc/ref/api-control.texi
index 9860457fa..88dea5623 100644
--- a/doc/ref/api-control.texi
+++ b/doc/ref/api-control.texi
@@ -154,7 +154,7 @@ documentation:
 (define-syntax-rule (when test stmt stmt* ...)
   (if test (begin stmt stmt* ...)))
 
-(define-syntax-rule (unless condition stmt stmt* ...)
+(define-syntax-rule (unless test stmt stmt* ...)
   (if (not test) (begin stmt stmt* ...)))
 @end example
 
-- 
2.35.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Documentation typo fix
  2022-02-15 22:40 [PATCH] Documentation typo fix Vijay Marupudi
@ 2022-02-24  7:26 ` Arun Isaac
  2022-02-24 13:47   ` Vijay Marupudi
  2022-02-24 20:23   ` Aleix Conchillo Flaqué
  2022-02-24 17:56 ` lloda
  1 sibling, 2 replies; 6+ messages in thread
From: Arun Isaac @ 2022-02-24  7:26 UTC (permalink / raw)
  To: Vijay Marupudi, guile-devel

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]


Hi Vijay,

Could you send this patch to bug-guile@gnu.org? That way it gets
registered in the bug tracker, and a maintainer can apply it when they
are able to.

Thanks,
Arun

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Documentation typo fix
  2022-02-24  7:26 ` Arun Isaac
@ 2022-02-24 13:47   ` Vijay Marupudi
  2022-02-24 20:23   ` Aleix Conchillo Flaqué
  1 sibling, 0 replies; 6+ messages in thread
From: Vijay Marupudi @ 2022-02-24 13:47 UTC (permalink / raw)
  To: Arun Isaac, guile-devel


> Could you send this patch to bug-guile@gnu.org? That way it gets
> registered in the bug tracker, and a maintainer can apply it when they
> are able to.

Looks like the typo fix patch was committed to main by lloda, thanks! I
have sent the rest of my patches to bug-guile, I wasn't aware of the
convention, thanks Arun!

~ Vijay



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Documentation typo fix
  2022-02-15 22:40 [PATCH] Documentation typo fix Vijay Marupudi
  2022-02-24  7:26 ` Arun Isaac
@ 2022-02-24 17:56 ` lloda
  1 sibling, 0 replies; 6+ messages in thread
From: lloda @ 2022-02-24 17:56 UTC (permalink / raw)
  To: Vijay Marupudi; +Cc: guile-devel


Applied in 68aeffe8dda02ae3248a9fc035cea73384ee7b6c. Thanks!

> On 15 Feb 2022, at 23:40, Vijay Marupudi <vijay@vijaymarupudi.com> wrote:
> 
> Hello!
> 
> I have attached a patch that fixes the simple example of defining (unless
> ...) with a macro.
> 
> ~ Vijay
> 
> From 42c830b3d14106d18df154d9a34fff2a9ffa532e Mon Sep 17 00:00:00 2001
> From: Vijay Marupudi <vijay@vijaymarupudi.com>
> Date: Tue, 15 Feb 2022 17:36:08 -0500
> Subject: [PATCH] Typo fix: Use correct variable name in example
> 
> * doc/ref/api-control.texi
> ---
> doc/ref/api-control.texi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/ref/api-control.texi b/doc/ref/api-control.texi
> index 9860457fa..88dea5623 100644
> --- a/doc/ref/api-control.texi
> +++ b/doc/ref/api-control.texi
> @@ -154,7 +154,7 @@ documentation:
> (define-syntax-rule (when test stmt stmt* ...)
>   (if test (begin stmt stmt* ...)))
> 
> -(define-syntax-rule (unless condition stmt stmt* ...)
> +(define-syntax-rule (unless test stmt stmt* ...)
>   (if (not test) (begin stmt stmt* ...)))
> @end example
> 
> -- 
> 2.35.1
> 




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Documentation typo fix
  2022-02-24  7:26 ` Arun Isaac
  2022-02-24 13:47   ` Vijay Marupudi
@ 2022-02-24 20:23   ` Aleix Conchillo Flaqué
  2022-02-25  5:50     ` Arun Isaac
  1 sibling, 1 reply; 6+ messages in thread
From: Aleix Conchillo Flaqué @ 2022-02-24 20:23 UTC (permalink / raw)
  To: Arun Isaac; +Cc: guile-devel, Vijay Marupudi

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

On Wed, Feb 23, 2022 at 11:27 PM Arun Isaac <arunisaac@systemreboot.net>
wrote:

>
> Hi Vijay,
>
> Could you send this patch to bug-guile@gnu.org? That way it gets
> registered in the bug tracker, and a maintainer can apply it when they
> are able to.
>
>
Does this apply to bug fixes or also changes?

Best,

Aleix

[-- Attachment #2: Type: text/html, Size: 1212 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Documentation typo fix
  2022-02-24 20:23   ` Aleix Conchillo Flaqué
@ 2022-02-25  5:50     ` Arun Isaac
  0 siblings, 0 replies; 6+ messages in thread
From: Arun Isaac @ 2022-02-25  5:50 UTC (permalink / raw)
  To: Aleix Conchillo Flaqué; +Cc: guile-devel, Vijay Marupudi

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]


Hi Aleix,

> Does this apply to bug fixes or also changes?

I am not a maintainer and don't know for sure, but I think it applies to
all changes. Patches tend to get lost in the mailing list unless the
maintainers apply it immediately.

Regards,
Arun

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-02-25  5:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-15 22:40 [PATCH] Documentation typo fix Vijay Marupudi
2022-02-24  7:26 ` Arun Isaac
2022-02-24 13:47   ` Vijay Marupudi
2022-02-24 20:23   ` Aleix Conchillo Flaqué
2022-02-25  5:50     ` Arun Isaac
2022-02-24 17:56 ` lloda

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).