From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Matt Wette Newsgroups: gmane.lisp.guile.devel Subject: Re: GNU Guile 2.1.5 released (beta) Date: Thu, 29 Dec 2016 11:38:40 -0800 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1483040359 28821 195.159.176.226 (29 Dec 2016 19:39:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 29 Dec 2016 19:39:19 +0000 (UTC) Cc: Andy Wingo , Daniel Llorens To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Thu Dec 29 20:39:15 2016 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cMgXf-0006V9-HE for guile-devel@m.gmane.org; Thu, 29 Dec 2016 20:39:11 +0100 Original-Received: from localhost ([::1]:37047 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMgXk-00048U-Cl for guile-devel@m.gmane.org; Thu, 29 Dec 2016 14:39:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42662) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMgXJ-00047M-N0 for guile-devel@gnu.org; Thu, 29 Dec 2016 14:38:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cMgXG-00080R-K5 for guile-devel@gnu.org; Thu, 29 Dec 2016 14:38:49 -0500 Original-Received: from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241]:35552) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cMgXG-0007zl-F7 for guile-devel@gnu.org; Thu, 29 Dec 2016 14:38:46 -0500 Original-Received: by mail-pg0-x241.google.com with SMTP id i5so19779353pgh.2 for ; Thu, 29 Dec 2016 11:38:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=bsJShD7je5V7my8uoOsxWsTzXF1qBtlBn5cX2RAk3vY=; b=gBKnZsy/dchtBM2B9ZcmsyGx5A6I+n6uQP7hdXju3SOdHX+Jx24VgtYFV/jhNFuD/D kPnMcITzlwURU/IBLiFcQo3M3n4ERR1qDft9yb/mRdYXCb7qLUqGinJHComMFIrGDN6b 8JeQAHY70weYVMzEc0FxYy5PbPcoGHRuRPU3lNKctd/ePqErK12Kd/Ra08MIuHXKMUq/ dZuS+0Ooq7jVo1i0BxmUYrW8TrsRlA3Wr1agl5jg9b4PYQakYFtCaN8Eb8qO8ej8aCfO 6l1gqjVMahVXFvKWWKCh8zi7f6X6gvjG72ZT9NcLVHr+93pkbmo7l7L1LpQBDUD2RWoX 2lfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=bsJShD7je5V7my8uoOsxWsTzXF1qBtlBn5cX2RAk3vY=; b=f80j8jmFwMuc152wPgfWpW4wzWPuoxJStYbHr2GrXnREhznEQQ4uycq/Nwp0B/ix4d S8Bep2qvgrWzdMJePKEQJ+glY+N3TbsLyKzWMfAPtQg2hB8Wdug0VOxRnoT38OeUGvv+ XIPe237By6RGey6x9v+wxoOJ4T0eRimj6ElNiVCf9kSltko6leh/fzygIyAcoGnVej5o OrhGJZfZHECqPriUEz45vCOT76NEIB+DtURZzcXBaumIONSXIJ1TeZGLztt1aPD8eML4 xkLnWILKm+IEwWEJAOAqOtY3iIzbygPbMe1A74IO9v0wCUn9LP3GWwHSQKkgIN5HxRC3 P/yQ== X-Gm-Message-State: AIkVDXJ7vV1YgYw850+MwZJQWr6FmpXRz+AOOycUiHwYMagpZHHXGYXOqdZQuhSVEKAujw== X-Received: by 10.98.78.88 with SMTP id c85mr40619887pfb.138.1483040323740; Thu, 29 Dec 2016 11:38:43 -0800 (PST) Original-Received: from nautilus.championbroadband.com (216-165-246-244.championbroadband.com. [216.165.246.244]) by smtp.gmail.com with ESMTPSA id 24sm106808932pfh.41.2016.12.29.11.38.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Dec 2016 11:38:42 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3259) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c05::241 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.org gmane.lisp.guile.devel:18811 Archived-At: > On Dec 10, 2016, at 4:42 PM, Matt Wette wrote: >=20 > On Dec 10, 2016, at 9:11 AM, Daniel Llorens = wrote: >>=20 >>=20 >>>> Make check is failing on test-language, so I will be chasing that = down. >>=20 >>=20 >> FWIW this is the only test that fails on 10.9.5 and the backtrace = looks identical too. >=20 > The problem appears in libguile/loader.c, alloc_aligned(). Check the = value of =E2=80=9Cret=E2=80=9D I get after malloc and after the = alignment. I started looking at type size for uintptr_t vs char* but = then got confused why guile is being compiled as x86_64, but my test = programs are always x86 >=20 > alignment=3D4096 >=20 > /* This function leaks the memory that it allocates. */ > static char* > alloc_aligned (size_t len, unsigned alignment) > { > char *ret; >=20 > if (alignment =3D=3D 8) > { > /* FIXME: Assert that we actually have an 8-byte-aligned malloc. = */ > ret =3D malloc (len); > } > #if defined(HAVE_SYS_MMAN_H) && defined(MMAP_ANONYMOUS) > else if (alignment =3D=3D SCM_PAGE_SIZE) > { > ret =3D mmap (NULL, len, PROT_READ | PROT_WRITE, -1, 0); > if (ret =3D=3D MAP_FAILED) > SCM_SYSERROR; > } > #endif > else > { > if (len + alignment < len) > abort (); >=20 > ret =3D malloc (len + alignment - 1); > ret=3D0x0000000104000000 > if (!ret) > abort (); > ret =3D (char *) ALIGN ((scm_t_uintptr) ret, alignment); > ret=3D0x0000000004000000 > } >=20 > return ret; > } I posted a fix for this but wanted to respond in this thread. I added = =E2=80=9C(scm_t_uintptr)=E2=80=9D cast before the argument = =E2=80=9Calignment=E2=80=9D to ALIGN. Also, should MMAP_ANONYMOUS be = HAVE_MAP_ANONYMOUS ???