unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Matt Wette <matthew.wette@verizon.net>
To: Mark H Weaver <mhw@netris.org>
Cc: "Ludovic Courtès" <ludo@gnu.org>, guile-devel@gnu.org
Subject: Re: [PATCH] ice-9: Add JSON module.
Date: Tue, 22 Sep 2015 05:43:20 -0700	[thread overview]
Message-ID: <AFED8660-DAF4-4C7E-9825-52BB5B42B562@verizon.net> (raw)
In-Reply-To: <87h9mneyny.fsf@netris.org>

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]


> On Sep 21, 2015, at 11:49 PM, Mark H Weaver <mhw@netris.org> wrote:
> 
>> 2. The comments say integers are converted to exact and floating point
>> to inexact, but the code will convert 1.0 to exact.
> 
> In Scheme terminology, 1.0 is an integer.

But in guile-2.0.11:

scheme@(guile-user)> (exact? (string->number "1.0"))
$1 = #f

I also vote for using string->number: probably faster and more heavily tested.

Matt


[-- Attachment #2: Type: text/html, Size: 2907 bytes --]

  reply	other threads:[~2015-09-22 12:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-15 21:21 [PATCH] ice-9: Add JSON module David Thompson
2015-08-16  1:33 ` David Thompson
2015-08-17 15:10   ` Christopher Allan Webber
2015-09-21 20:08 ` Ludovic Courtès
2015-09-22  1:31   ` Matt Wette
2015-09-22  6:49     ` Mark H Weaver
2015-09-22 12:43       ` Matt Wette [this message]
2015-09-22  6:46 ` Mark H Weaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AFED8660-DAF4-4C7E-9825-52BB5B42B562@verizon.net \
    --to=matthew.wette@verizon.net \
    --cc=guile-devel@gnu.org \
    --cc=ludo@gnu.org \
    --cc=mhw@netris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).