[PATCH 1/2] Fix struct ip_mreq detection

[PATCH 1/2] Fix struct ip_mreq detection

[Tristan Colgate]

Probably not the ideal fix, I tried using AC_CHECK_TYPE and adding
netinet/in.h but it didn't work. I've just copied the approach used
for LINGER

-- 
Tristan Colgate-McFarlane
----
  "You can get all your daily vitamins from 52 pints of guiness, and a
glass of milk"

 configure.ac |   17 ++++++++++++++++-
 1 files changed, 16 insertions(+), 1 deletions(-)

diff --git a/configure.ac b/configure.ac
index 34ec603..ec82791 100644
--- a/configure.ac
+++ b/configure.ac
@@ -673,7 +673,22 @@ AC_CHECK_TYPE(socklen_t, ,
 #endif
 #include <sys/socket.h>
 ])
-AC_CHECK_TYPE(struct ip_mreq)
+
+AC_MSG_CHECKING(for struct ip_mreq)
+AC_CACHE_VAL(scm_cv_struct_ip_mreq,
+        AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
+#include <sys/types.h>
+#include <sys/socket.h>
+#include <netinet/in.h>]],
+                          [[struct ip_mreq req;]])],
+                          [scm_cv_struct_ip_mreq="yes"],
+                          [scm_cv_struct_ip_mreq="no"]))
+AC_MSG_RESULT($scm_cv_struct_ip_mreq)
+if test $scm_cv_struct_ip_mreq = yes; then
+        AC_DEFINE([HAVE_STRUCT_IP_MREQ], 1,
+          [Define this if your system defines struct ip_mreq, for use with the
+          setsockopt system call.])
+fi

 GUILE_HEADER_LIBC_WITH_UNISTD

-- 
1.7.2.3

Re: [PATCH 1/2] Fix struct ip_mreq detection

[Andy Wingo]

Hi Tristan,

Under what conditions did this work or not work before?

Can you resubmit this patch and the next one with the commit log looking
like other commit logs in Guile?

When you do, please attach the output of git-format-patch instead of
sending it as-is; for some reason piping your message to git-am added
your sig to the commit log.

If you plan on making bigger patches in the future, it's probably a good
idea to get paperwork going with the FSF. If this is the case, reply
privately and I will send you details.

Thanks for the patches,

Andy
-- 
http://wingolog.org/

Re: [PATCH 1/2] Fix struct ip_mreq detection

[Andy Wingo]

Hi,

[adding list cc]

On Wed 20 Oct 2010 10:40, Tristan Colgate <tcolgate@gmail.com> writes:

> Are these OK?

Applied, thanks :-)

Andy
-- 
http://wingolog.org/