From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: No Itisnt Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Allow printing of malformed tree-il Date: Fri, 9 Jul 2010 01:23:36 -0500 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: dough.gmane.org 1278656634 23622 80.91.229.12 (9 Jul 2010 06:23:54 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 9 Jul 2010 06:23:54 +0000 (UTC) Cc: guile-devel To: Andy Wingo Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Jul 09 08:23:53 2010 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OX701-0004Rb-6o for guile-devel@m.gmane.org; Fri, 09 Jul 2010 08:23:49 +0200 Original-Received: from localhost ([127.0.0.1]:47688 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OX700-0007Bg-77 for guile-devel@m.gmane.org; Fri, 09 Jul 2010 02:23:48 -0400 Original-Received: from [140.186.70.92] (port=49095 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OX6zr-0007Bb-Kr for guile-devel@gnu.org; Fri, 09 Jul 2010 02:23:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OX6zq-0001xt-F9 for guile-devel@gnu.org; Fri, 09 Jul 2010 02:23:39 -0400 Original-Received: from mail-vw0-f41.google.com ([209.85.212.41]:52614) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OX6zq-0001xi-Ca for guile-devel@gnu.org; Fri, 09 Jul 2010 02:23:38 -0400 Original-Received: by vws1 with SMTP id 1so97945vws.0 for ; Thu, 08 Jul 2010 23:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=B6MGGy991RDa3y3PqLYcbLBjr7Tul34v4ArhJ1+JM6I=; b=FGki081HJCy4wZpJbGyNDZx1sFf3C98x+LqmLucLlovZsjVJXF8nlICI1jjeFAamRw kX8G+04/GLs3SHBczHRZV3rxlqfdKFOvGxtwlr/cOyARJp+Js85SbDEhl91sRNCYI1BF tDhggD01oTdiPClqYSe8u2h98E6u4G4VPM0dk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=SZaxOKEf4QJ4nEi6Q/oALaXfzGaBbfECXzrVJGLQ+AkxuIWs8XPa4KECjkDxwddidx gMkD5BN9CyJdd9lwchdei7lXy1zuvlj4LsL8otFf/A5hcbxSm7Ck6ht5iXniAV28cGW7 fJZDcMiWGUkMDHqKy4sNXiB7vYCzhMdmPoqTo= Original-Received: by 10.229.95.135 with SMTP id d7mr5636578qcn.201.1278656617084; Thu, 08 Jul 2010 23:23:37 -0700 (PDT) Original-Received: by 10.229.215.21 with HTTP; Thu, 8 Jul 2010 23:23:36 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:10631 Archived-At: > Looks good; a couple of comments inline. If you want to kill trailing > whitespace, though, please do that as a separate commit, without any > functional changes How do you reconcile that with 'delete-trailing-whitespace? > Here we should produce a warning, I think, even if we are > "permissive". Also please move the trailing parens to the previous > line. Is there a standard way to do this? Presumably it will be printed on *current-warning-port*, but any specific formatting guidelines or anything?