* Re: Possible Memory Leak with stream-for-each
[not found] <AANLkTinCvRboQ6IqBBPOL5Mz0vz5XPx0J9AQf2dnDNXJ@mail.gmail.com>
@ 2010-09-02 12:49 ` Ludovic Courtès
2010-09-02 16:20 ` Julian Graham
2010-09-02 18:46 ` Andy Wingo
0 siblings, 2 replies; 3+ messages in thread
From: Ludovic Courtès @ 2010-09-02 12:49 UTC (permalink / raw)
To: guile-user; +Cc: guile-devel
Hello!
I believe this patch fixes the problem:
http://git.sv.gnu.org/cgit/guile.git/commit/?id=f57fdf07d6374028f35bcb1ee748a94022deda6d
Basically ‘force’ was leaking memory because it uses ‘lock-mutex’, which
was the culprit (!).
Julian: Could you please review this patch?
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Possible Memory Leak with stream-for-each
2010-09-02 12:49 ` Possible Memory Leak with stream-for-each Ludovic Courtès
@ 2010-09-02 16:20 ` Julian Graham
2010-09-02 18:46 ` Andy Wingo
1 sibling, 0 replies; 3+ messages in thread
From: Julian Graham @ 2010-09-02 16:20 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guile-user, guile-devel
Hey Ludovic,
On Thu, Sep 2, 2010 at 8:49 AM, Ludovic Courtès <ludo@gnu.org> wrote:
> I believe this patch fixes the problem:
>
> http://git.sv.gnu.org/cgit/guile.git/commit/?id=f57fdf07d6374028f35bcb1ee748a94022deda6d
>
> Basically ‘force’ was leaking memory because it uses ‘lock-mutex’, which
> was the culprit (!).
>
> Julian: Could you please review this patch?
Sure. That looks alright to me, especially in light of our discussion
on IRC. Summary: The list of held mutexes is not weak; it's a list of
weak-car pairs. So if a particular mutex in the list goes away, the
pair's still hanging around. The patch introduces more explicit
cleanup of that mutex list. (Thanks for clarifying that!)
Regards,
Julian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Possible Memory Leak with stream-for-each
2010-09-02 12:49 ` Possible Memory Leak with stream-for-each Ludovic Courtès
2010-09-02 16:20 ` Julian Graham
@ 2010-09-02 18:46 ` Andy Wingo
1 sibling, 0 replies; 3+ messages in thread
From: Andy Wingo @ 2010-09-02 18:46 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guile-user, guile-devel
On Thu 02 Sep 2010 05:49, ludo@gnu.org (Ludovic Courtès) writes:
> Basically ‘force’ was leaking memory because it uses ‘lock-mutex’, which
> was the culprit (!).
You are a superhero, Dr. Courtès!!
A
--
http://wingolog.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-02 18:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <AANLkTinCvRboQ6IqBBPOL5Mz0vz5XPx0J9AQf2dnDNXJ@mail.gmail.com>
2010-09-02 12:49 ` Possible Memory Leak with stream-for-each Ludovic Courtès
2010-09-02 16:20 ` Julian Graham
2010-09-02 18:46 ` Andy Wingo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).