From: Noah Lavine <noah.b.lavine@gmail.com>
To: Ken Raeburn <raeburn@raeburn.org>
Cc: guile-devel <guile-devel@gnu.org>
Subject: Re: Bug in Guile's Posix Networking
Date: Sun, 13 Feb 2011 08:55:35 -0500 [thread overview]
Message-ID: <AANLkTi=oNrrv2W2q6oDcVCaatcPt2c+wnos_6dvug2jY@mail.gmail.com> (raw)
In-Reply-To: <33545F7E-7D6A-406F-8B15-501B050181E1@raeburn.org>
Hello,
On Sun, Feb 13, 2011 at 12:42 AM, Ken Raeburn <raeburn@raeburn.org> wrote:
> What platforms have sin_len in the generic sockaddr structure? The one I've always seen is sa_len, and that's consistent with sa_family in terms of field name prefixes.
>
> sockaddr -> sa_
> sockaddr_in -> sin_
> sockaddr_in6 -> sin6_
> sockaddr_storage -> ss_
>
> I suspect you'd do fine if you ditched the test for sockaddr.sin_len and tested either sockaddr_in.sin_len or sockaddr.sa_len. (And I'd expect an OS to be consistent as to whether the _len field exists for each of the various socket address structures.)
OS X, which I use, has a somewhat weird field-naming situation. The
generic sockaddr structure has sa_len, but sockaddr_in has a sin_len
field. The code I was fixing is creating a sockaddr_in, so in order to
use the sa_len field I would have had to cast a sockaddr_in to a
sockaddr, and it just seemed cleaner to use the sin_len field. It's no
big deal either way, though - this would affect probably 10 or fewer
lines of code no matter what.
Noah
next prev parent reply other threads:[~2011-02-13 13:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 6:28 Bug in Guile's Posix Networking Noah Lavine
2011-02-07 23:49 ` Andreas Rottmann
2011-02-12 20:47 ` Noah Lavine
2011-02-12 21:02 ` Andy Wingo
2011-02-12 21:35 ` Noah Lavine
2011-02-12 22:00 ` Andy Wingo
2011-02-13 1:22 ` Noah Lavine
2011-02-13 1:45 ` Noah Lavine
2011-02-13 2:22 ` Noah Lavine
2011-02-13 3:00 ` Noah Lavine
2011-02-13 5:42 ` Ken Raeburn
2011-02-13 13:55 ` Noah Lavine [this message]
2011-02-13 13:57 ` Noah Lavine
2011-02-13 18:34 ` Ken Raeburn
2011-02-13 20:07 ` Andy Wingo
2011-02-13 20:10 ` Noah Lavine
2011-02-13 20:34 ` Noah Lavine
2011-02-13 21:10 ` Andy Wingo
2011-02-13 20:04 ` Andy Wingo
2011-02-12 11:26 ` Andy Wingo
2011-02-12 20:33 ` Noah Lavine
2011-02-12 20:59 ` Andy Wingo
2011-02-12 21:00 ` Noah Lavine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=oNrrv2W2q6oDcVCaatcPt2c+wnos_6dvug2jY@mail.gmail.com' \
--to=noah.b.lavine@gmail.com \
--cc=guile-devel@gnu.org \
--cc=raeburn@raeburn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).