From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Noah Lavine Newsgroups: gmane.lisp.guile.devel Subject: Re: PEG Parser Date: Sun, 23 Jan 2011 20:29:23 -0500 Message-ID: References: <87bp3fi5cp.fsf@gnu.org> <87aaisr6sn.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: dough.gmane.org 1295832575 11568 80.91.229.12 (24 Jan 2011 01:29:35 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 24 Jan 2011 01:29:35 +0000 (UTC) Cc: guile-devel@gnu.org To: =?ISO-8859-1?Q?Ludovic_Court=E8s?= Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Jan 24 02:29:31 2011 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PhBFL-000257-5k for guile-devel@m.gmane.org; Mon, 24 Jan 2011 02:29:31 +0100 Original-Received: from localhost ([127.0.0.1]:45827 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PhBFK-0008Of-Ls for guile-devel@m.gmane.org; Sun, 23 Jan 2011 20:29:30 -0500 Original-Received: from [140.186.70.92] (port=50149 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PhBFF-0008OT-Cr for guile-devel@gnu.org; Sun, 23 Jan 2011 20:29:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PhBFE-0000zA-FO for guile-devel@gnu.org; Sun, 23 Jan 2011 20:29:25 -0500 Original-Received: from mail-gx0-f169.google.com ([209.85.161.169]:58613) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PhBFE-0000z2-D5; Sun, 23 Jan 2011 20:29:24 -0500 Original-Received: by gxk5 with SMTP id 5so1296410gxk.0 for ; Sun, 23 Jan 2011 17:29:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=kuzMK9iZYYh2FI/QQYrsuiok79ldiPlgWbnWHb7kf/U=; b=XugcC2b3PUVm83mA0sh1mXykrm244aWTK6JPy1BBJdXyP6pdslRZTw1I3Xk7NFmT43 CD1HoGzfDWph8TccKcfJN7fcjscG55ie83O+UYwcIChgvzIpJvqugR0HqDvU95cKKOjS Ohpe7PCL+2Yu5L8nzhWyxkgGz3UrDGuj+UUWU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=RKOYMhtf7JD1UcGDwsfpbuSPIdp7Clfcoo/WVHsu6/xZUSCfr70YW9dBykkaGU0o1W 3BuqluydeSkvdsFQloxHJ+1izJI4/N3aRW+TsM9k4zOMMs29d90nLmc0FDdXWiHHMnJs Z/f5kJuFkguXrdq357tZHjSuRN0kJO2dtb1w4= Original-Received: by 10.147.124.1 with SMTP id b1mr4497792yan.22.1295832563436; Sun, 23 Jan 2011 17:29:23 -0800 (PST) Original-Received: by 10.147.32.7 with HTTP; Sun, 23 Jan 2011 17:29:23 -0800 (PST) In-Reply-To: <87aaisr6sn.fsf@gnu.org> X-Google-Sender-Auth: W02qqX27xJXbjuA733zDut94eGw X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:11329 Archived-At: Hello all, > It should have produced $top_builddir/guile.info, which can be used as > input to LCOV to generate an HTML code coverage report > (http://ltp.sourceforge.net/coverage/lcov.php). Oh, that worked. The current tests check 92.6% of the lines in peg.scm, and 90.7% of the functions. I looked through lcov's HTML guide, and it looks like what the tests miss is almost all error-handling code. However, I must say that the HTML output looked a bit suspicious - for instance, there were places where the first line of a function was marked as hit, but the second line was not. On another note, I looked at the PEG documentation, and it was quite good. When I merged the 'mlucy' branch into Guile mainline, the merge went almost cleanly - the only issues were a page of links in Guile's documentation, which was a two-line issue, and ice-9/psyntax-pp.scm, which I fixed by choosing the mainline's version and had no problems. Given this, what are the issues blocking PEG being merged (if there are any)? I'd like to work on them. Noah