From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Maxime Devos Newsgroups: gmane.lisp.guile.devel Subject: Re: GC + Java finalization Date: Fri, 19 Nov 2021 18:48:13 +0000 Message-ID: <98d5fd3f1735e9a04b7d06c0054240cc378cb528.camel@telenet.be> References: <9ce77d5e08d50456eddc575179b68ac17afc9bf6.camel@hahnjo.de> <1cc3648e5196bf23023ec7a0ab95a9ad46f8554c.camel@telenet.be> <497caf03e995dd3cad9df748a2e5e7e5e8a245eb.camel@telenet.be> <5f9eec1969de97273cb0c335587ba98080225f6e.camel@hahnjo.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30908"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.38.3-1 To: Jonas Hahnfeld , guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Fri Nov 19 19:53:52 2021 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mo91D-0007sV-IJ for guile-devel@m.gmane-mx.org; Fri, 19 Nov 2021 19:53:51 +0100 Original-Received: from localhost ([::1]:35350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mo91C-0006Od-69 for guile-devel@m.gmane-mx.org; Fri, 19 Nov 2021 13:53:50 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mo8vs-000086-3V for guile-devel@gnu.org; Fri, 19 Nov 2021 13:48:20 -0500 Original-Received: from [2a02:1800:120:4::f00:15] (port=49538 helo=andre.telenet-ops.be) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mo8vp-00047n-Fl for guile-devel@gnu.org; Fri, 19 Nov 2021 13:48:19 -0500 Original-Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by andre.telenet-ops.be with bizsmtp id LJoD2600A4UW6Th01JoD8d; Fri, 19 Nov 2021 19:48:13 +0100 In-Reply-To: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1637347693; bh=eUBkBdpUC5jH/JISq/BXcPRiv/q5xHxhACbREcP8C9w=; h=Subject:From:To:Date:In-Reply-To:References; b=JARo2OAHNZ1jjA+cuK1/Rn+DJPjt5AUJIg8uf3v0oRhklsUG75mnixf7q3xA24Avy gmDnbkw5ISZCZhAjGZdRiaN4jsPhxL1RBf41H7sF+zCW5jqcEUZsdyFvJuSPsbg5AC ta6dXDwnjr/eWjWZP4gJNQ6P6TvhANO9++Kk3apuISJC5ENmErF0OzF4y1p7LQ77Ow PsQYB0HhQwS4EMnDjxlIUpOFz7ppLjnKkLrmAOWu8tJ4iODyQ23eZIkAoK3r4jQepJ bp3GzOVJMXtIefMU2zx4QRyqEQQ6cAAGsVjsWnXYv+wrLUL5XnY85whPIQYINZgM20 XYaCjMr/N2INg== X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a02:1800:120:4::f00:15 (failed) Received-SPF: pass client-ip=2a02:1800:120:4::f00:15; envelope-from=maximedevos@telenet.be; helo=andre.telenet-ops.be X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:20974 Archived-At: Jonas Hahnfeld schreef op vr 19-11-2021 om 15:52 [+0100]: > Am Freitag, dem 19.11.2021 um 14:14 +0000 schrieb Maxime Devos: > > [...] > > > > From your other responses, I now know it is actually related to > > (non- > > )Java style finalisation, but my comment about ‘separate patch’ > > still > > seems to apply: > > > > > > > > Again, as replied in July to the same comment, it *is* a separate > > > patch for exactly this reason. > > > > More concretely, it is in the same patch as that modified > > libguile/random.c.  The patch to libguile/random.c doesn't seem to > > be for non-Java finalization reasons. Going by the commit message, > > the only possible reason I could find is: > > > > ‘There is no point in registering memory with the garbage collector > > if it doesn't need to do its job’ > > > > But I don't see any ‘registering memory’, only replacing > > scm_gc_calloc+scm_gc_free by scm_calloc+free, and without any > > finalisation in sight. Unless you mean with ‘registering memory’ > > the "random bignum chunks" argument. But that still seems unrelated > > to non-Java finalization. > > Any memory allocation through gc implicitly registers the memory. I don't mean what you mean with ‘registering memory’. I don't see that phrase anywhere at or . I only know about registering finalisers, but not about registering memory. Also, I'm not sure what you are trying to say here and in the following paragraph. Is this some kind of argument for why the change to libguile/random.c should be in the same patch, or general explanation, ...? > Both > changes are unrelated to finalization, they are there to avoid this > unnecessary registration. Thanks for the clarification, though I have no idea what ‘registration’ is ... > My previous replies only tried to clarify why > any other solution is worse. ... but what problem and what replies are you referring to here? I haven't seen any e-mails explaining GC problems in libguile/random.c. I only have seen replies about non-Java style finalisation, which do not apply to libguile/random.c (no objects but the stack have a reference to random_chunks anywhere and libguile/random.c is not playing with finalizers). > Another question: Do you actually have permission to apply my > patches? > You already reviewed my patches in July, but as they weren't applied > back then, does this mean we need somebody else to actually get them > in? No, I don't have commit access. I noted in July () that I'm not a guile dev. Greetings, Maxime.