From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Maxime Devos Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] web: authorization header scheme should be capitalized Date: Thu, 23 Jun 2022 22:40:53 +0200 Message-ID: <922957d6545149287a6aec7b9d258bf2dd7603ef.camel@telenet.be> References: <20220623202759.3578506-1-aconchillo@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-ihhknAAH3KFVXzF1C6jq" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2746"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.38.3-1 To: Aleix Conchillo =?ISO-8859-1?Q?Flaqu=E9?= , guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Thu Jun 23 22:41:37 2022 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o4Tdx-0000bP-Eo for guile-devel@m.gmane-mx.org; Thu, 23 Jun 2022 22:41:37 +0200 Original-Received: from localhost ([::1]:59052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o4Tdw-000863-FJ for guile-devel@m.gmane-mx.org; Thu, 23 Jun 2022 16:41:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4TdK-00085g-85 for guile-devel@gnu.org; Thu, 23 Jun 2022 16:40:58 -0400 Original-Received: from baptiste.telenet-ops.be ([2a02:1800:120:4::f00:13]:52894) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o4TdI-0006aV-71 for guile-devel@gnu.org; Thu, 23 Jun 2022 16:40:57 -0400 Original-Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by baptiste.telenet-ops.be with bizsmtp id mkgt270074UW6Th01kgt3K; Thu, 23 Jun 2022 22:40:53 +0200 In-Reply-To: <20220623202759.3578506-1-aconchillo@gmail.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1656016853; bh=tBbjI0JhYC+CUWVW7d0OHJ81p2/iY/2BObjL/dmuThs=; h=Subject:From:To:Date:In-Reply-To:References; b=XbDBUuKbvJVQ9CeBOLa69pDqsGj9ZI3vqromzvggXL6Ro3rB53AtBmC/on71D9g++ Ffh8Ho02wVVVyX54v5XX/y5faCenDfFZbXNim7NSIlkyIrsOFfEMkAs+WX2TK7QZL+ ucOrAQWeDWIbk+Y527rRAKFwwdUP2CIH5BBdGkvBtr3Ip/V8sneaHncmp+juBe0Rl7 1UcuZMb7vJK956FrsPtYqdH58uqH0KMzLTReDkZhXAMsw5aCOvQ5POuAu8BFdH3z26 qVZMxx6u30xsPJ7vVmUq+JE/V9meafZYlM9eW2H5kidTIVzoelMiawNTb0lJs2tWCC LDZB2iA2JOilw== Received-SPF: pass client-ip=2a02:1800:120:4::f00:13; envelope-from=maximedevos@telenet.be; helo=baptiste.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:21228 Archived-At: --=-ihhknAAH3KFVXzF1C6jq Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Aleix Conchillo Flaqu=C3=A9 schreef op do 23-06-2022 om 13:27 [-0700]: > +=C2=A0=C2=A0=C2=A0=C2=A0 (put-string port (string-titlecase (symbol->str= ing scheme))) I'd add a little explanation in a comment (e.g.: ;; While according to RFC 7617 Schemes are case-insensitive: ;; ;; =E2=80=98Note that both scheme and parameter names are matched ;; case-insensitive=E2=80=99 ;; ;; some software (*) incorrectly assumes title case for scheme ;; names, so use the more titlecase. ;; ;; (*): See, e.g., ;; ;; =20 I think it's reasonable to do some changes in Guile to work-around potential bugs in other software that Guile has no control over or even knows about, at the same time Guile seems to be just following the spec, the compatibility bug seems to be in the other software, so to help the other software a bit, I think it would be best to report things in the buggy software too. Greetings, Maxime. --=-ihhknAAH3KFVXzF1C6jq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYrTP1RccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7jEiAPsH979yxO8XZ/MJXl17rj/7cqzh 4cwmQQiPa2KV66dF/QEApyz3cOAQleEUq2wCVsjzcbYZx4iBZbQmJ5z6A4TubAU= =BJef -----END PGP SIGNATURE----- --=-ihhknAAH3KFVXzF1C6jq--