unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Andrew Whatson <whatson@gmail.com>, guile-devel@gnu.org
Subject: Re: [PATCH] Add tests for warning locations.
Date: Sat, 24 Sep 2022 23:15:45 +0200	[thread overview]
Message-ID: <91c6602b-eb80-192f-f7bb-d5b12a3841a1@telenet.be> (raw)
In-Reply-To: <20220924134608.20312-1-whatson@gmail.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 1138 bytes --]



On 24-09-2022 15:46, Andrew Whatson wrote:
> diff --git a/test-suite/tests/tree-il/unbound-spaces.scm b/test-suite/tests/tree-il/unbound-spaces.scm
> new file mode 100644
> index 000000000..9de3b9861
> --- /dev/null
> +++ b/test-suite/tests/tree-il/unbound-spaces.scm
> @@ -0,0 +1 @@
> +  (foo)
> diff --git a/test-suite/tests/tree-il/unbound-tabs.scm b/test-suite/tests/tree-il/unbound-tabs.scm
> new file mode 100644
> index 000000000..b8c7ae23d
> --- /dev/null
> +++ b/test-suite/tests/tree-il/unbound-tabs.scm
> @@ -0,0 +1 @@
> +		(foo)
> diff --git a/test-suite/tests/tree-il/unused-variable.scm b/test-suite/tests/tree-il/unused-variable.scm
> new file mode 100644
> index 000000000..73dcd3585
> --- /dev/null
> +++ b/test-suite/tests/tree-il/unused-variable.scm
> @@ -0,0 +1,3 @@
> +(lambda (x)
> +  (let ((y (+ x 2)))
> +    x))
> -- 2.37.3

I would expect they need to be registered in some Makefile.am (as 
dist_noinst_... or was it noinst_dinst?) such that they are included in 
the tarball generated by "make dist", but otherwise these seem a nice 
set of tests to me.

Greetings,
Maxime.

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

  reply	other threads:[~2022-09-24 21:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-24 13:46 [PATCH] Add tests for warning locations Andrew Whatson
2022-09-24 21:15 ` Maxime Devos [this message]
2022-09-24 22:34 ` [PATCH v2] " Andrew Whatson
2022-10-12 20:40   ` Ludovic Courtès
2022-10-13  3:12     ` [PATCH v3] " Andrew Whatson
2022-10-13  3:18     ` [PATCH v2] " Andrew Whatson
2022-11-29 18:11   ` [PATCH v3] " lloda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91c6602b-eb80-192f-f7bb-d5b12a3841a1@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=guile-devel@gnu.org \
    --cc=whatson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).