From: Marius Vollmer <mvo@zagadka.de>
Cc: David.Mosberger@acm.org
Subject: Re: bug in throw.c
Date: 03 May 2003 23:47:23 +0200 [thread overview]
Message-ID: <87znm3snx0.fsf@zagadka.ping.de> (raw)
In-Reply-To: <87fzopk96f.fsf@raven.i.defaultvalue.org>
Rob Browning <rlb@defaultvalue.org> writes:
> davidm@mostang.com (David Mosberger-Tang) writes:
>
> > Today I tried to build guile-1.6.3 on ia64 linux but it failed during
> > the build when trying to use guile to generate some documentation.
> > Subsequently, I tried the snapshot from April 4th and it had the same
> > problem. The problem is quite obvious: in throw.c, we find:
> >
> > #if 0/*def __GNUC__*/
> > /* Dirk:FIXME:: This bugfix should be removed some time. */
> > /* GCC 2.95.2 has a bug in its optimizer that makes it generate
> > incorrect code sometimes. This barrier stops it from being too
> > clever. */
> > asm volatile ("" : "=g" (winds));
> > #endif
> >
> > This is clearly bogus: the asm statement claims that it's writing the
> > "winds" variable, which isn't true. On ia64, this has the effect that
> > the "winds" gets corrupted and comes out with value "1". Just
> > disabling the workaround fixes the issue. Perhaps the workaround is
> > legitimate for some platforms, but I suspect it should always be
> > disabled for gcc v3.x or newer.
>
> Interesting. I tracked down the same problem, but thought it was
> because the optimizer was being clever with some other code that was
> using macros to mess with object internals, and inadvertently hiding
> the top-level object from the GC. I fixed it by adding a
>
> scm_remember_upto_here_1 (winds)
>
> just after the abort (), but your explanation makes sense. So if we
> remove the asm, do we know if we still need a scm_remember_upto_here_1
> (winds) to fix the problem Dirk was initially addressing (and would
> that fix it)?
(I did the original fix, not Dirk, so I'm to blame here.)
The original fix is only needed for GCC 2.95.2 and there only for
i386, probably.
I would say it is safe now to just remove the asm bogosity, as has
already been done in the 1.6 branch.
I will port he 1.6 changes to the 1.7 series.
--
GPG: D5D4E405 - 2F9B BCCC 8527 692A 04E3 331E FAF8 226A D5D4 E405
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel
next prev parent reply other threads:[~2003-05-03 21:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-07 0:01 bug in throw.c David Mosberger-Tang
2003-04-08 6:31 ` Christopher Cramer
2003-04-08 6:44 ` David Mosberger-Tang
2003-04-11 3:24 ` Rob Browning
2003-05-03 21:47 ` Marius Vollmer [this message]
2003-05-03 21:56 ` Marius Vollmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87znm3snx0.fsf@zagadka.ping.de \
--to=mvo@zagadka.de \
--cc=David.Mosberger@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).