Re: [PATCH] read-response-body should return received data when error occcurs (V2)

[Ian Price <ianprice90@googlemail.com>]

Nala Ginrut <nalaginrut@gmail.com> writes:

> +         (let* ((bv (get-bytevector-n (response-port r) nbytes)))
> +           (if (eof-object? bv)
>                 (bad-response "EOF while reading response body: ~a bytes of ~a"
> -                            (bytevector-length bv) nbytes))))))
> +                            0 nbytes)
> +               bv)))))

This still doesn't answer my concerns. I don't think the user should
have to be checking the length of the result themselves.

(let ((bv (get-bytevector-n (response-port r) nbytes)))
  (cond ((eof-object? bv)
         (incomplete-response ...))
        ((= (bytevector-length bv) nbytes) bv)
        (else
         (incomplete-response ...))))

Am I the only one who feels strongly about this?

-- 
Ian Price

"Programming is like pinball. The reward for doing it well is
the opportunity to do it again" - from "The Wizardy Compiled"