From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Per-port read options, reader directives, SRFI-105 Date: Tue, 23 Oct 2012 22:44:54 +0200 Message-ID: <87zk3cc3zt.fsf@gnu.org> References: <87a9vmvh9s.fsf@tines.lan> <87mwzdzpqf.fsf@tines.lan> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1351025114 8446 80.91.229.3 (23 Oct 2012 20:45:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Oct 2012 20:45:14 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Tue Oct 23 22:45:22 2012 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TQlLm-0008LF-Bs for guile-devel@m.gmane.org; Tue, 23 Oct 2012 22:45:22 +0200 Original-Received: from localhost ([::1]:48794 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQlLe-00020s-NE for guile-devel@m.gmane.org; Tue, 23 Oct 2012 16:45:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQlLb-00020c-KR for guile-devel@gnu.org; Tue, 23 Oct 2012 16:45:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQlLa-0003Ij-FW for guile-devel@gnu.org; Tue, 23 Oct 2012 16:45:11 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:37561) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQlLa-0003FT-8c for guile-devel@gnu.org; Tue, 23 Oct 2012 16:45:10 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1TQlLd-0008EW-SU for guile-devel@gnu.org; Tue, 23 Oct 2012 22:45:13 +0200 Original-Received: from reverse-83.fdn.fr ([80.67.176.83]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 23 Oct 2012 22:45:13 +0200 Original-Received: from ludo by reverse-83.fdn.fr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 23 Oct 2012 22:45:13 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 35 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: reverse-83.fdn.fr X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 2 Brumaire an 221 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu User-Agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux) Cancel-Lock: sha1:5dd91M4F2Ja3LQqaTfHkSYAbpjQ= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:15029 Archived-At: Hi Mark, Thanks for splitting your work into small patches! Mark H Weaver skribis: > From 41e550e653d6a6a3793741b1fd19e6b569cdf1ce Mon Sep 17 00:00:00 2001 > From: Mark H Weaver > Date: Mon, 22 Oct 2012 23:23:45 -0400 > Subject: [PATCH 1/9] Move array reader from arrays.c to read.c > > * libguile/arrays.c (read_decimal_integer): Move to read.c. > (scm_i_read_array): Remove. Incorporate the code into the > 'scm_read_array' static function in read.c. > > * libguile/arrays.h (scm_i_read_array): Remove prototype. > > * libguile/read.c (read_decimal_integer): Move here from read.c. > (scm_read_array): Incorporate the code from 'scm_i_read_array'. Call > 'scm_read_vector' and 'scm_read_sexp' instead of 'scm_read'. OK for me. Minor remarks: > +/* Read an array. This function can also read vectors and uniform > + vectors. Also, the conflict between '#f' and '#f32' and '#f64' is > + handled here. > + > + C is the first character read after the '#'. > +*/ Can you take this as an opportunity to fix the format of comments (no */ on a line of its own)? Thanks, Ludo’.