[PATCH] Exposing the HTTP server constructor and accessors

[PATCH] Exposing the HTTP server constructor and accessors

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

Hi!

Was there any particular reason for not exposing ‘make-server-impl’ et
al. in (web server)?  If no, I’d like to expose them as well as the
default implementation.

Thanks,
Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1578 bytes --]

diff --git a/module/web/server.scm b/module/web/server.scm
index 99196fa..5ea95df 100644
--- a/module/web/server.scm
+++ b/module/web/server.scm
@@ -1,6 +1,6 @@
 ;;; Web server
 
-;; Copyright (C)  2010, 2011, 2012, 2013 Free Software Foundation, Inc.
+;; Copyright (C)  2010, 2011, 2012, 2013, 2015 Free Software Foundation, Inc.
 
 ;; This library is free software; you can redistribute it and/or
 ;; modify it under the terms of the GNU Lesser General Public
@@ -84,6 +84,15 @@
   #:use-module (ice-9 iconv)
   #:export (define-server-impl
             lookup-server-impl
+
+            make-server-impl
+            server-impl?
+            server-impl-name
+            server-impl-open
+            server-impl-read
+            server-impl-write
+            server-impl-close
+
             open-server
             read-client
             handle-request

diff --git a/module/web/server/http.scm b/module/web/server/http.scm
index cda44f4..b2464c2 100644
--- a/module/web/server/http.scm
+++ b/module/web/server/http.scm
@@ -1,6 +1,6 @@
 ;;; Web I/O: HTTP
 
-;; Copyright (C)  2010, 2011, 2012 Free Software Foundation, Inc.
+;; Copyright (C)  2010, 2011, 2012, 2015 Free Software Foundation, Inc.
 
 ;; This library is free software; you can redistribute it and/or
 ;; modify it under the terms of the GNU Lesser General Public
@@ -34,7 +34,8 @@
   #:use-module (web request)
   #:use-module (web response)
   #:use-module (web server)
-  #:use-module (ice-9 poll))
+  #:use-module (ice-9 poll)
+  #:export (http))
 
 
 (define (make-default-socket family addr port)

Re: [PATCH] Exposing the HTTP server constructor and accessors

[Andy Wingo]

On Wed 04 Mar 2015 11:55, ludo@gnu.org (Ludovic Courtès) writes:

> Was there any particular reason for not exposing ‘make-server-impl’ et
> al. in (web server)?  If no, I’d like to expose them as well as the
> default implementation.

Sounds fine to me.

A
-- 
http://wingolog.org/

Re: [PATCH] Exposing the HTTP server constructor and accessors

[Ludovic Courtès]

Andy Wingo <wingo@pobox.com> skribis:

> On Wed 04 Mar 2015 11:55, ludo@gnu.org (Ludovic Courtès) writes:
>
>> Was there any particular reason for not exposing ‘make-server-impl’ et
>> al. in (web server)?  If no, I’d like to expose them as well as the
>> default implementation.
>
> Sounds fine to me.

Done, thanks.

Ludo’.