unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Andy Wingo <wingo@pobox.com>
Cc: guile-devel@gnu.org
Subject: [PATCH] Exposing the HTTP server constructor and accessors
Date: Wed, 04 Mar 2015 11:55:39 +0100	[thread overview]
Message-ID: <87zj7thw0k.fsf@gnu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

Hi!

Was there any particular reason for not exposing ‘make-server-impl’ et
al. in (web server)?  If no, I’d like to expose them as well as the
default implementation.

Thanks,
Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1578 bytes --]

diff --git a/module/web/server.scm b/module/web/server.scm
index 99196fa..5ea95df 100644
--- a/module/web/server.scm
+++ b/module/web/server.scm
@@ -1,6 +1,6 @@
 ;;; Web server
 
-;; Copyright (C)  2010, 2011, 2012, 2013 Free Software Foundation, Inc.
+;; Copyright (C)  2010, 2011, 2012, 2013, 2015 Free Software Foundation, Inc.
 
 ;; This library is free software; you can redistribute it and/or
 ;; modify it under the terms of the GNU Lesser General Public
@@ -84,6 +84,15 @@
   #:use-module (ice-9 iconv)
   #:export (define-server-impl
             lookup-server-impl
+
+            make-server-impl
+            server-impl?
+            server-impl-name
+            server-impl-open
+            server-impl-read
+            server-impl-write
+            server-impl-close
+
             open-server
             read-client
             handle-request

diff --git a/module/web/server/http.scm b/module/web/server/http.scm
index cda44f4..b2464c2 100644
--- a/module/web/server/http.scm
+++ b/module/web/server/http.scm
@@ -1,6 +1,6 @@
 ;;; Web I/O: HTTP
 
-;; Copyright (C)  2010, 2011, 2012 Free Software Foundation, Inc.
+;; Copyright (C)  2010, 2011, 2012, 2015 Free Software Foundation, Inc.
 
 ;; This library is free software; you can redistribute it and/or
 ;; modify it under the terms of the GNU Lesser General Public
@@ -34,7 +34,8 @@
   #:use-module (web request)
   #:use-module (web response)
   #:use-module (web server)
-  #:use-module (ice-9 poll))
+  #:use-module (ice-9 poll)
+  #:export (http))
 
 
 (define (make-default-socket family addr port)

             reply	other threads:[~2015-03-04 10:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04 10:55 Ludovic Courtès [this message]
2015-03-09 21:06 ` [PATCH] Exposing the HTTP server constructor and accessors Andy Wingo
2015-03-10  8:03   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zj7thw0k.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guile-devel@gnu.org \
    --cc=wingo@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).