From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Christine Lemmer-Webber Newsgroups: gmane.lisp.guile.devel Subject: Re: Guile 3 and wip-elisp/Emacs Date: Tue, 19 Oct 2021 22:51:55 -0400 Message-ID: <87zgr44dcj.fsf@dustycloud.org> References: <87mtogpwvi.fsf@elephly.net> <47-61683200-11-6332ae00@255428996> <875ytx5wvg.fsf@dustycloud.org> <875yts7jcp.fsf@dustycloud.org> <87tuhc642o.fsf@gnu.org> <874k9c5ulu.fsf@dustycloud.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13305"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.6.6; emacs 27.2 Cc: Andy Wingo , Ludovic =?utf-8?Q?Court=C3=A8s?= , Gregg Sangster , guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Wed Oct 20 04:52:53 2021 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1md1im-0003FL-SN for guile-devel@m.gmane-mx.org; Wed, 20 Oct 2021 04:52:52 +0200 Original-Received: from localhost ([::1]:52392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1md1ik-0003nz-N6 for guile-devel@m.gmane-mx.org; Tue, 19 Oct 2021 22:52:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1md1iT-0003mH-Dx for guile-devel@gnu.org; Tue, 19 Oct 2021 22:52:35 -0400 Original-Received: from dustycloud.org ([50.116.34.160]:38580) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1md1iQ-000787-Sc; Tue, 19 Oct 2021 22:52:33 -0400 Original-Received: from twig (localhost [127.0.0.1]) by dustycloud.org (Postfix) with ESMTPS id 0D24B2661E; Tue, 19 Oct 2021 22:52:29 -0400 (EDT) In-reply-to: <874k9c5ulu.fsf@dustycloud.org> Received-SPF: pass client-ip=50.116.34.160; envelope-from=cwebber@dustycloud.org; helo=dustycloud.org X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, MISSING_HEADERS=1.021, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:20920 Archived-At: Christine Lemmer-Webber writes: > Ludovic Court=C3=A8s writes: > >> Hello! >> >> Christine Lemmer-Webber skribis: >> >>> I've pushed this as origin/wip-elisp-rebased. I actually rebased it >>> again, making some naming adjustments for myself and a couple of >>> adjustments having talked to Robin. >>> >>> If nobody objects, I'd like to merge this into main. Maintainers, if >>> you have any objections, speak now or forever hold these commits! >> >> I haven=E2=80=99t looked at the branch, but I think it=E2=80=99s great t= o see it live >> and it=E2=80=99s great if it can be merged! > > I just compiled the rebased version and will be playing with it little > bits over the next few days to make sure it's reasonably good. > >> Some things to pay attention to before merging to =E2=80=98main=E2=80=99= , since it >> corresponds to the current 3.0 stable branch: >> >> =E2=80=A2 Make sure no backward incompatibilities are introduced in >> preexisting modules; >> >> =E2=80=A2 Make sure the ABI of libguile-3.0.so and that of public modu= les >> is unchanged, or is changed compatibly; > > There are, I think, two commits that could use review, but I am NOT the > right person to do this. > > 4e96211eb666751b8666beb918bf3108aa1c725b intern arbitrary constants > 433fc448ddb018767906f8808203c9668c68cd83 multiple obarrays > >> =E2=80=A2 Make sure there are reasonable tests and doc so it can be ma= intained >> (and used!) going forward; > > Three tests across elisp-compiler.test,elisp-reader.test, elisp.test. > They seem to cover enough. Also I just verified, only one commit is failing, which is the out of memory test, but that's failing on the main branch too. So looks good on that front.