From: Marius Vollmer <mvo@zagadka.ping.de>
Cc: Rob Browning <rlb@defaultvalue.org>,
guile-devel@gnu.org, guile-user@gnu.org
Subject: Re: Guile 1.5.8 beta available for testing.
Date: 28 Aug 2002 18:28:57 +0200 [thread overview]
Message-ID: <87y9arymk6.fsf@zagadka.ping.de> (raw)
In-Reply-To: <20020827090636.GA12973@sim.no>
"Lars J. Aas" <larsa@sim.no> writes:
> I'd appreciate it if the SCM_POSFIXABLE() bug, steming from the
> fallback SCM_LONG_BIT define in __scm.h, was fixed before 1.6 was
> released.
I'm not yet satisfied with the analysis. As far as I can see, the
problem lies not with SCM_LONG_BIT being unsigned incorrectly, but
with SCM_MOST_POSITIVE_FIXNUM being unsigned incorrectly.
We compute SCM_MOST_POSITIVE_FIXNUM like this
((((scm_t_signed_bits) 1) << (SCM_I_FIXNUM_BIT - 1)) - 1)
where SCM_I_FIXNUM_BIT is unsigned when SCM_LONG_BIT is. However, the
type of the result of a bit-shift operator is that of the promoted
left operand (6.5.7;3 in the ANSI C standard). So
SCM_MOST_POSITIVE_FIXNUM is signed since scm_t_signed_bits is.
Your compiler seems to get this wrong, right?
A fix would be to move the scm_t_signed_bits cast one level up, and
also in SCM_MOST_NEGATIVE_FIXNUM. We should do that and put a
deriding comment about MS on the code. OK?
Is that the only issue holding off a plain build of 1.5.8 with the
Microsoft compiler? If there are others, we shouldn't bother to work
around this particular bug in the release.
--
GPG: D5D4E405 - 2F9B BCCC 8527 692A 04E3 331E FAF8 226A D5D4 E405
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel
next prev parent reply other threads:[~2002-08-28 16:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-26 17:34 Guile 1.5.8 beta available for testing Rob Browning
2002-08-27 9:06 ` Lars J. Aas
2002-08-28 16:28 ` Marius Vollmer [this message]
2002-08-29 7:59 ` Lars J. Aas
2002-08-31 12:01 ` Marius Vollmer
2002-09-02 11:38 ` Lars J. Aas
2002-08-29 10:29 ` tomas
2002-08-29 16:22 ` Rob Browning
2002-08-29 17:18 ` tomas
2002-08-29 17:42 ` tomas
2002-08-29 17:49 ` Rob Browning
2002-08-29 18:04 ` Lynn Winebarger
2002-08-29 18:55 ` Marius Vollmer
2002-08-29 19:17 ` Lynn Winebarger
2002-08-29 19:24 ` Lynn Winebarger
2002-08-29 19:58 ` Marius Vollmer
2002-08-31 16:45 ` tomas
2002-08-29 18:49 ` Marius Vollmer
-- strict thread matches above, loose matches on Subject: below --
2002-08-28 13:34 Sven Hartrumpf
2002-08-28 14:21 ` Marius Vollmer
2002-08-28 14:38 ` Sven Hartrumpf
2002-08-28 15:34 ` Marius Vollmer
2002-08-28 16:21 ` Lynn Winebarger
2002-08-28 18:18 ` Han-Wen Nienhuys
2002-08-28 21:09 ` Sven Hartrumpf
2002-08-28 22:43 ` Han-Wen Nienhuys
2002-09-03 7:33 ` Sven Hartrumpf
2002-09-04 11:08 ` Han-Wen Nienhuys
2002-09-04 14:43 ` Sven Hartrumpf
2002-09-05 12:08 ` Han-Wen Nienhuys
2002-09-05 19:52 ` Sven Hartrumpf
2002-09-03 11:14 ` Sven Hartrumpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y9arymk6.fsf@zagadka.ping.de \
--to=mvo@zagadka.ping.de \
--cc=guile-devel@gnu.org \
--cc=guile-user@gnu.org \
--cc=rlb@defaultvalue.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).