From: Neil Jerram <neil@ossau.uklinux.net>
Cc: hanwen@xs4all.nl, guile-devel@gnu.org
Subject: Re: Backtrace and enhanced catch
Date: Mon, 23 Jan 2006 20:11:11 +0000 [thread overview]
Message-ID: <87y816d7s0.fsf@ossau.uklinux.net> (raw)
In-Reply-To: <8764oc4boj.fsf@zagadka.de> (Marius Vollmer's message of "Sun, 22 Jan 2006 15:47:08 +0200")
Marius Vollmer <mvo@zagadka.de> writes:
> Neil Jerram <neil@ossau.uklinux.net> writes:
>
>> The main part of this patch is appended below, and I would appreciate
>> any comments that anyone may have
>
> Looks very good to me. Please go ahead. Thanks!
Great; thanks for the review.
> One (minor?) point I have is the term "lazy". I am not sure if it is
> the right term to use. It has meaning for people who already know
> lazy-catch, but I'd say it is not really descriptive of what it does.
> Something like "pre-unwind" handler might give a better hint of how it
> differs from the 'post-unwind' handler.
>
> Hmm, what I'm trying to say here that "lazy" is not some standard,
> established terminology, and if we come up with something better, we
> should feel free to change terminology.
Yes, that makes good sense. I can't think of anything better than
"pre-unwind", so I'll use that in all new names. I don't think it's
worth changing any preexisting names though, such as struct lazy_catch
- do you agree?
>> One point is that I have removed the "SCM_API" from the declaration of
>> scm_i_with_continuation_barrier. My understanding is that
>> scm_i_with_continuation_barrier (like scm_i_* functions in general) is
>> a libguile-internal function and so does not need to be exported from
>> the libguile DLL in a Windows build (which is what SCM_API is for).
>
> Yeah. I have to say that I don't really understand the meaning of
> SCM_API. I mostly treat it is as a purely technical thing: you need
> to use it when you want code outside this DLL to call the function. I
> don't treat it as a way to document what is in the Guile API and what
> isn't.
>
> For example, macro or inline function that is in the Guile API might
> expand into a call to a scm_i_ function. That function than needs to
> be flagged with SCM_API although it is not part of the API.
>
> I see no point in preventing people from calling internal functions as
> long as they know that they are internal. That's why I put SCM_API on
> all functions with global scope.
OK, that makes sense too, so long as we don't have to worry about
preserving source compatibility for functions that have SCM_API but
are not part of the Guile API. And my understanding is that "part of
the Guile API" <=> "documented in the manual".
Regards,
Neil
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel
next prev parent reply other threads:[~2006-01-23 20:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-01 0:16 gh_inexact_p error in 1.7.x Bruce Korb
2005-12-01 0:44 ` Kevin Ryde
2005-12-05 4:08 ` No way out Bruce Korb
2005-12-05 4:35 ` Bruce Korb
2005-12-07 1:31 ` Marius Vollmer
2005-12-05 22:20 ` Kevin Ryde
2005-12-06 10:58 ` Han-Wen Nienhuys
2005-12-28 15:59 ` Neil Jerram
2005-12-31 15:09 ` Han-Wen Nienhuys
2005-12-31 15:14 ` Neil Jerram
2006-01-01 19:58 ` Han-Wen Nienhuys
2006-01-02 15:42 ` Neil Jerram
2006-01-02 18:54 ` Neil Jerram
2006-01-04 21:13 ` Backtrace and enhanced catch Neil Jerram
2006-01-14 12:41 ` Neil Jerram
2006-01-22 13:47 ` Marius Vollmer
2006-01-23 20:11 ` Neil Jerram [this message]
2006-01-24 21:34 ` Marius Vollmer
2006-01-16 8:38 ` Ludovic Courtès
2006-01-18 23:08 ` Neil Jerram
2006-01-19 9:38 ` Ludovic Courtès
2006-01-21 11:26 ` Neil Jerram
2006-01-26 23:29 ` Kevin Ryde
2006-01-27 19:30 ` Neil Jerram
2006-01-31 20:07 ` Kevin Ryde
2006-02-01 23:04 ` Neil Jerram
2006-02-04 0:46 ` Kevin Ryde
2006-02-04 15:41 ` Neil Jerram
2005-12-07 1:07 ` No way out Marius Vollmer
2005-12-07 1:55 ` Rob Browning
2005-12-13 20:32 ` Marius Vollmer
2005-12-28 16:09 ` Neil Jerram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y816d7s0.fsf@ossau.uklinux.net \
--to=neil@ossau.uklinux.net \
--cc=guile-devel@gnu.org \
--cc=hanwen@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).