unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Neil Jerram <neil@ossau.uklinux.net>
To: ludo@chbouib.org (Ludovic Courtès)
Cc: guile-devel@gnu.org
Subject: Re: Evaluator cleanup
Date: Sat, 24 Feb 2007 22:31:17 +0000	[thread overview]
Message-ID: <87y7mnchmy.fsf@ossau.uklinux.net> (raw)
In-Reply-To: <87irdrplpq.fsf@chbouib.org> ( Ludovic Courtès's message of "Sat, 24 Feb 2007 17:24:49 +0100")

ludo@chbouib.org (Ludovic Courtès) writes:

> Hi,
>
> I have a patch that further "despaghettifies" the evaluator, as Han-Wen
> would say.  ;-)

Can you say more about how your change despaghettifies the code?  I
can see that it makes eval.c shorter - but what else?

>  It adds two files, `eval-memoize.i.c' and
> `eval-unmemoize.i.c',

Do these need to be .i.c - i.e. implying that they need to be
#included?  Can't they be normal .c files?

> and moves memoizers in the former and unmemoizers
> in the latter.

I assume the memoizer and the unmemoizer for a particular kind of
expression need to be consistent with each other - is that right?  If
so, it seems to me that putting them in separate files might increase
the likelihood of future mistakes.

Regards,
     Neil



_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel


  reply	other threads:[~2007-02-24 22:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-24 16:24 Evaluator cleanup Ludovic Courtès
2007-02-24 22:31 ` Neil Jerram [this message]
2007-02-25  8:57   ` Ludovic Courtès
2007-02-25  9:05     ` Ludovic Courtès
2007-02-25 14:21     ` Han-Wen Nienhuys
2007-02-25 22:32 ` Kevin Ryde
2007-02-26 20:04   ` Neil Jerram
2007-02-27  8:17     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y7mnchmy.fsf@ossau.uklinux.net \
    --to=neil@ossau.uklinux.net \
    --cc=guile-devel@gnu.org \
    --cc=ludo@chbouib.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).